Skip to content

High-performance browser automation bridge and multi-instance orchestrator with advanced stealth injection and real-time dashboard.

test: add health 503 and auth middleware tests

trs-80cd8c19e2cb05
diff --git a/internal/handlers/handlers_extra_test.go b/internal/handlers/handlers_extra_test.go
index 67b033f7..fcf5e694 100644
--- a/internal/handlers/handlers_extra_test.go
+++ b/internal/handlers/handlers_extra_test.go
@@ -2,13 +2,44 @@ package handlers
import (
"bytes"
+ "fmt"
"net/http/httptest"
"testing"
"time"
+ "github.com/chromedp/cdproto/target"
"github.com/pinchtab/pinchtab/internal/config"
)
+type mockBridgeDisconnected struct {
+ mockBridge
+}
+
+func (m *mockBridgeDisconnected) ListTargets() ([]*target.Info, error) {
+ return nil, fmt.Errorf("disconnected")
+}
+
+func TestHandleHealth_Disconnected_Returns503(t *testing.T) {
+ mb := &mockBridgeDisconnected{}
+ h := New(mb, &config.RuntimeConfig{}, nil, nil, nil)
+ req := httptest.NewRequest("GET", "/health", nil)
+ w := httptest.NewRecorder()
+ h.HandleHealth(w, req)
+ if w.Code != 503 {
+ t.Errorf("expected 503 for disconnected browser, got %d", w.Code)
+ }
+}
+
+func TestHandleHealth_Connected_Returns200(t *testing.T) {
+ h := New(&mockBridge{}, &config.RuntimeConfig{}, nil, nil, nil)
+ req := httptest.NewRequest("GET", "/health", nil)
+ w := httptest.NewRecorder()
+ h.HandleHealth(w, req)
+ if w.Code != 200 {
+ t.Errorf("expected 200 for connected browser, got %d", w.Code)
+ }
+}
+
func TestHandleHealth_Response(t *testing.T) {
h := New(&mockBridge{}, &config.RuntimeConfig{}, nil, nil, nil)
req := httptest.NewRequest("GET", "/health", nil)
diff --git a/internal/handlers/middleware_test.go b/internal/handlers/middleware_test.go
index 759b2b98..9c729860 100644
--- a/internal/handlers/middleware_test.go
+++ b/internal/handlers/middleware_test.go
@@ -67,6 +67,49 @@ func TestAuthMiddleware_InvalidToken(t *testing.T) {
}
}
+func TestAuthMiddleware_TableDriven(t *testing.T) {
+ tests := []struct {
+ name string
+ token string
+ authHeader string
+ wantCode int
+ wantCalled bool
+ }{
+ {"correct token", "secret", "Bearer secret", 200, true},
+ {"wrong token", "secret", "Bearer wrong", 401, false},
+ {"partial match", "secret", "Bearer secre", 401, false},
+ {"empty bearer", "secret", "Bearer ", 401, false},
+ {"missing header", "secret", "", 401, false},
+ {"no token configured", "", "", 200, true},
+ {"no token configured with header", "", "Bearer anything", 200, true},
+ }
+
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ cfg := &config.RuntimeConfig{Token: tt.token}
+ called := false
+ handler := AuthMiddleware(cfg, http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+ called = true
+ w.WriteHeader(200)
+ }))
+
+ req := httptest.NewRequest("GET", "/test", nil)
+ if tt.authHeader != "" {
+ req.Header.Set("Authorization", tt.authHeader)
+ }
+ w := httptest.NewRecorder()
+ handler.ServeHTTP(w, req)
+
+ if called != tt.wantCalled {
+ t.Errorf("handler called = %v, want %v", called, tt.wantCalled)
+ }
+ if w.Code != tt.wantCode {
+ t.Errorf("status = %d, want %d", w.Code, tt.wantCode)
+ }
+ })
+ }
+}
+
func TestCorsMiddleware(t *testing.T) {
handler := CorsMiddleware(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.WriteHeader(200)