Skip to content

High-performance browser automation bridge and multi-instance orchestrator with advanced stealth injection and real-time dashboard.

fix: allow cloak doctor cold starts

Luigi Agostid02a996753a8
diff --git a/internal/browsers/cloak/doctor.go b/internal/browsers/cloak/doctor.go
index e16e66bc..e387feaf 100644
--- a/internal/browsers/cloak/doctor.go
+++ b/internal/browsers/cloak/doctor.go
@@ -14,8 +14,10 @@ import (
const cloakMinVersion = "120.0.0"
const cloakIdentityPlatform = "windows"
+const cloakDoctorLaunchTimeout = 60 * time.Second
var launchAndEvaluate = chrome.LaunchAndEvaluate
+var launchAndProbe = chrome.LaunchAndProbe
// DoctorChecks overrides the inherited Chrome DoctorChecks method.
func (Browser) DoctorChecks(_ browsers.TargetConfig) []browsers.DoctorCheck {
@@ -129,7 +131,7 @@ func cloakPresenceCheck(ctx context.Context, cfg interface{}) browsers.DoctorChe
if env, ok := cfg.(*browsers.DoctorEnv); ok && env != nil && env.NoSandbox {
identityArgs = append(identityArgs, "--no-sandbox")
}
- _, err = launchAndEvaluate(ctx, found, identityArgs, 10*time.Second, "navigator.platform", &platform)
+ _, err = launchAndEvaluate(ctx, found, identityArgs, cloakDoctorLaunchTimeout, "navigator.platform", &platform)
if err != nil || platform != "Win32" {
reason := fmt.Sprintf("fingerprint platform probe returned %q, want Win32", platform)
if err != nil {
@@ -176,7 +178,7 @@ func cdpReachableCheck(ctx context.Context, cfg interface{}) browsers.DoctorChec
if env.NoSandbox {
args = append(args, "--no-sandbox")
}
- res, err := chrome.LaunchAndProbe(ctx, bin, args, 10*time.Second)
+ res, err := launchAndProbe(ctx, bin, args, cloakDoctorLaunchTimeout)
if err != nil {
return browsers.DoctorCheckResult{Status: browsers.DoctorFail, Detail: err.Error(), Err: err}
}
@@ -219,7 +221,7 @@ func fingerprintFlagsCheck(ctx context.Context, cfg interface{}) browsers.Doctor
if env.NoSandbox {
fpFlags = append(fpFlags, "--no-sandbox")
}
- res, err := chrome.LaunchAndProbe(ctx, bin, fpFlags, 10*time.Second)
+ res, err := launchAndProbe(ctx, bin, fpFlags, cloakDoctorLaunchTimeout)
if err != nil {
return browsers.DoctorCheckResult{
Status: browsers.DoctorFail,
diff --git a/internal/browsers/cloak/doctor_test.go b/internal/browsers/cloak/doctor_test.go
index 7e1bfab1..2f9b7146 100644
--- a/internal/browsers/cloak/doctor_test.go
+++ b/internal/browsers/cloak/doctor_test.go
@@ -96,3 +96,64 @@ func TestCloakPresenceRejectsChromeEvenUnderCloakNamedDirectory(t *testing.T) {
})
}
}
+
+func TestCloakPresenceAllowsColdStart(t *testing.T) {
+ if runtime.GOOS == "windows" {
+ t.Skip("cloakbrowser_present is skipped on windows")
+ }
+ binary := filepath.Join(t.TempDir(), "cloakbrowser")
+ if err := os.WriteFile(binary, []byte("#!/bin/sh\necho 'Chromium 145.0.0.0'\n"), 0o755); err != nil {
+ t.Fatal(err)
+ }
+
+ original := launchAndEvaluate
+ launchAndEvaluate = func(_ context.Context, _ string, _ []string, timeout time.Duration, _ string, value any) (chrome.CDPProbeResult, error) {
+ if timeout < 22*time.Second {
+ return chrome.CDPProbeResult{}, context.DeadlineExceeded
+ }
+ *value.(*string) = "Win32"
+ return chrome.CDPProbeResult{Port: 9222}, nil
+ }
+ t.Cleanup(func() { launchAndEvaluate = original })
+
+ result := cloakPresenceCheck(context.Background(), &browsers.DoctorEnv{Binary: binary})
+ if result.Status != browsers.DoctorPass {
+ t.Fatalf("status = %v, want pass after cold start: %s", result.Status, result.Detail)
+ }
+}
+
+func TestCDPReachableAllowsColdStart(t *testing.T) {
+ original := launchAndProbe
+ launchAndProbe = func(_ context.Context, _ string, _ []string, timeout time.Duration) (chrome.CDPProbeResult, error) {
+ if timeout < 22*time.Second {
+ return chrome.CDPProbeResult{}, context.DeadlineExceeded
+ }
+ return chrome.CDPProbeResult{Port: 9222}, nil
+ }
+ t.Cleanup(func() { launchAndProbe = original })
+
+ result := cdpReachableCheck(context.Background(), &browsers.DoctorEnv{Binary: "/cloakbrowser"})
+ if result.Status != browsers.DoctorPass {
+ t.Fatalf("status = %v, want pass after cold start: %s", result.Status, result.Detail)
+ }
+}
+
+func TestFingerprintFlagsAllowColdStart(t *testing.T) {
+ original := launchAndProbe
+ launchAndProbe = func(_ context.Context, _ string, _ []string, timeout time.Duration) (chrome.CDPProbeResult, error) {
+ if timeout < 22*time.Second {
+ return chrome.CDPProbeResult{}, context.DeadlineExceeded
+ }
+ return chrome.CDPProbeResult{Port: 9222}, nil
+ }
+ t.Cleanup(func() { launchAndProbe = original })
+
+ env := &browsers.DoctorEnv{
+ Binary: "/cloakbrowser",
+ Cloak: browsers.CloakFingerprint{FingerprintSeed: "test-seed"},
+ }
+ result := fingerprintFlagsCheck(context.Background(), env)
+ if result.Status != browsers.DoctorPass {
+ t.Fatalf("status = %v, want pass after cold start: %s", result.Status, result.Detail)
+ }
+}