Skip to content

High-performance browser automation bridge and multi-instance orchestrator with advanced stealth injection and real-time dashboard.

feat(cli): add open/close commands, deprecate nav

Boschd732eae48b50
diff --git a/cmd/pinchtab/cmd_cli.go b/cmd/pinchtab/cmd_cli.go
index 49f0c245..d80f68ef 100644
--- a/cmd/pinchtab/cmd_cli.go
+++ b/cmd/pinchtab/cmd_cli.go
@@ -25,8 +25,9 @@ var quickCmd = &cobra.Command{
}
var navCmd = &cobra.Command{
- Use: "nav <url>",
- Short: "Navigate to URL",
+ Use: "nav <url>",
+ Short: "Navigate to URL (alias for open)",
+ Deprecated: "use 'open' instead",
Args: cobra.ExactArgs(1),
Run: func(cmd *cobra.Command, args []string) {
cfg := config.Load()
@@ -86,6 +87,38 @@ var screenshotCmd = &cobra.Command{
},
}
+var openCmd = &cobra.Command{
+ Use: "open <url>",
+ Short: "Open a URL (navigates current tab or creates new)",
+ Args: cobra.ExactArgs(1),
+ Run: func(cmd *cobra.Command, args []string) {
+ cfg := config.Load()
+ runCLIWith(cfg, func(client *http.Client, base, token string) {
+ browseractions.Navigate(client, base, token, args[0], cmd)
+ })
+ },
+}
+
+var closeCmd = &cobra.Command{
+ Use: "close [tabId]",
+ Short: "Close a tab",
+ Args: cobra.MaximumNArgs(1),
+ Run: func(cmd *cobra.Command, args []string) {
+ cfg := config.Load()
+ runCLIWith(cfg, func(client *http.Client, base, token string) {
+ tabID, _ := cmd.Flags().GetString("tab")
+ if len(args) > 0 {
+ tabID = args[0]
+ }
+ if tabID == "" {
+ fmt.Fprintln(os.Stderr, "error: specify a tab ID as argument or via --tab")
+ os.Exit(1)
+ }
+ browseractions.TabClose(client, base, token, tabID)
+ })
+ },
+}
+
var tabsCmd = &cobra.Command{
Use: "tabs",
Short: "List or manage tabs",
@@ -273,6 +306,8 @@ var selectCmd = &cobra.Command{
func init() {
quickCmd.GroupID = "browser"
+ openCmd.GroupID = "browser"
+ closeCmd.GroupID = "browser"
navCmd.GroupID = "browser"
snapCmd.GroupID = "browser"
clickCmd.GroupID = "browser"
@@ -369,6 +404,13 @@ func init() {
textCmd.Flags().Bool("raw", false, "Raw extraction mode")
textCmd.Flags().String("tab", "", "Tab ID")
+ openCmd.Flags().Bool("new-tab", false, "Open in new tab")
+ openCmd.Flags().Bool("block-images", false, "Block image loading")
+ openCmd.Flags().Bool("block-ads", false, "Block ads")
+ openCmd.Flags().String("tab", "", "Tab ID")
+
+ closeCmd.Flags().String("tab", "", "Tab ID")
+
navCmd.Flags().Bool("new-tab", false, "Open in new tab")
navCmd.Flags().Bool("block-images", false, "Block image loading")
navCmd.Flags().Bool("block-ads", false, "Block ads")
@@ -384,6 +426,8 @@ func init() {
evalCmd.Flags().String("tab", "", "Tab ID")
rootCmd.AddCommand(quickCmd)
+ rootCmd.AddCommand(openCmd)
+ rootCmd.AddCommand(closeCmd)
rootCmd.AddCommand(navCmd)
rootCmd.AddCommand(snapCmd)
rootCmd.AddCommand(clickCmd)
diff --git a/tests/e2e/scenarios-cli/35-open-close.sh b/tests/e2e/scenarios-cli/35-open-close.sh
new file mode 100755
index 00000000..c43091c7
--- /dev/null
+++ b/tests/e2e/scenarios-cli/35-open-close.sh
@@ -0,0 +1,93 @@
+#!/bin/bash
+# 35-open-close.sh — CLI open/close commands
+
+source "$(dirname "$0")/common.sh"
+
+# ─────────────────────────────────────────────────────────────────
+start_test "pinchtab open <url>"
+
+pt_ok open "${FIXTURES_URL}/index.html"
+assert_output_json
+assert_output_contains "tabId" "returns tab ID"
+assert_output_contains "title" "returns page title"
+
+end_test
+
+# ─────────────────────────────────────────────────────────────────
+start_test "pinchtab open --new-tab <url>"
+
+pt_ok open --new-tab "${FIXTURES_URL}/form.html"
+assert_output_json
+assert_output_contains "tabId" "returns tab ID for new tab"
+
+end_test
+
+# ─────────────────────────────────────────────────────────────────
+start_test "pinchtab open --block-images <url>"
+
+pt_ok open --block-images "${FIXTURES_URL}/index.html"
+assert_output_json
+assert_output_contains "tabId" "navigated with images blocked"
+
+end_test
+
+# ─────────────────────────────────────────────────────────────────
+start_test "pinchtab open (no args → error)"
+
+pt_fail open
+assert_output_contains "requires" "shows usage error"
+
+end_test
+
+# ─────────────────────────────────────────────────────────────────
+start_test "pinchtab close <tabId>"
+
+# Open a tab to close
+pt_ok open --new-tab "${FIXTURES_URL}/index.html"
+TAB_ID=$(echo "$PT_OUT" | jq -r '.tabId // empty')
+
+if [ -n "$TAB_ID" ]; then
+ pt_ok close "$TAB_ID"
+ echo -e " ${GREEN}✓${NC} closed tab $TAB_ID"
+ ((ASSERTIONS_PASSED++)) || true
+else
+ echo -e " ${RED}✗${NC} could not get tab ID to close"
+ ((ASSERTIONS_FAILED++)) || true
+fi
+
+end_test
+
+# ─────────────────────────────────────────────────────────────────
+start_test "pinchtab close --tab <tabId>"
+
+pt_ok open --new-tab "${FIXTURES_URL}/index.html"
+TAB_ID=$(echo "$PT_OUT" | jq -r '.tabId // empty')
+
+if [ -n "$TAB_ID" ]; then
+ pt_ok close --tab "$TAB_ID"
+ echo -e " ${GREEN}✓${NC} closed tab via --tab flag"
+ ((ASSERTIONS_PASSED++)) || true
+else
+ echo -e " ${RED}✗${NC} could not get tab ID to close"
+ ((ASSERTIONS_FAILED++)) || true
+fi
+
+end_test
+
+# ─────────────────────────────────────────────────────────────────
+start_test "pinchtab close (no args, no --tab → error)"
+
+pt_fail close
+assert_output_contains "specify a tab ID" "requires tab ID"
+
+end_test
+
+# ─────────────────────────────────────────────────────────────────
+start_test "pinchtab nav shows deprecation notice"
+
+pt_ok nav "${FIXTURES_URL}/index.html"
+# Cobra prints deprecation to stderr, but output should still work
+assert_output_json
+assert_output_contains "tabId" "nav still works as alias"
+
+end_test