Skip to content

High-performance browser automation bridge and multi-instance orchestrator with advanced stealth injection and real-time dashboard.

fix: handle empty body in HandleSolve, fix errcheck lint in solver tests

Bosche337478c2dd7
diff --git a/internal/handlers/solver.go b/internal/handlers/solver.go
index 1be0db2a..c9c008ea 100644
--- a/internal/handlers/solver.go
+++ b/internal/handlers/solver.go
@@ -56,7 +56,7 @@ func (h *Handlers) HandleSolve(w http.ResponseWriter, r *http.Request) {
Timeout float64 `json:"timeout"`
}
- if err := json.NewDecoder(http.MaxBytesReader(w, r.Body, maxBodySize)).Decode(&req); err != nil {
+ if err := json.NewDecoder(http.MaxBytesReader(w, r.Body, maxBodySize)).Decode(&req); err != nil && !errors.Is(err, io.EOF) {
httpx.Error(w, 400, fmt.Errorf("decode: %w", err))
return
}
diff --git a/internal/handlers/solver_test.go b/internal/handlers/solver_test.go
index 9f710747..f16d6804 100644
--- a/internal/handlers/solver_test.go
+++ b/internal/handlers/solver_test.go
@@ -56,6 +56,19 @@ func TestHandleSolve_InvalidBody(t *testing.T) {
}
}
+func TestHandleSolve_EmptyBody(t *testing.T) {
+ h := New(&mockBridge{}, &config.RuntimeConfig{}, nil, nil, nil)
+
+ req := httptest.NewRequest("POST", "/solve", nil)
+ w := httptest.NewRecorder()
+ h.HandleSolve(w, req)
+
+ // Empty body should use defaults (auto-detect), not 400.
+ if w.Code == 400 {
+ t.Errorf("expected non-400 for empty body, got 400: %s", w.Body.String())
+ }
+}
+
func TestHandleSolve_UnknownSolver(t *testing.T) {
h := New(&mockBridge{}, &config.RuntimeConfig{}, nil, nil, nil)
diff --git a/internal/solver/solver_test.go b/internal/solver/solver_test.go
index cb2282b6..bcc437a6 100644
--- a/internal/solver/solver_test.go
+++ b/internal/solver/solver_test.go
@@ -50,7 +50,9 @@ func TestMustRegisterPanicsOnDuplicate(t *testing.T) {
func TestGet(t *testing.T) {
defer cleanup("test-get")
- Register("test-get", &fakeSolver{name: "test-get"})
+ if err := Register("test-get", &fakeSolver{name: "test-get"}); err != nil {
+ t.Fatalf("Register failed: %v", err)
+ }
s, ok := Get("test-get")
if !ok || s == nil {
@@ -70,8 +72,12 @@ func TestNames(t *testing.T) {
defer cleanup("test-names-a")
defer cleanup("test-names-b")
- Register("test-names-a", &fakeSolver{name: "a"})
- Register("test-names-b", &fakeSolver{name: "b"})
+ if err := Register("test-names-a", &fakeSolver{name: "a"}); err != nil {
+ t.Fatalf("Register failed: %v", err)
+ }
+ if err := Register("test-names-b", &fakeSolver{name: "b"}); err != nil {
+ t.Fatalf("Register failed: %v", err)
+ }
names := Names()
found := map[string]bool{}
@@ -90,11 +96,13 @@ func TestSolve_Named(t *testing.T) {
defer cleanup("test-solve")
expected := &Result{Solver: "test-solve", Solved: true, Attempts: 1}
- Register("test-solve", &fakeSolver{
+ if err := Register("test-solve", &fakeSolver{
name: "test-solve",
canHandle: true,
result: expected,
- })
+ }); err != nil {
+ t.Fatalf("Register failed: %v", err)
+ }
result, err := Solve(context.Background(), "test-solve", Options{MaxAttempts: 3})
if err != nil {
@@ -119,15 +127,19 @@ func TestSolve_AutoDetect(t *testing.T) {
defer cleanup("test-auto-no")
defer cleanup("test-auto-yes")
- Register("test-auto-no", &fakeSolver{
+ if err := Register("test-auto-no", &fakeSolver{
name: "test-auto-no",
canHandle: false,
- })
- Register("test-auto-yes", &fakeSolver{
+ }); err != nil {
+ t.Fatalf("Register failed: %v", err)
+ }
+ if err := Register("test-auto-yes", &fakeSolver{
name: "test-auto-yes",
canHandle: true,
result: &Result{Solver: "test-auto-yes", Solved: true},
- })
+ }); err != nil {
+ t.Fatalf("Register failed: %v", err)
+ }
result, err := Solve(context.Background(), "", Options{})
if err != nil {
@@ -141,10 +153,12 @@ func TestSolve_AutoDetect(t *testing.T) {
func TestSolve_NoChallenge(t *testing.T) {
defer cleanup("test-noop")
- Register("test-noop", &fakeSolver{
+ if err := Register("test-noop", &fakeSolver{
name: "test-noop",
canHandle: false,
- })
+ }); err != nil {
+ t.Fatalf("Register failed: %v", err)
+ }
result, err := Solve(context.Background(), "", Options{})
if err != nil {
@@ -156,7 +170,7 @@ func TestSolve_NoChallenge(t *testing.T) {
}
func TestUnregister(t *testing.T) {
- Register("test-unreg", &fakeSolver{name: "test-unreg"})
+ _ = Register("test-unreg", &fakeSolver{name: "test-unreg"})
Unregister("test-unreg")
_, ok := Get("test-unreg")
diff --git a/npm/skills/pinchtab/SKILL.md b/npm/skills/pinchtab/SKILL.md
index 2f9e54e4..dc526719 100644
--- a/npm/skills/pinchtab/SKILL.md
+++ b/npm/skills/pinchtab/SKILL.md
@@ -363,6 +363,7 @@ curl -X POST http://localhost:9868/action \
curl http://localhost:9868/text
+## Instance-scoped solve (instance port, not server port)
curl -X POST http://localhost:9868/solve \
-H "Content-Type: application/json" \
-d '{"maxAttempts": 3}'
diff --git a/skills/pinchtab/SKILL.md b/skills/pinchtab/SKILL.md
index 2f9e54e4..dc526719 100644
--- a/skills/pinchtab/SKILL.md
+++ b/skills/pinchtab/SKILL.md
@@ -363,6 +363,7 @@ curl -X POST http://localhost:9868/action \
curl http://localhost:9868/text
+## Instance-scoped solve (instance port, not server port)
curl -X POST http://localhost:9868/solve \
-H "Content-Type: application/json" \
-d '{"maxAttempts": 3}'