Skip to content

High-performance browser automation bridge and multi-instance orchestrator with advanced stealth injection and real-time dashboard.

fix: mask sensitive config values and annotate trusted subprocess launches

Boscheaa516bc4aa0
diff --git a/cmd/pinchtab/cmd_config_actions.go b/cmd/pinchtab/cmd_config_actions.go
index d9ee3747..f9cf9eb9 100644
--- a/cmd/pinchtab/cmd_config_actions.go
+++ b/cmd/pinchtab/cmd_config_actions.go
@@ -123,12 +123,24 @@ func confirmSaveAnyway() bool {
}
func displayConfigValue(path, value string) string {
- if strings.EqualFold(strings.TrimSpace(path), "server.token") {
+ if isSensitiveConfigPath(path) {
return config.MaskToken(value)
}
return value
}
+// isSensitiveConfigPath reports whether a config path points at a secret
+// (token/password/credential) so its value is masked before being printed.
+func isSensitiveConfigPath(path string) bool {
+ segments := strings.Split(strings.ToLower(strings.TrimSpace(path)), ".")
+ last := segments[len(segments)-1]
+ switch last {
+ case "token", "password", "secret", "apikey", "apisecret":
+ return true
+ }
+ return false
+}
+
func handleConfigValidate() {
configPath, errs, err := workflow.ValidateCurrentFile()
if err != nil {
diff --git a/cmd/pinchtab/cmd_config_test.go b/cmd/pinchtab/cmd_config_test.go
index aa3681aa..194150bf 100644
--- a/cmd/pinchtab/cmd_config_test.go
+++ b/cmd/pinchtab/cmd_config_test.go
@@ -369,6 +369,22 @@ func TestConfigSetHintsRestartWhenServerRunning(t *testing.T) {
}
}
+func TestIsSensitiveConfigPath(t *testing.T) {
+ cases := map[string]bool{
+ "server.token": true,
+ "instanceDefaults.proxy.password": true,
+ "autosolver.credentials.capsolver.apiKey": true,
+ "cloak.fontsDir": false,
+ "strategy": false,
+ "": false,
+ }
+ for path, want := range cases {
+ if got := isSensitiveConfigPath(path); got != want {
+ t.Errorf("isSensitiveConfigPath(%q) = %v, want %v", path, got, want)
+ }
+ }
+}
+
func TestConfigSetMasksServerTokenInOutput(t *testing.T) {
configPath := filepath.Join(t.TempDir(), "config.json")
t.Setenv("PINCHTAB_CONFIG", configPath)
diff --git a/internal/browsers/chrome/cdp_probe.go b/internal/browsers/chrome/cdp_probe.go
index c17e84ae..62d175f8 100644
--- a/internal/browsers/chrome/cdp_probe.go
+++ b/internal/browsers/chrome/cdp_probe.go
@@ -42,7 +42,7 @@ func LaunchAndProbe(ctx context.Context, binary string, extraArgs []string, time
}
args = append(args, extraArgs...)
- cmd := exec.CommandContext(cctx, binary, args...)
+ cmd := exec.CommandContext(cctx, binary, args...) // #nosec G204 -- binary is a browser path from config or provider discovery, not user input
stderr, err := cmd.StderrPipe()
if err != nil {
return CDPProbeResult{}, fmt.Errorf("attach stderr: %w", err)
diff --git a/internal/doctor/checks_binary.go b/internal/doctor/checks_binary.go
index a881326a..66f1f075 100644
--- a/internal/doctor/checks_binary.go
+++ b/internal/doctor/checks_binary.go
@@ -76,7 +76,7 @@ func checkBinaryStarts(ctx context.Context, cfg *config.RuntimeConfig) CheckResu
cctx, cancel := context.WithTimeout(ctx, 5*time.Second)
defer cancel()
- cmd := exec.CommandContext(cctx, bin, "--version")
+ cmd := exec.CommandContext(cctx, bin, "--version") // #nosec G204 -- bin is a browser path from config/discovery, not user input
out, err := cmd.CombinedOutput()
if err != nil {
return CheckResult{
diff --git a/tests/tools/runner/internal/e2e/provider.go b/tests/tools/runner/internal/e2e/provider.go
index 1b1cf722..19b6cf91 100644
--- a/tests/tools/runner/internal/e2e/provider.go
+++ b/tests/tools/runner/internal/e2e/provider.go
@@ -289,7 +289,7 @@ func (r *Runner) ensureCloakImage(image string) error {
}
func dockerImagePresent(image string) (bool, error) {
- cmd := exec.Command("docker", "image", "inspect", image)
+ cmd := exec.Command("docker", "image", "inspect", image) // #nosec G204 -- fixed docker command; image name is runner-controlled, not user input
out, err := cmd.CombinedOutput()
if err == nil {
return true, nil