Skip to content

High-performance browser automation bridge and multi-instance orchestrator with advanced stealth injection and real-time dashboard.

fix(dashboard): reject empty config updates (PIN-278)

Luigi Agostif66b26be82c5
diff --git a/internal/dashboard/config_api.go b/internal/dashboard/config_api.go
index cd21e244..199257c6 100644
--- a/internal/dashboard/config_api.go
+++ b/internal/dashboard/config_api.go
@@ -190,6 +190,12 @@ func (c *ConfigAPI) parseConfigUpdate(w http.ResponseWriter, r *http.Request, cu
return config.FileConfig{}, false
}
+ var fields map[string]json.RawMessage
+ if err := json.Unmarshal(body, &fields); err != nil || len(fields) == 0 {
+ httpx.ErrorCode(w, 400, "empty_config_update", "config update contains no recognized fields", false, nil)
+ return config.FileConfig{}, false
+ }
+
normalized := *current
if err := json.NewDecoder(bytes.NewReader(body)).Decode(&normalized); err != nil {
httpx.ErrorCode(w, 400, "bad_config_json", "invalid config payload", false, nil)
diff --git a/internal/dashboard/config_api_test.go b/internal/dashboard/config_api_test.go
index 85bef206..71c65ea3 100644
--- a/internal/dashboard/config_api_test.go
+++ b/internal/dashboard/config_api_test.go
@@ -447,6 +447,31 @@ func TestHandlePutConfigRefusesAnyUnrecognizedTopLevelKey(t *testing.T) {
}
}
+func TestHandlePutConfigRefusesBodyWithNoRecognizedFields(t *testing.T) {
+ fc := config.DefaultFileConfig()
+ fc.Server.Token = "secret-token"
+ api := newConfigAPITestAPI(t, fc)
+
+ req := httptest.NewRequest(http.MethodPut, "/api/config", strings.NewReader(`{}`))
+ w := httptest.NewRecorder()
+ api.HandlePutConfig(w, req)
+
+ if w.Code != http.StatusBadRequest {
+ t.Fatalf("HandlePutConfig() status = %d, want %d; body=%s", w.Code, http.StatusBadRequest, w.Body.String())
+ }
+ if !strings.Contains(w.Body.String(), "empty_config_update") {
+ t.Fatalf("response = %q, want empty_config_update error", w.Body.String())
+ }
+
+ saved, _, err := config.LoadFileConfig()
+ if err != nil {
+ t.Fatalf("LoadFileConfig() error = %v", err)
+ }
+ if saved.Timeouts.ActionSec != fc.Timeouts.ActionSec {
+ t.Fatalf("saved timeouts.actionSec = %d, want unchanged %d", saved.Timeouts.ActionSec, fc.Timeouts.ActionSec)
+ }
+}
+
func TestHandlePutConfigRequiresElevationForProxyChangeWithDashboardCookie(t *testing.T) {
fc := config.DefaultFileConfig()
fc.Server.Token = "secret-token"