π₯π₯π₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.
TypeScript boardsbug-trackerdjangodockerganttissue-trackerjirajira-alternativekanbanlinearpostgresqlproduct-managementproject-managementproject-planningpythonreactredistypesciptvitework-management
fix: IDOR Vulnerabilities in Asset & Attachment Endpoints (#8644)
sriram veeraghanta1548288e9572
diff --git a/apps/api/plane/app/views/asset/v2.py b/apps/api/plane/app/views/asset/v2.pyindex c0580c1149..3677537bb1 100644--- a/apps/api/plane/app/views/asset/v2.py+++ b/apps/api/plane/app/views/asset/v2.py@@ -603,7 +603,7 @@ class ProjectAssetEndpoint(BaseAPIView):@allow_permission([ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST])def patch(self, request, slug, project_id, pk):# get the asset id- asset = FileAsset.objects.get(id=pk)+ asset = FileAsset.objects.get(id=pk, workspace__slug=slug, project_id=project_id)# get the storage metadataasset.is_uploaded = True# get the storage metadatadiff --git a/apps/api/plane/app/views/issue/attachment.py b/apps/api/plane/app/views/issue/attachment.pyindex 7b7ecf378b..3600a0766e 100644--- a/apps/api/plane/app/views/issue/attachment.py+++ b/apps/api/plane/app/views/issue/attachment.py@@ -56,7 +56,11 @@ class IssueAttachmentEndpoint(BaseAPIView):@allow_permission([ROLE.ADMIN], creator=True, model=FileAsset)def delete(self, request, slug, project_id, issue_id, pk):- issue_attachment = FileAsset.objects.get(pk=pk)+ issue_attachment = FileAsset.objects.filter(+ pk=pk, workspace__slug=slug, project_id=project_id, issue_id=issue_id+ ).first()+ if not issue_attachment:+ return Response(status=status.HTTP_404_NOT_FOUND)issue_attachment.asset.delete(save=False)issue_attachment.delete()issue_activity.delay(