Skip to content

armgit / plane

Public Imported from GitHub
0

πŸ”₯πŸ”₯πŸ”₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.

[WEB-5654]fix: custom select selection and dropdown close #8324

Vamsi Krishna192ed9ba8dc9
diff --git a/packages/ui/src/dropdowns/custom-select.tsx b/packages/ui/src/dropdowns/custom-select.tsx
index 4423bd49c6..c184dd70d0 100644
--- a/packages/ui/src/dropdowns/custom-select.tsx
+++ b/packages/ui/src/dropdowns/custom-select.tsx
@@ -146,9 +146,13 @@ function Option(props: ICustomSelectItemProps) {
const { children, value, className } = props;
const closeDropdown = useContext(DropdownContext);
- const handleMouseDown = useCallback(() => {
+ const handleClick = useCallback(() => {
// Close dropdown for both new and already-selected options.
- requestAnimationFrame(() => closeDropdown());
+ // Use setTimeout to ensure HeadlessUI's onChange handler fires first for new selections.
+ // For already-selected options, this ensures the dropdown closes since onChange won't fire.
+ setTimeout(() => {
+ closeDropdown();
+ }, 0);
}, [closeDropdown]);
return (
@@ -163,9 +167,10 @@ function Option(props: ICustomSelectItemProps) {
className
)
}
+ onClick={handleClick}
>
{({ selected }) => (
- <div onMouseDown={handleMouseDown} className="flex items-center justify-between gap-2 w-full">
+ <div className="flex items-center justify-between gap-2 w-full">
{children}
{selected && <Check className="h-3.5 w-3.5 flex-shrink-0" />}
</div>