π₯π₯π₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.
TypeScript boardsbug-trackerdjangodockerganttissue-trackerjirajira-alternativekanbanlinearpostgresqlproduct-managementproject-managementproject-planningpythonreactredistypesciptvitework-management
[WEB-1674] chore: views access control (#4885)
Bavisetti Narayan198452430f99
diff --git a/apiserver/plane/app/serializers/view.py b/apiserver/plane/app/serializers/view.pyindex 32fba7d0c9..6b08ae80b8 100644--- a/apiserver/plane/app/serializers/view.py+++ b/apiserver/plane/app/serializers/view.py@@ -3,18 +3,12 @@ from rest_framework import serializers# Module importsfrom .base import DynamicBaseSerializer-from .workspace import WorkspaceLiteSerializer-from .project import ProjectLiteSerializerfrom plane.db.models import IssueViewfrom plane.utils.issue_filters import issue_filtersclass IssueViewSerializer(DynamicBaseSerializer):is_favorite = serializers.BooleanField(read_only=True)- project_detail = ProjectLiteSerializer(source="project", read_only=True)- workspace_detail = WorkspaceLiteSerializer(- source="workspace", read_only=True- )class Meta:model = IssueView@@ -24,6 +18,8 @@ class IssueViewSerializer(DynamicBaseSerializer):"project","query","owned_by",+ "access",+ "is_locked",]def create(self, validated_data):diff --git a/apiserver/plane/app/views/view/base.py b/apiserver/plane/app/views/view/base.pyindex 8e9f5b284a..fc44866fc2 100644--- a/apiserver/plane/app/views/view/base.py+++ b/apiserver/plane/app/views/view/base.py@@ -69,11 +69,40 @@ class WorkspaceViewViewSet(BaseViewSet):.get_queryset().filter(workspace__slug=self.kwargs.get("slug")).filter(project__isnull=True)+ .filter(Q(owned_by=self.request.user) | Q(access=1)).select_related("workspace").order_by(self.request.GET.get("order_by", "-created_at")).distinct())+ def partial_update(self, request, slug, pk):+ workspace_view = IssueView.objects.get(+ pk=pk,+ workspace__slug=slug,+ )++ if workspace_view.is_locked:+ return Response(+ {"error": "view is locked"},+ status=status.HTTP_400_BAD_REQUEST,+ )++ # Only update the view if owner is updating+ if workspace_view.owned_by_id != request.user.id:+ return Response(+ {"error": "Only the owner of the view can update the view"},+ status=status.HTTP_400_BAD_REQUEST,+ )++ serializer = IssueViewSerializer(+ workspace_view, data=request.data, partial=True+ )++ if serializer.is_valid():+ serializer.save()+ return Response(serializer.data, status=status.HTTP_200_OK)+ return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)+class WorkspaceViewIssuesViewSet(BaseViewSet):permission_classes = [@@ -294,6 +323,7 @@ class IssueViewViewSet(BaseViewSet):project__project_projectmember__is_active=True,project__archived_at__isnull=True,)+ .filter(Q(owned_by=self.request.user) | Q(access=1)).select_related("project").select_related("workspace").annotate(is_favorite=Exists(subquery))@@ -313,6 +343,33 @@ class IssueViewViewSet(BaseViewSet):).datareturn Response(views, status=status.HTTP_200_OK)+ def partial_update(self, request, slug, project_id, pk):+ issue_view = IssueView.objects.get(+ pk=pk, workspace__slug=slug, project_id=project_id+ )++ if issue_view.is_locked:+ return Response(+ {"error": "view is locked"},+ status=status.HTTP_400_BAD_REQUEST,+ )++ # Only update the view if owner is updating+ if issue_view.owned_by_id != request.user.id:+ return Response(+ {"error": "Only the owner of the view can update the view"},+ status=status.HTTP_400_BAD_REQUEST,+ )++ serializer = IssueViewSerializer(+ issue_view, data=request.data, partial=True+ )++ if serializer.is_valid():+ serializer.save()+ return Response(serializer.data, status=status.HTTP_200_OK)+ return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)+class IssueViewFavoriteViewSet(BaseViewSet):model = UserFavorite