π₯π₯π₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.
TypeScript boardsbug-trackerdjangodockerganttissue-trackerjirajira-alternativekanbanlinearpostgresqlproduct-managementproject-managementproject-planningpythonreactredistypesciptvitework-management
[WEB-1312] fix: trim file name before uploading (#4661)
M. Palanikannan20acb0dd1795
diff --git a/apiserver/plane/db/models/asset.py b/apiserver/plane/db/models/asset.pyindex 7dd2f2c91c..86e5ceef82 100644--- a/apiserver/plane/db/models/asset.py+++ b/apiserver/plane/db/models/asset.py@@ -12,6 +12,7 @@ from .base import BaseModeldef get_upload_path(instance, filename):+ filename = filename[:50]if instance.workspace_id is not None:return f"{instance.workspace.id}/{uuid4().hex}-{filename}"return f"user-{uuid4().hex}-{filename}"diff --git a/packages/editor/core/src/ui/plugins/image/image-upload-handler.ts b/packages/editor/core/src/ui/plugins/image/image-upload-handler.tsindex 0be22e0dda..eb70218199 100644--- a/packages/editor/core/src/ui/plugins/image/image-upload-handler.ts+++ b/packages/editor/core/src/ui/plugins/image/image-upload-handler.ts@@ -50,9 +50,25 @@ export async function startImageUpload(};try {+ const fileNameTrimmed = trimFileName(file.name);+ const fileWithTrimmedName = new File([file], fileNameTrimmed, { type: file.type });++ const resolvedPos = view.state.doc.resolve(pos ?? 0);+ const nodeBefore = resolvedPos.nodeBefore;++ // if the image is at the start of the line i.e. when nodeBefore is null+ if (nodeBefore === null) {+ if (pos) {+ // so that the image is not inserted at the next line, else incase the+ // image is inserted at any line where there's some content, the+ // position is kept as it is to be inserted at the next line+ pos -= 1;+ }+ }+view.focus();- const src = await uploadAndValidateImage(file, uploadFile);+ const src = await uploadAndValidateImage(fileWithTrimmedName, uploadFile);if (src == null) {throw new Error("Resolved image URL is undefined.");@@ -112,3 +128,14 @@ async function uploadAndValidateImage(file: File, uploadFile: UploadImage): Promthrow error;}}++function trimFileName(fileName: string, maxLength = 100) {+ if (fileName.length > maxLength) {+ const extension = fileName.split(".").pop();+ const nameWithoutExtension = fileName.slice(0, -(extension?.length ?? 0 + 1));+ const allowedNameLength = maxLength - (extension?.length ?? 0) - 1; // -1 for the dot+ return `${nameWithoutExtension.slice(0, allowedNameLength)}.${extension}`;+ }++ return fileName;+}