π₯π₯π₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.
TypeScript boardsbug-trackerdjangodockerganttissue-trackerjirajira-alternativekanbanlinearpostgresqlproduct-managementproject-managementproject-planningpythonreactredistypesciptvitework-management
fix: enforce FILE_SIZE_LIMIT on published Space asset upload (#9242)
sriram veeraghanta25c6843fceed
diff --git a/apps/api/plane/space/views/asset.py b/apps/api/plane/space/views/asset.pyindex 0b0b54ecc6..b3cee8e14f 100644--- a/apps/api/plane/space/views/asset.py+++ b/apps/api/plane/space/views/asset.py@@ -86,10 +86,21 @@ class EntityAssetEndpoint(BaseAPIView):# Get the assetname = sanitize_filename(request.data.get("name")) or "unnamed"type = request.data.get("type", "image/jpeg")- size = int(request.data.get("size", settings.FILE_SIZE_LIMIT))+ try:+ size = int(request.data.get("size", settings.FILE_SIZE_LIMIT))+ except (TypeError, ValueError):+ return Response(+ {"error": "Invalid size.", "status": False},+ status=status.HTTP_400_BAD_REQUEST,+ )entity_type = request.data.get("entity_type", "")entity_identifier = request.data.get("entity_identifier")+ # Clamp the client-provided size to [1, FILE_SIZE_LIMIT] so the signed+ # upload policy cannot exceed the instance limit and always carries a+ # valid content-length-range bound+ size_limit = max(1, min(size, settings.FILE_SIZE_LIMIT))+# Check if the entity type is allowedif entity_type not in FileAsset.EntityTypeContext.values:return Response(@@ -119,9 +130,9 @@ class EntityAssetEndpoint(BaseAPIView):# Create a File Assetasset = FileAsset.objects.create(- attributes={"name": name, "type": type, "size": size},+ attributes={"name": name, "type": type, "size": size_limit},asset=asset_key,- size=size,+ size=size_limit,workspace=deploy_board.workspace,created_by=request.user,entity_type=entity_type,@@ -132,7 +143,7 @@ class EntityAssetEndpoint(BaseAPIView):# Get the presigned URLstorage = S3Storage(request=request)# Generate a presigned URL to share an S3 object- presigned_url = storage.generate_presigned_post(object_name=asset_key, file_type=type, file_size=size)+ presigned_url = storage.generate_presigned_post(object_name=asset_key, file_type=type, file_size=size_limit)# Return the presigned URLreturn Response({