Skip to content

armgit / plane

Public Imported from GitHub
0

πŸ”₯πŸ”₯πŸ”₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.

fix: drag handle scrolling fixed (#5619)

M. Palanikannan2b1da96c3ff3
diff --git a/packages/editor/src/core/extensions/side-menu.tsx b/packages/editor/src/core/extensions/side-menu.tsx
index 616e315e20..5ab6fbdf5b 100644
--- a/packages/editor/src/core/extensions/side-menu.tsx
+++ b/packages/editor/src/core/extensions/side-menu.tsx
@@ -42,7 +42,7 @@ export const SideMenuExtension = (props: Props) => {
ai: aiEnabled,
dragDrop: dragDropEnabled,
},
- scrollThreshold: { up: 300, down: 100 },
+ scrollThreshold: { up: 200, down: 100 },
}),
];
},
diff --git a/packages/editor/src/core/plugins/drag-handle.ts b/packages/editor/src/core/plugins/drag-handle.ts
index ba390180bb..809802b4f9 100644
--- a/packages/editor/src/core/plugins/drag-handle.ts
+++ b/packages/editor/src/core/plugins/drag-handle.ts
@@ -233,14 +233,46 @@ export const DragHandlePlugin = (options: SideMenuPluginProps): SideMenuHandleOp
dragHandleElement.addEventListener("click", (e) => handleClick(e, view));
dragHandleElement.addEventListener("contextmenu", (e) => handleClick(e, view));
+ const isScrollable = (node: HTMLElement | SVGElement) => {
+ if (!(node instanceof HTMLElement || node instanceof SVGElement)) {
+ return false;
+ }
+ const style = getComputedStyle(node);
+ return ["overflow", "overflow-y"].some((propertyName) => {
+ const value = style.getPropertyValue(propertyName);
+ return value === "auto" || value === "scroll";
+ });
+ };
+
+ const getScrollParent = (node: HTMLElement | SVGElement) => {
+ let currentParent = node.parentElement;
+ while (currentParent) {
+ if (isScrollable(currentParent)) {
+ return currentParent;
+ }
+ currentParent = currentParent.parentElement;
+ }
+ return document.scrollingElement || document.documentElement;
+ };
+
+ const maxScrollSpeed = 100;
+
dragHandleElement.addEventListener("drag", (e) => {
hideDragHandle();
- const frameRenderer = document.querySelector(".frame-renderer");
- if (!frameRenderer) return;
- if (e.clientY < options.scrollThreshold.up) {
- frameRenderer.scrollBy({ top: -70, behavior: "smooth" });
- } else if (window.innerHeight - e.clientY < options.scrollThreshold.down) {
- frameRenderer.scrollBy({ top: 70, behavior: "smooth" });
+ const scrollableParent = getScrollParent(dragHandleElement);
+ if (!scrollableParent) return;
+ const scrollThreshold = options.scrollThreshold;
+
+ if (e.clientY < scrollThreshold.up) {
+ const overflow = scrollThreshold.up - e.clientY;
+ const ratio = Math.min(overflow / scrollThreshold.up, 1);
+ const scrollAmount = -maxScrollSpeed * ratio;
+ scrollableParent.scrollBy({ top: scrollAmount });
+ } else if (window.innerHeight - e.clientY < scrollThreshold.down) {
+ const overflow = e.clientY - (window.innerHeight - scrollThreshold.down);
+ const ratio = Math.min(overflow / scrollThreshold.down, 1);
+ const scrollAmount = maxScrollSpeed * ratio;
+ scrollableParent.scrollBy({ top: scrollAmount });
}
});