Skip to content

armgit / plane

Public Imported from GitHub
0

πŸ”₯πŸ”₯πŸ”₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.

chore: create unique constraints for webhook (#6257)

Bavisetti Narayan2d9464e841f4
diff --git a/apiserver/plane/app/serializers/webhook.py b/apiserver/plane/app/serializers/webhook.py
index fa4019f7ae..1036b700c6 100644
--- a/apiserver/plane/app/serializers/webhook.py
+++ b/apiserver/plane/app/serializers/webhook.py
@@ -116,7 +116,7 @@ class WebhookSerializer(DynamicBaseSerializer):
class Meta:
model = Webhook
fields = "__all__"
- read_only_fields = ["workspace", "secret_key"]
+ read_only_fields = ["workspace", "secret_key", "deleted_at"]
class WebhookLogSerializer(DynamicBaseSerializer):
diff --git a/apiserver/plane/db/migrations/0088_sticky_sort_order_workspaceuserlink.py b/apiserver/plane/db/migrations/0088_sticky_sort_order_workspaceuserlink.py
index 0efdf41f28..1b31221577 100644
--- a/apiserver/plane/db/migrations/0088_sticky_sort_order_workspaceuserlink.py
+++ b/apiserver/plane/db/migrations/0088_sticky_sort_order_workspaceuserlink.py
@@ -109,4 +109,16 @@ class Migration(migrations.Migration):
name="entity_name",
field=models.CharField(max_length=30, verbose_name="Transaction Type"),
),
+ migrations.AlterUniqueTogether(
+ name="webhook",
+ unique_together={("workspace", "url", "deleted_at")},
+ ),
+ migrations.AddConstraint(
+ model_name="webhook",
+ constraint=models.UniqueConstraint(
+ condition=models.Q(("deleted_at__isnull", True)),
+ fields=("workspace", "url"),
+ name="webhook_url_unique_url_when_deleted_at_null",
+ ),
+ ),
]
diff --git a/apiserver/plane/db/models/webhook.py b/apiserver/plane/db/models/webhook.py
index ec8fcda3af..dc04e04199 100644
--- a/apiserver/plane/db/models/webhook.py
+++ b/apiserver/plane/db/models/webhook.py
@@ -47,11 +47,18 @@ class Webhook(BaseModel):
return f"{self.workspace.slug} {self.url}"
class Meta:
- unique_together = ["workspace", "url"]
+ unique_together = ["workspace", "url", "deleted_at"]
verbose_name = "Webhook"
verbose_name_plural = "Webhooks"
db_table = "webhooks"
ordering = ("-created_at",)
+ constraints = [
+ models.UniqueConstraint(
+ fields=["workspace", "url"],
+ condition=models.Q(deleted_at__isnull=True),
+ name="webhook_url_unique_url_when_deleted_at_null",
+ )
+ ]
class WebhookLog(BaseModel):