π₯π₯π₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.
TypeScript boardsbug-trackerdjangodockerganttissue-trackerjirajira-alternativekanbanlinearpostgresqlproduct-managementproject-managementproject-planningpythonreactredistypesciptvitework-management
chore: remove unused right sidebar component and clean up workspace member settings (#8477)
Prateek Shourya3d5e427894d3
diff --git a/apps/web/app/(all)/[workspaceSlug]/(settings)/settings/(workspace)/layout.tsx b/apps/web/app/(all)/[workspaceSlug]/(settings)/settings/(workspace)/layout.tsxindex 783f7a0dd0..9eb72a7829 100644--- a/apps/web/app/(all)/[workspaceSlug]/(settings)/settings/(workspace)/layout.tsx+++ b/apps/web/app/(all)/[workspaceSlug]/(settings)/settings/(workspace)/layout.tsx@@ -8,8 +8,6 @@ import { SettingsMobileNav } from "@/components/settings/mobile";// plane importsimport { WORKSPACE_SETTINGS_ACCESS } from "@plane/constants";import type { EUserWorkspaceRoles } from "@plane/types";-// plane web components-import { WorkspaceSettingsRightSidebar } from "@/plane-web/components/workspace/right-sidebar";// hooksimport { useUserPermissions } from "@/hooks/store/user";// local components@@ -48,7 +46,6 @@ const WorkspaceSettingLayout = observer(function WorkspaceSettingLayout({ params<div className="w-full h-full overflow-y-scroll md:pt-page-y"><Outlet /></div>- <WorkspaceSettingsRightSidebar workspaceSlug={workspaceSlug} /></div>)}</div>diff --git a/apps/web/app/(all)/[workspaceSlug]/(settings)/settings/(workspace)/members/page.tsx b/apps/web/app/(all)/[workspaceSlug]/(settings)/settings/(workspace)/members/page.tsxindex d096a17fff..7f8e32fec1 100644--- a/apps/web/app/(all)/[workspaceSlug]/(settings)/settings/(workspace)/members/page.tsx+++ b/apps/web/app/(all)/[workspaceSlug]/(settings)/settings/(workspace)/members/page.tsx@@ -1,12 +1,7 @@import { useState } from "react";import { observer } from "mobx-react";// types-import {- EUserPermissions,- EUserPermissionsLevel,- MEMBER_TRACKER_ELEMENTS,- MEMBER_TRACKER_EVENTS,-} from "@plane/constants";+import { EUserPermissions, EUserPermissionsLevel } from "@plane/constants";import { useTranslation } from "@plane/i18n";import { Button } from "@plane/propel/button";import { SearchIcon } from "@plane/propel/icons";@@ -40,7 +35,7 @@ const WorkspaceMembersSettingsPage = observer(function WorkspaceMembersSettingsPconst {workspace: { workspaceMemberIds, inviteMembersToWorkspace, filtersStore },} = useMember();- const { currentWorkspace, mutateWorkspaceMembersActivity } = useWorkspace();+ const { currentWorkspace } = useWorkspace();const { t } = useTranslation();// derived values@@ -53,7 +48,6 @@ const WorkspaceMembersSettingsPage = observer(function WorkspaceMembersSettingsPconst handleWorkspaceInvite = async (data: IWorkspaceBulkInviteFormData) => {try {await inviteMembersToWorkspace(workspaceSlug, data);- void mutateWorkspaceMembersActivity(workspaceSlug);setInviteModal(false);@@ -137,12 +131,7 @@ const WorkspaceMembersSettingsPage = observer(function WorkspaceMembersSettingsP/><MembersActivityButton workspaceSlug={workspaceSlug} />{canPerformWorkspaceAdminActions && (- <Button- variant="primary"- size="lg"- onClick={() => setInviteModal(true)}- data-ph-element={MEMBER_TRACKER_ELEMENTS.HEADER_ADD_BUTTON}- >+ <Button variant="primary" size="lg" onClick={() => setInviteModal(true)}>{t("workspace_settings.settings.members.add_member")}</Button>)}diff --git a/apps/web/ce/components/workspace/right-sidebar/index.ts b/apps/web/ce/components/workspace/right-sidebar/index.tsdeleted file mode 100644index 1efe34c51e..0000000000--- a/apps/web/ce/components/workspace/right-sidebar/index.ts+++ /dev/null@@ -1 +0,0 @@-export * from "./root";diff --git a/apps/web/ce/components/workspace/right-sidebar/root.tsx b/apps/web/ce/components/workspace/right-sidebar/root.tsxdeleted file mode 100644index c98bb682a5..0000000000--- a/apps/web/ce/components/workspace/right-sidebar/root.tsx+++ /dev/null@@ -1,10 +0,0 @@-import { observer } from "mobx-react";--type TWorkspaceSettingsRightSidebarProps = { workspaceSlug: string };--export const WorkspaceSettingsRightSidebar = observer(function WorkspaceSettingsRightSidebar(- // eslint-disable-next-line @typescript-eslint/no-unused-vars- props: TWorkspaceSettingsRightSidebarProps-) {- return <></>;-});diff --git a/apps/web/core/components/workspace/settings/invitations-list-item.tsx b/apps/web/core/components/workspace/settings/invitations-list-item.tsxindex 20ea3d7a9c..12b4cc821f 100644--- a/apps/web/core/components/workspace/settings/invitations-list-item.tsx+++ b/apps/web/core/components/workspace/settings/invitations-list-item.tsx@@ -14,7 +14,6 @@ import { ConfirmWorkspaceMemberRemove } from "@/components/workspace/confirm-wor// hooksimport { useMember } from "@/hooks/store/use-member";import { useUserPermissions } from "@/hooks/store/user";-import { useWorkspace } from "@/hooks/store/use-workspace";type Props = {invitationId: string;@@ -30,7 +29,6 @@ export const WorkspaceInvitationsListItem = observer(function WorkspaceInvitatioconst { t } = useTranslation();// store hooksconst { allowPermissions, workspaceInfoBySlug } = useUserPermissions();- const { mutateWorkspaceMembersActivity } = useWorkspace();const {workspace: { updateMemberInvitation, deleteMemberInvitation, getWorkspaceInvitationDetails },} = useMember();@@ -59,7 +57,6 @@ export const WorkspaceInvitationsListItem = observer(function WorkspaceInvitatiotitle: "Success!",message: "Invitation removed successfully.",});- void mutateWorkspaceMembersActivity(workspaceSlug);} catch (err: unknown) {const error = err as { error?: string };setToast({diff --git a/apps/web/core/components/workspace/settings/member-columns.tsx b/apps/web/core/components/workspace/settings/member-columns.tsxindex b98438b1d4..4167a79397 100644--- a/apps/web/core/components/workspace/settings/member-columns.tsx+++ b/apps/web/core/components/workspace/settings/member-columns.tsx@@ -16,8 +16,6 @@ import { getFileURL } from "@plane/utils";// hooksimport { useMember } from "@/hooks/store/use-member";import { useUser, useUserPermissions } from "@/hooks/store/user";-import { useWorkspace } from "@/hooks/store/use-workspace";-// plane web constantsexport interface RowData {member: IWorkspaceMember;@@ -121,7 +119,6 @@ export const AccountTypeColumn = observer(function AccountTypeColumn(props: Accoconst {workspace: { updateMember },} = useMember();- const { mutateWorkspaceMembersActivity } = useWorkspace();const { data: currentUser } = useUser();// derived values@@ -156,7 +153,6 @@ export const AccountTypeColumn = observer(function AccountTypeColumn(props: Accoawait updateMember(workspaceSlug.toString(), rowData.member.id, {role: value as unknown as EUserPermissions,});- void mutateWorkspaceMembersActivity(workspaceSlug);} catch (err: unknown) {const error = err as { error?: string | string[] };const errorString = Array.isArray(error?.error) ? error.error[0] : error?.error;diff --git a/apps/web/core/components/workspace/settings/members-list-item.tsx b/apps/web/core/components/workspace/settings/members-list-item.tsxindex 4f0b20dc5d..9499110ee5 100644--- a/apps/web/core/components/workspace/settings/members-list-item.tsx+++ b/apps/web/core/components/workspace/settings/members-list-item.tsx@@ -32,7 +32,7 @@ export const WorkspaceMembersListItem = observer(function WorkspaceMembersListItworkspace: { removeMemberFromWorkspace },} = useMember();const { leaveWorkspace } = useUserPermissions();- const { getWorkspaceRedirectionUrl, mutateWorkspaceMembersActivity } = useWorkspace();+ const { getWorkspaceRedirectionUrl } = useWorkspace();const { fetchCurrentUserSettings } = useUserSettings();const { t } = useTranslation();// derived values@@ -59,7 +59,6 @@ export const WorkspaceMembersListItem = observer(function WorkspaceMembersListIttry {await removeMemberFromWorkspace(workspaceSlug.toString(), memberId);- void mutateWorkspaceMembersActivity(workspaceSlug);} catch (err: unknown) {const error = err as { error?: string };setToast({diff --git a/apps/web/core/store/member/workspace/workspace-member.store.ts b/apps/web/core/store/member/workspace/workspace-member.store.tsindex edf9d2a297..ad0df64fcf 100644--- a/apps/web/core/store/member/workspace/workspace-member.store.ts+++ b/apps/web/core/store/member/workspace/workspace-member.store.ts@@ -11,10 +11,10 @@ import { WorkspaceService } from "@/plane-web/services";import type { IRouterStore } from "@/store/router.store";import type { IUserStore } from "@/store/user";// store-import type { CoreRootStore } from "../../root.store";import type { IMemberRootStore } from "../index.ts";import type { IWorkspaceMemberFiltersStore } from "./workspace-member-filters.store";import { WorkspaceMemberFiltersStore } from "./workspace-member-filters.store";+import type { RootStore } from "@/plane-web/store/root.store";export interface IWorkspaceMembership {id: string;@@ -72,7 +72,7 @@ export class WorkspaceMemberStore implements IWorkspaceMemberStore {// servicesworkspaceService;- constructor(_memberRoot: IMemberRootStore, _rootStore: CoreRootStore) {+ constructor(_memberRoot: IMemberRootStore, _rootStore: RootStore) {makeObservable(this, {// observablesworkspaceMemberMap: observable,