Skip to content

armgit / plane

Public Imported from GitHub
0

πŸ”₯πŸ”₯πŸ”₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.

[WEB-2631] chore: changed the cascading logic for soft delete (#5829)

Bavisetti Narayan3d7d3c8af112
diff --git a/apiserver/plane/app/views/workspace/draft.py b/apiserver/plane/app/views/workspace/draft.py
index d81dd5a503..cec9296f79 100644
--- a/apiserver/plane/app/views/workspace/draft.py
+++ b/apiserver/plane/app/views/workspace/draft.py
@@ -279,7 +279,7 @@ class WorkspaceDraftIssueViewSet(BaseViewSet):
{
"updated_cycle_issues": None,
"created_cycle_issues": serializers.serialize(
- "json", created_records
+ "json", [created_records]
),
}
),
diff --git a/apiserver/plane/bgtasks/deletion_task.py b/apiserver/plane/bgtasks/deletion_task.py
index 35d72812da..b0b2a6eb26 100644
--- a/apiserver/plane/bgtasks/deletion_task.py
+++ b/apiserver/plane/bgtasks/deletion_task.py
@@ -21,8 +21,8 @@ def soft_delete_related_objects(
try:
# Check if the field has CASCADE on delete
if (
- hasattr(field.remote_field, "on_delete")
- and field.remote_field.on_delete == models.CASCADE
+ not hasattr(field.remote_field, "on_delete")
+ or field.remote_field.on_delete == models.CASCADE
):
if field.one_to_many:
related_objects = getattr(instance, field.name).all()
diff --git a/apiserver/plane/db/models/project.py b/apiserver/plane/db/models/project.py
index f970b121c8..a44c84bc48 100644
--- a/apiserver/plane/db/models/project.py
+++ b/apiserver/plane/db/models/project.py
@@ -181,7 +181,7 @@ class ProjectBaseModel(BaseModel):
Project, on_delete=models.CASCADE, related_name="project_%(class)s"
)
workspace = models.ForeignKey(
- "db.Workspace", models.CASCADE, related_name="workspace_%(class)s"
+ "db.Workspace", on_delete=models.CASCADE, related_name="workspace_%(class)s"
)
class Meta: