Skip to content

armgit / plane

Public Imported from GitHub
0

πŸ”₯πŸ”₯πŸ”₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.

[WEB-5068] fix: CustomMenu closeOnSelect behavior #7897

Anmol Singh Bhatia3e82984f92d8
diff --git a/apps/web/core/components/cycles/quick-actions.tsx b/apps/web/core/components/cycles/quick-actions.tsx
index 778e781154..6f3234e028 100644
--- a/apps/web/core/components/cycles/quick-actions.tsx
+++ b/apps/web/core/components/cycles/quick-actions.tsx
@@ -223,9 +223,7 @@ export const CycleQuickActions: React.FC<Props> = observer((props) => {
return (
<CustomMenu.MenuItem
key={item.key}
- onClick={(e) => {
- e.preventDefault();
- e.stopPropagation();
+ onClick={() => {
captureClick({
elementName: CYCLE_TRACKER_ELEMENTS.QUICK_ACTIONS,
});
diff --git a/apps/web/core/components/issues/attachment/attachment-list-item.tsx b/apps/web/core/components/issues/attachment/attachment-list-item.tsx
index fc071750a6..d5c24c25f8 100644
--- a/apps/web/core/components/issues/attachment/attachment-list-item.tsx
+++ b/apps/web/core/components/issues/attachment/attachment-list-item.tsx
@@ -83,9 +83,7 @@ export const IssueAttachmentsListItem: FC<TIssueAttachmentsListItem> = observer(
<CustomMenu ellipsis closeOnSelect placement="bottom-end" disabled={disabled}>
<CustomMenu.MenuItem
- onClick={(e) => {
- e.preventDefault();
- e.stopPropagation();
+ onClick={() => {
toggleDeleteAttachmentModal(attachmentId);
}}
>
diff --git a/apps/web/core/components/issues/issue-detail-widgets/relations/quick-action-button.tsx b/apps/web/core/components/issues/issue-detail-widgets/relations/quick-action-button.tsx
index 18a3d1cdcc..0390d6eaa9 100644
--- a/apps/web/core/components/issues/issue-detail-widgets/relations/quick-action-button.tsx
+++ b/apps/web/core/components/issues/issue-detail-widgets/relations/quick-action-button.tsx
@@ -50,9 +50,7 @@ export const RelationActionButton: FC<Props> = observer((props) => {
return (
<CustomMenu.MenuItem
key={index}
- onClick={(e) => {
- e.preventDefault();
- e.stopPropagation();
+ onClick={() => {
handleOnClick(item.key as TIssueRelationTypes);
}}
>
diff --git a/apps/web/core/components/issues/issue-detail-widgets/sub-issues/issues-list/list-item.tsx b/apps/web/core/components/issues/issue-detail-widgets/sub-issues/issues-list/list-item.tsx
index e9d93abac5..6ffda87dbb 100644
--- a/apps/web/core/components/issues/issue-detail-widgets/sub-issues/issues-list/list-item.tsx
+++ b/apps/web/core/components/issues/issue-detail-widgets/sub-issues/issues-list/list-item.tsx
@@ -185,9 +185,7 @@ export const SubIssuesListItem: React.FC<Props> = observer((props) => {
<CustomMenu placement="bottom-end" ellipsis>
{canEdit && (
<CustomMenu.MenuItem
- onClick={(e) => {
- e.preventDefault();
- e.stopPropagation();
+ onClick={() => {
handleIssueCrudState("update", parentIssueId, { ...issue });
toggleCreateIssueModal(true);
}}
@@ -200,9 +198,7 @@ export const SubIssuesListItem: React.FC<Props> = observer((props) => {
)}
<CustomMenu.MenuItem
- onClick={(e) => {
- e.stopPropagation();
- e.preventDefault();
+ onClick={() => {
subIssueOperations.copyLink(workItemLink);
}}
>
@@ -214,9 +210,7 @@ export const SubIssuesListItem: React.FC<Props> = observer((props) => {
{canEdit && (
<CustomMenu.MenuItem
- onClick={(e) => {
- e.stopPropagation();
- e.preventDefault();
+ onClick={() => {
if (issue.project_id)
subIssueOperations.removeSubIssue(workspaceSlug, issue.project_id, parentIssueId, issue.id);
}}
@@ -232,9 +226,7 @@ export const SubIssuesListItem: React.FC<Props> = observer((props) => {
{canEdit && (
<CustomMenu.MenuItem
- onClick={(e) => {
- e.stopPropagation();
- e.preventDefault();
+ onClick={() => {
handleIssueCrudState("delete", parentIssueId, issue);
toggleDeleteIssueModal(issue.id);
}}
diff --git a/apps/web/core/components/issues/issue-detail-widgets/sub-issues/quick-action-button.tsx b/apps/web/core/components/issues/issue-detail-widgets/sub-issues/quick-action-button.tsx
index 4547524453..4bc1d8c5b3 100644
--- a/apps/web/core/components/issues/issue-detail-widgets/sub-issues/quick-action-button.tsx
+++ b/apps/web/core/components/issues/issue-detail-widgets/sub-issues/quick-action-button.tsx
@@ -86,9 +86,7 @@ export const SubIssuesActionButton: FC<Props> = observer((props) => {
{optionItems.map((item, index) => (
<CustomMenu.MenuItem
key={index}
- onClick={(e) => {
- e.preventDefault();
- e.stopPropagation();
+ onClick={() => {
item.onClick();
}}
>
diff --git a/apps/web/core/components/issues/issue-detail/links/link-item.tsx b/apps/web/core/components/issues/issue-detail/links/link-item.tsx
index 977333baab..d9e8d43f38 100644
--- a/apps/web/core/components/issues/issue-detail/links/link-item.tsx
+++ b/apps/web/core/components/issues/issue-detail/links/link-item.tsx
@@ -95,9 +95,7 @@ export const IssueLinkItem: FC<TIssueLinkItem> = observer((props) => {
>
<CustomMenu.MenuItem
className="flex items-center gap-2"
- onClick={(e) => {
- e.preventDefault();
- e.stopPropagation();
+ onClick={() => {
toggleIssueLinkModal(true);
}}
>
@@ -106,9 +104,7 @@ export const IssueLinkItem: FC<TIssueLinkItem> = observer((props) => {
</CustomMenu.MenuItem>
<CustomMenu.MenuItem
className="flex items-center gap-2"
- onClick={(e) => {
- e.preventDefault();
- e.stopPropagation();
+ onClick={() => {
linkOperations.remove(linkDetail.id);
}}
>
diff --git a/apps/web/core/components/issues/issue-layouts/quick-action-dropdowns/all-issue.tsx b/apps/web/core/components/issues/issue-layouts/quick-action-dropdowns/all-issue.tsx
index ce522e14f9..770a69d2db 100644
--- a/apps/web/core/components/issues/issue-layouts/quick-action-dropdowns/all-issue.tsx
+++ b/apps/web/core/components/issues/issue-layouts/quick-action-dropdowns/all-issue.tsx
@@ -175,9 +175,7 @@ export const AllIssueQuickActions: React.FC<IQuickActionProps> = observer((props
{item.nestedMenuItems.map((nestedItem) => (
<CustomMenu.MenuItem
key={nestedItem.key}
- onClick={(e) => {
- e.preventDefault();
- e.stopPropagation();
+ onClick={() => {
captureClick({ elementName: WORK_ITEM_TRACKER_ELEMENTS.QUICK_ACTIONS.GLOBAL_VIEW });
nestedItem.action();
}}
@@ -213,9 +211,7 @@ export const AllIssueQuickActions: React.FC<IQuickActionProps> = observer((props
return (
<CustomMenu.MenuItem
key={item.key}
- onClick={(e) => {
- e.preventDefault();
- e.stopPropagation();
+ onClick={() => {
captureClick({ elementName: WORK_ITEM_TRACKER_ELEMENTS.QUICK_ACTIONS.GLOBAL_VIEW });
item.action();
}}
diff --git a/apps/web/core/components/issues/issue-layouts/quick-action-dropdowns/archived-issue.tsx b/apps/web/core/components/issues/issue-layouts/quick-action-dropdowns/archived-issue.tsx
index c8fb319799..15169358d2 100644
--- a/apps/web/core/components/issues/issue-layouts/quick-action-dropdowns/archived-issue.tsx
+++ b/apps/web/core/components/issues/issue-layouts/quick-action-dropdowns/archived-issue.tsx
@@ -94,9 +94,7 @@ export const ArchivedIssueQuickActions: React.FC<IQuickActionProps> = observer((
return (
<CustomMenu.MenuItem
key={item.key}
- onClick={(e) => {
- e.preventDefault();
- e.stopPropagation();
+ onClick={() => {
item.action();
captureClick({ elementName: WORK_ITEM_TRACKER_ELEMENTS.QUICK_ACTIONS.ARCHIVED });
}}
diff --git a/apps/web/core/components/issues/issue-layouts/quick-action-dropdowns/cycle-issue.tsx b/apps/web/core/components/issues/issue-layouts/quick-action-dropdowns/cycle-issue.tsx
index 6c0399e011..54536f343f 100644
--- a/apps/web/core/components/issues/issue-layouts/quick-action-dropdowns/cycle-issue.tsx
+++ b/apps/web/core/components/issues/issue-layouts/quick-action-dropdowns/cycle-issue.tsx
@@ -192,9 +192,7 @@ export const CycleIssueQuickActions: React.FC<IQuickActionProps> = observer((pro
{item.nestedMenuItems.map((nestedItem) => (
<CustomMenu.MenuItem
key={nestedItem.key}
- onClick={(e) => {
- e.preventDefault();
- e.stopPropagation();
+ onClick={() => {
captureClick({ elementName: WORK_ITEM_TRACKER_ELEMENTS.QUICK_ACTIONS.CYCLE });
nestedItem.action();
}}
@@ -230,9 +228,7 @@ export const CycleIssueQuickActions: React.FC<IQuickActionProps> = observer((pro
return (
<CustomMenu.MenuItem
key={item.key}
- onClick={(e) => {
- e.preventDefault();
- e.stopPropagation();
+ onClick={() => {
captureClick({ elementName: WORK_ITEM_TRACKER_ELEMENTS.QUICK_ACTIONS.CYCLE });
item.action();
}}
diff --git a/apps/web/core/components/issues/issue-layouts/quick-action-dropdowns/issue-detail.tsx b/apps/web/core/components/issues/issue-layouts/quick-action-dropdowns/issue-detail.tsx
index 29abea656a..084db5a22c 100644
--- a/apps/web/core/components/issues/issue-layouts/quick-action-dropdowns/issue-detail.tsx
+++ b/apps/web/core/components/issues/issue-layouts/quick-action-dropdowns/issue-detail.tsx
@@ -276,9 +276,7 @@ export const WorkItemDetailQuickActions: React.FC<TWorkItemDetailQuickActionProp
{item.nestedMenuItems.map((nestedItem) => (
<CustomMenu.MenuItem
key={nestedItem.key}
- onClick={(e) => {
- e.preventDefault();
- e.stopPropagation();
+ onClick={() => {
captureClick({ elementName: WORK_ITEM_TRACKER_ELEMENTS.QUICK_ACTIONS.PROJECT_VIEW });
nestedItem.action();
}}
@@ -314,9 +312,7 @@ export const WorkItemDetailQuickActions: React.FC<TWorkItemDetailQuickActionProp
return (
<CustomMenu.MenuItem
key={item.key}
- onClick={(e) => {
- e.preventDefault();
- e.stopPropagation();
+ onClick={() => {
captureClick({ elementName: WORK_ITEM_TRACKER_ELEMENTS.QUICK_ACTIONS.PROJECT_VIEW });
item.action();
}}
diff --git a/apps/web/core/components/issues/issue-layouts/quick-action-dropdowns/module-issue.tsx b/apps/web/core/components/issues/issue-layouts/quick-action-dropdowns/module-issue.tsx
index e147d448ac..1bc8ccbab3 100644
--- a/apps/web/core/components/issues/issue-layouts/quick-action-dropdowns/module-issue.tsx
+++ b/apps/web/core/components/issues/issue-layouts/quick-action-dropdowns/module-issue.tsx
@@ -191,9 +191,7 @@ export const ModuleIssueQuickActions: React.FC<IQuickActionProps> = observer((pr
{item.nestedMenuItems.map((nestedItem) => (
<CustomMenu.MenuItem
key={nestedItem.key}
- onClick={(e) => {
- e.preventDefault();
- e.stopPropagation();
+ onClick={() => {
captureClick({ elementName: WORK_ITEM_TRACKER_ELEMENTS.QUICK_ACTIONS.MODULE });
nestedItem.action();
}}
@@ -229,9 +227,7 @@ export const ModuleIssueQuickActions: React.FC<IQuickActionProps> = observer((pr
return (
<CustomMenu.MenuItem
key={item.key}
- onClick={(e) => {
- e.preventDefault();
- e.stopPropagation();
+ onClick={() => {
captureClick({ elementName: WORK_ITEM_TRACKER_ELEMENTS.QUICK_ACTIONS.MODULE });
item.action();
}}
diff --git a/apps/web/core/components/issues/issue-layouts/quick-action-dropdowns/project-issue.tsx b/apps/web/core/components/issues/issue-layouts/quick-action-dropdowns/project-issue.tsx
index 83c58c8812..5b70c05cc7 100644
--- a/apps/web/core/components/issues/issue-layouts/quick-action-dropdowns/project-issue.tsx
+++ b/apps/web/core/components/issues/issue-layouts/quick-action-dropdowns/project-issue.tsx
@@ -192,9 +192,7 @@ export const ProjectIssueQuickActions: React.FC<IQuickActionProps> = observer((p
{item.nestedMenuItems.map((nestedItem) => (
<CustomMenu.MenuItem
key={nestedItem.key}
- onClick={(e) => {
- e.preventDefault();
- e.stopPropagation();
+ onClick={() => {
captureClick({ elementName: WORK_ITEM_TRACKER_ELEMENTS.QUICK_ACTIONS.PROJECT_VIEW });
nestedItem.action();
}}
@@ -230,9 +228,7 @@ export const ProjectIssueQuickActions: React.FC<IQuickActionProps> = observer((p
return (
<CustomMenu.MenuItem
key={item.key}
- onClick={(e) => {
- e.preventDefault();
- e.stopPropagation();
+ onClick={() => {
captureClick({ elementName: WORK_ITEM_TRACKER_ELEMENTS.QUICK_ACTIONS.PROJECT_VIEW });
item.action();
}}
diff --git a/apps/web/core/components/issues/workspace-draft/quick-action.tsx b/apps/web/core/components/issues/workspace-draft/quick-action.tsx
index 2a52d83d6d..41fc1e5e28 100644
--- a/apps/web/core/components/issues/workspace-draft/quick-action.tsx
+++ b/apps/web/core/components/issues/workspace-draft/quick-action.tsx
@@ -31,9 +31,7 @@ export const WorkspaceDraftIssueQuickActions: React.FC<Props> = observer((props)
{MENU_ITEMS.map((item) => (
<CustomMenu.MenuItem
key={item.key}
- onClick={(e) => {
- e.preventDefault();
- e.stopPropagation();
+ onClick={() => {
item.action();
}}
className={cn(
diff --git a/apps/web/core/components/modules/quick-actions.tsx b/apps/web/core/components/modules/quick-actions.tsx
index 2b79316ed1..d36f2e3c1b 100644
--- a/apps/web/core/components/modules/quick-actions.tsx
+++ b/apps/web/core/components/modules/quick-actions.tsx
@@ -197,9 +197,7 @@ export const ModuleQuickActions: React.FC<Props> = observer((props) => {
return (
<CustomMenu.MenuItem
key={item.key}
- onClick={(e) => {
- e.preventDefault();
- e.stopPropagation();
+ onClick={() => {
captureClick({
elementName: MODULE_TRACKER_ELEMENTS.QUICK_ACTIONS,
});
diff --git a/apps/web/core/components/pages/dropdowns/actions.tsx b/apps/web/core/components/pages/dropdowns/actions.tsx
index 5ad00a6c90..67642c57c3 100644
--- a/apps/web/core/components/pages/dropdowns/actions.tsx
+++ b/apps/web/core/components/pages/dropdowns/actions.tsx
@@ -217,9 +217,7 @@ export const PageActions: React.FC<Props> = observer((props) => {
return (
<CustomMenu.MenuItem
key={item.key}
- onClick={(e) => {
- e.preventDefault();
- e.stopPropagation();
+ onClick={() => {
item.action?.();
}}
className={cn("flex items-center gap-2", item.className)}
diff --git a/apps/web/core/components/views/quick-actions.tsx b/apps/web/core/components/views/quick-actions.tsx
index 9c5fbefcba..b62154cd29 100644
--- a/apps/web/core/components/views/quick-actions.tsx
+++ b/apps/web/core/components/views/quick-actions.tsx
@@ -95,9 +95,7 @@ export const ViewQuickActions: React.FC<Props> = observer((props) => {
return (
<CustomMenu.MenuItem
key={item.key}
- onClick={(e) => {
- e.preventDefault();
- e.stopPropagation();
+ onClick={() => {
captureClick({ elementName: PROJECT_VIEW_TRACKER_ELEMENTS.QUICK_ACTIONS });
item.action();
}}
diff --git a/apps/web/core/components/workspace/settings/invitations-list-item.tsx b/apps/web/core/components/workspace/settings/invitations-list-item.tsx
index da3f2f0b52..f67ec2eb27 100644
--- a/apps/web/core/components/workspace/settings/invitations-list-item.tsx
+++ b/apps/web/core/components/workspace/settings/invitations-list-item.tsx
@@ -185,9 +185,7 @@ export const WorkspaceInvitationsListItem: FC<Props> = observer((props) => {
return (
<CustomMenu.MenuItem
key={item.key}
- onClick={(e) => {
- e.preventDefault();
- e.stopPropagation();
+ onClick={() => {
item.action();
}}
className={cn(
diff --git a/apps/web/core/components/workspace/views/default-view-quick-action.tsx b/apps/web/core/components/workspace/views/default-view-quick-action.tsx
index 869c2d0965..8cbd4c528f 100644
--- a/apps/web/core/components/workspace/views/default-view-quick-action.tsx
+++ b/apps/web/core/components/workspace/views/default-view-quick-action.tsx
@@ -61,9 +61,7 @@ export const DefaultWorkspaceViewQuickActions: React.FC<Props> = observer((props
return (
<CustomMenu.MenuItem
key={item.key}
- onClick={(e) => {
- e.preventDefault();
- e.stopPropagation();
+ onClick={() => {
item.action();
}}
className={cn(
diff --git a/apps/web/core/components/workspace/views/quick-action.tsx b/apps/web/core/components/workspace/views/quick-action.tsx
index e7677cecbc..28a80983fc 100644
--- a/apps/web/core/components/workspace/views/quick-action.tsx
+++ b/apps/web/core/components/workspace/views/quick-action.tsx
@@ -71,9 +71,7 @@ export const WorkspaceViewQuickActions: React.FC<Props> = observer((props) => {
return (
<CustomMenu.MenuItem
key={item.key}
- onClick={(e) => {
- e.preventDefault();
- e.stopPropagation();
+ onClick={() => {
captureClick({
elementName: GLOBAL_VIEW_TRACKER_ELEMENTS.QUICK_ACTIONS,
});
diff --git a/apps/web/core/components/workspace/views/view-list-item.tsx b/apps/web/core/components/workspace/views/view-list-item.tsx
index d1d794a846..1f1d11c6cc 100644
--- a/apps/web/core/components/workspace/views/view-list-item.tsx
+++ b/apps/web/core/components/workspace/views/view-list-item.tsx
@@ -51,9 +51,7 @@ export const GlobalViewListItem: React.FC<Props> = observer((props) => {
<div className="flex items-center gap-4">
<CustomMenu ellipsis>
<CustomMenu.MenuItem
- onClick={(e) => {
- e.preventDefault();
- e.stopPropagation();
+ onClick={() => {
captureClick({
elementName: GLOBAL_VIEW_TRACKER_ELEMENTS.LIST_ITEM,
});
@@ -66,9 +64,7 @@ export const GlobalViewListItem: React.FC<Props> = observer((props) => {
</span>
</CustomMenu.MenuItem>
<CustomMenu.MenuItem
- onClick={(e) => {
- e.preventDefault();
- e.stopPropagation();
+ onClick={() => {
captureClick({
elementName: GLOBAL_VIEW_TRACKER_ELEMENTS.LIST_ITEM,
});