Skip to content

armgit / plane

Public Imported from GitHub
0

πŸ”₯πŸ”₯πŸ”₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.

chore: update useCallback dependencies (#4341)

Aaryan Khandelwal45c9dfb3cf09
diff --git a/web/components/issues/attachment/attachment-upload.tsx b/web/components/issues/attachment/attachment-upload.tsx
index 46b697691c..dcb52ec13c 100644
--- a/web/components/issues/attachment/attachment-upload.tsx
+++ b/web/components/issues/attachment/attachment-upload.tsx
@@ -1,11 +1,11 @@
import { useCallback, useState } from "react";
import { observer } from "mobx-react-lite";
import { useDropzone } from "react-dropzone";
-// hooks
// constants
import { MAX_FILE_SIZE } from "@/constants/common";
// helpers
import { generateFileName } from "@/helpers/attachment.helper";
+// hooks
import { useApplication } from "@/hooks/store";
// types
import { TAttachmentOperations } from "./root";
@@ -27,24 +27,28 @@ export const IssueAttachmentUpload: React.FC<Props> = observer((props) => {
// states
const [isLoading, setIsLoading] = useState(false);
- const onDrop = useCallback((acceptedFiles: File[]) => {
- const currentFile: File = acceptedFiles[0];
- if (!currentFile || !workspaceSlug) return;
+ const onDrop = useCallback(
+ (acceptedFiles: File[]) => {
+ const currentFile: File = acceptedFiles[0];
+ if (!currentFile || !workspaceSlug) return;
- const uploadedFile: File = new File([currentFile], generateFileName(currentFile.name), { type: currentFile.type });
- const formData = new FormData();
- formData.append("asset", uploadedFile);
- formData.append(
- "attributes",
- JSON.stringify({
- name: uploadedFile.name,
- size: uploadedFile.size,
- })
- );
- setIsLoading(true);
- handleAttachmentOperations.create(formData).finally(() => setIsLoading(false));
- // eslint-disable-next-line react-hooks/exhaustive-deps
- }, []);
+ const uploadedFile: File = new File([currentFile], generateFileName(currentFile.name), {
+ type: currentFile.type,
+ });
+ const formData = new FormData();
+ formData.append("asset", uploadedFile);
+ formData.append(
+ "attributes",
+ JSON.stringify({
+ name: uploadedFile.name,
+ size: uploadedFile.size,
+ })
+ );
+ setIsLoading(true);
+ handleAttachmentOperations.create(formData).finally(() => setIsLoading(false));
+ },
+ [handleAttachmentOperations, workspaceSlug]
+ );
const { getRootProps, getInputProps, isDragActive, isDragReject, fileRejections } = useDropzone({
onDrop,
diff --git a/web/components/issues/attachment/root.tsx b/web/components/issues/attachment/root.tsx
index c915ebce94..b9dd5e290f 100644
--- a/web/components/issues/attachment/root.tsx
+++ b/web/components/issues/attachment/root.tsx
@@ -95,7 +95,7 @@ export const IssueAttachmentRoot: FC<TIssueAttachmentRoot> = (props) => {
}
},
}),
- [workspaceSlug, projectId, issueId, createAttachment, removeAttachment]
+ [captureIssueEvent, workspaceSlug, projectId, issueId, createAttachment, removeAttachment]
);
return (