π₯π₯π₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.
TypeScript boardsbug-trackerdjangodockerganttissue-trackerjirajira-alternativekanbanlinearpostgresqlproduct-managementproject-managementproject-planningpythonreactredistypesciptvitework-management
fix: strip control characters from sanitized filenames (#9151)
Karthikeyan Ganesh49c4da6d4b1f
diff --git a/apps/api/plane/utils/path_validator.py b/apps/api/plane/utils/path_validator.pyindex ab2e2bae53..2ea71c18f2 100644--- a/apps/api/plane/utils/path_validator.py+++ b/apps/api/plane/utils/path_validator.py@@ -15,8 +15,8 @@ def sanitize_filename(filename):"""Sanitize a filename to prevent path traversal attacks.- Strips directory components, path traversal sequences, and null bytes- from user-supplied filenames used in upload paths and S3 object keys.+ Strips directory components, path traversal sequences, and control+ characters from user-supplied filenames used in upload paths and S3 object keys.Returns None for empty/missing input so callers can still validatethat a filename was provided.@@ -24,8 +24,8 @@ def sanitize_filename(filename):if not filename or not isinstance(filename, str):return None- # Strip null bytes- filename = filename.replace("\x00", "")+ # Strip ASCII control characters (0-31 and 127), including null bytes+ filename = "".join(char for char in filename if not (ord(char) < 32 or ord(char) == 127))# Normalize backslashes so os.path.basename handles Windows-style paths on POSIXfilename = filename.replace("\\", "/")