Skip to content

armgit / plane

Public Imported from GitHub
0

πŸ”₯πŸ”₯πŸ”₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.

[WEB-2597] fix: handle favorite entity data causing application error (#6853)

Anmol Singh Bhatia4be94adaca41
diff --git a/web/core/components/workspace/sidebar/favorites/favorites-menu.tsx b/web/core/components/workspace/sidebar/favorites/favorites-menu.tsx
index bfd08056da..2beed74f66 100644
--- a/web/core/components/workspace/sidebar/favorites/favorites-menu.tsx
+++ b/web/core/components/workspace/sidebar/favorites/favorites-menu.tsx
@@ -252,33 +252,37 @@ export const SidebarFavoritesMenu = observer(() => {
orderBy(Object.values(groupedFavorites), "sequence", "desc")
.filter((fav) => !fav.parent)
.map((fav, index, { length }) => (
- <Tooltip
- key={fav.id}
- tooltipContent={fav?.entity_data ? fav.entity_data?.name : fav?.name}
- position="right"
- className="ml-2"
- disabled={!sidebarCollapsed}
- isMobile={isMobile}
- >
- {fav.is_folder ? (
- <FavoriteFolder
- favorite={fav}
- isLastChild={index === length - 1}
- handleRemoveFromFavorites={handleRemoveFromFavorites}
- handleRemoveFromFavoritesFolder={handleRemoveFromFavoritesFolder}
- handleDrop={handleDrop}
- />
- ) : (
- <FavoriteRoot
- workspaceSlug={workspaceSlug.toString()}
- favorite={fav}
- isLastChild={index === length - 1}
- parentId={undefined}
- handleRemoveFromFavorites={handleRemoveFromFavorites}
- handleDrop={handleDrop}
- />
+ <>
+ {fav?.id && (
+ <Tooltip
+ key={fav?.id}
+ tooltipContent={fav?.entity_data ? fav?.entity_data?.name : fav?.name}
+ position="right"
+ className="ml-2"
+ disabled={!sidebarCollapsed}
+ isMobile={isMobile}
+ >
+ {fav?.is_folder ? (
+ <FavoriteFolder
+ favorite={fav}
+ isLastChild={index === length - 1}
+ handleRemoveFromFavorites={handleRemoveFromFavorites}
+ handleRemoveFromFavoritesFolder={handleRemoveFromFavoritesFolder}
+ handleDrop={handleDrop}
+ />
+ ) : (
+ <FavoriteRoot
+ workspaceSlug={workspaceSlug.toString()}
+ favorite={fav}
+ isLastChild={index === length - 1}
+ parentId={undefined}
+ handleRemoveFromFavorites={handleRemoveFromFavorites}
+ handleDrop={handleDrop}
+ />
+ )}
+ </Tooltip>
)}
- </Tooltip>
+ </>
))
)}
</Disclosure.Panel>