Skip to content

armgit / plane

Public Imported from GitHub
0

πŸ”₯πŸ”₯πŸ”₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.

fix: module endpoint validations (#4071)

Nikhil4c46b075b444
diff --git a/apiserver/plane/app/views/module/base.py b/apiserver/plane/app/views/module/base.py
index 7769aee3fa..3fe3a078ac 100644
--- a/apiserver/plane/app/views/module/base.py
+++ b/apiserver/plane/app/views/module/base.py
@@ -1,54 +1,57 @@
# Python imports
import json
-# Django Imports
-from django.utils import timezone
+from django.contrib.postgres.aggregates import ArrayAgg
+from django.contrib.postgres.fields import ArrayField
from django.db.models import (
- Prefetch,
+ Count,
+ Exists,
F,
+ Func,
+ IntegerField,
OuterRef,
- Exists,
- Count,
+ Prefetch,
Q,
- Func,
Subquery,
- IntegerField,
+ UUIDField,
+ Value,
)
-from django.contrib.postgres.aggregates import ArrayAgg
-from django.contrib.postgres.fields import ArrayField
-from django.db.models import Value, UUIDField
from django.db.models.functions import Coalesce
+# Django Imports
+from django.utils import timezone
+from rest_framework import status
+
# Third party imports
from rest_framework.response import Response
-from rest_framework import status
-# Module imports
-from .. import BaseViewSet, BaseAPIView, WebhookMixin
-from plane.app.serializers import (
- ModuleWriteSerializer,
- ModuleSerializer,
- ModuleLinkSerializer,
- ModuleFavoriteSerializer,
- ModuleUserPropertiesSerializer,
- ModuleDetailSerializer,
-)
from plane.app.permissions import (
ProjectEntityPermission,
ProjectLitePermission,
)
+from plane.app.serializers import (
+ ModuleDetailSerializer,
+ ModuleFavoriteSerializer,
+ ModuleLinkSerializer,
+ ModuleSerializer,
+ ModuleUserPropertiesSerializer,
+ ModuleWriteSerializer,
+)
+from plane.bgtasks.issue_activites_task import issue_activity
from plane.db.models import (
+ Issue,
Module,
+ ModuleFavorite,
ModuleIssue,
- Project,
- Issue,
ModuleLink,
- ModuleFavorite,
ModuleUserProperties,
+ Project,
)
-from plane.bgtasks.issue_activites_task import issue_activity
from plane.utils.analytics_plot import burndown_plot
+# Module imports
+from .. import BaseAPIView, BaseViewSet, WebhookMixin
+
class ModuleViewSet(WebhookMixin, BaseViewSet):
model = Module
@@ -392,9 +395,11 @@ class ModuleViewSet(WebhookMixin, BaseViewSet):
"completion_chart": {},
}
- if queryset.first().start_date and queryset.first().target_date:
+ # Fetch the modules
+ modules = queryset.first()
+ if modules and modules.start_date and modules.target_date:
data["distribution"]["completion_chart"] = burndown_plot(
- queryset=queryset.first(),
+ queryset=modules,
slug=slug,
project_id=project_id,
module_id=pk,
diff --git a/apiserver/plane/app/views/workspace/estimate.py b/apiserver/plane/app/views/workspace/estimate.py
index 8ca24efd74..59a23d8677 100644
--- a/apiserver/plane/app/views/workspace/estimate.py
+++ b/apiserver/plane/app/views/workspace/estimate.py
@@ -3,15 +3,10 @@ from rest_framework import status
from rest_framework.response import Response
# Module imports
+from plane.app.permissions import WorkspaceEntityPermission
from plane.app.serializers import WorkspaceEstimateSerializer
from plane.app.views.base import BaseAPIView
-from plane.db.models import Project, Estimate
-from plane.app.permissions import WorkspaceEntityPermission
-
-# Django imports
-from django.db.models import (
- Prefetch,
-)
+from plane.db.models import Estimate, Project
from plane.utils.cache import cache_response