π₯π₯π₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.
TypeScript boardsbug-trackerdjangodockerganttissue-trackerjirajira-alternativekanbanlinearpostgresqlproduct-managementproject-managementproject-planningpythonreactredistypesciptvitework-management
[WEB-7854] fix: prevent workspace invite token disclosure and invite hijack (#9297)
Manish Gupta6220ba990b22
diff --git a/apps/api/plane/app/serializers/__init__.py b/apps/api/plane/app/serializers/__init__.pyindex e8a4007ea6..75cd35afc3 100644--- a/apps/api/plane/app/serializers/__init__.py+++ b/apps/api/plane/app/serializers/__init__.py@@ -18,6 +18,7 @@ from .workspace import (WorkSpaceSerializer,WorkSpaceMemberSerializer,WorkSpaceMemberInviteSerializer,+ WorkSpaceMemberInvitePublicSerializer,WorkspaceLiteSerializer,WorkspaceThemeSerializer,WorkspaceMemberAdminSerializer,diff --git a/apps/api/plane/app/serializers/workspace.py b/apps/api/plane/app/serializers/workspace.pyindex 940b2c58d5..63d4ea99d1 100644--- a/apps/api/plane/app/serializers/workspace.py+++ b/apps/api/plane/app/serializers/workspace.py@@ -137,6 +137,33 @@ class WorkSpaceMemberInviteSerializer(BaseSerializer):]+class WorkSpaceMemberInvitePublicSerializer(BaseSerializer):+ """Safe read-only serializer for the public workspace invite GET endpoint.++ Intentionally excludes ``token`` and ``invite_link`` so that an+ unauthenticated caller cannot retrieve the acceptance token and use it to+ hijack an invitation (GHSA-86mg-259g-pwgg / GHSA-gf48-p6jp-cwc4).+ """++ workspace = WorkspaceLiteSerializer(read_only=True)++ class Meta:+ model = WorkspaceMemberInvite+ fields = [+ "id",+ "email",+ "workspace",+ "role",+ "message",+ "accepted",+ "responded_at",+ "created_at",+ "updated_at",+ "created_by",+ ]+ read_only_fields = fields++class WorkspaceThemeSerializer(BaseSerializer):class Meta:model = WorkspaceThemediff --git a/apps/api/plane/app/views/workspace/invite.py b/apps/api/plane/app/views/workspace/invite.pyindex cf2ab795a7..0c61bce441 100644--- a/apps/api/plane/app/views/workspace/invite.py+++ b/apps/api/plane/app/views/workspace/invite.py@@ -22,6 +22,7 @@ from rest_framework.response import Responsefrom plane.app.permissions import WorkSpaceAdminPermissionfrom plane.app.serializers import (WorkSpaceMemberInviteSerializer,+ WorkSpaceMemberInvitePublicSerializer,WorkSpaceMemberSerializer,)from plane.app.views.base import BaseAPIView@@ -172,6 +173,21 @@ class WorkspaceJoinEndpoint(BaseAPIView):status=status.HTTP_403_FORBIDDEN,)+ # Require an authenticated session β the accepting user must be the+ # person who was invited. Without this check an attacker who registers+ # with the invited address (email-squat) and obtains the token via the+ # GET endpoint can steal the workspace membership (GHSA-4vj8-p63v-8p24).+ if not request.user.is_authenticated:+ return Response(+ {"error": "Authentication required to accept workspace invitation"},+ status=status.HTTP_401_UNAUTHORIZED,+ )+ if request.user.email.lower() != workspace_invite.email.lower():+ return Response(+ {"error": "You do not have permission to accept this invitation"},+ status=status.HTTP_403_FORBIDDEN,+ )+# If already responded then return errorif workspace_invite.responded_at is None:workspace_invite.accepted = request.data.get("accepted", False)@@ -237,7 +253,10 @@ class WorkspaceJoinEndpoint(BaseAPIView):def get(self, request, slug, pk):workspace_invitation = WorkspaceMemberInvite.objects.get(workspace__slug=slug, pk=pk)- serializer = WorkSpaceMemberInviteSerializer(workspace_invitation)+ # Use the public serializer that omits the token and invite_link fields so+ # that an unauthenticated caller cannot retrieve the acceptance token+ # (GHSA-86mg-259g-pwgg / GHSA-gf48-p6jp-cwc4).+ serializer = WorkSpaceMemberInvitePublicSerializer(workspace_invitation)return Response(serializer.data, status=status.HTTP_200_OK)