Skip to content

armgit / plane

Public Imported from GitHub
0

πŸ”₯πŸ”₯πŸ”₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.

chore: custom search select input key down improvement (#3787)

Anmol Singh Bhatia67fdafb720b7
diff --git a/web/components/dropdowns/cycle.tsx b/web/components/dropdowns/cycle.tsx
index 09b0acde5e..d1f552a99a 100644
--- a/web/components/dropdowns/cycle.tsx
+++ b/web/components/dropdowns/cycle.tsx
@@ -148,6 +148,13 @@ export const CycleDropdown: React.FC<Props> = observer((props) => {
toggleDropdown();
};
+ const searchInputKeyDown = (e: React.KeyboardEvent<HTMLInputElement>) => {
+ if (query !== "" && e.key === "Escape") {
+ e.stopPropagation();
+ setQuery("");
+ }
+ };
+
useOutsideClickDetector(dropdownRef, handleClose);
useEffect(() => {
@@ -231,6 +238,7 @@ export const CycleDropdown: React.FC<Props> = observer((props) => {
onChange={(e) => setQuery(e.target.value)}
placeholder="Search"
displayValue={(assigned: any) => assigned?.name}
+ onKeyDown={searchInputKeyDown}
/>
</div>
<div className="mt-2 max-h-48 space-y-1 overflow-y-scroll">
diff --git a/web/components/dropdowns/estimate.tsx b/web/components/dropdowns/estimate.tsx
index 2674fa902d..61513cdbab 100644
--- a/web/components/dropdowns/estimate.tsx
+++ b/web/components/dropdowns/estimate.tsx
@@ -137,6 +137,13 @@ export const EstimateDropdown: React.FC<Props> = observer((props) => {
toggleDropdown();
};
+ const searchInputKeyDown = (e: React.KeyboardEvent<HTMLInputElement>) => {
+ if (query !== "" && e.key === "Escape") {
+ e.stopPropagation();
+ setQuery("");
+ }
+ };
+
useOutsideClickDetector(dropdownRef, handleClose);
useEffect(() => {
@@ -217,6 +224,7 @@ export const EstimateDropdown: React.FC<Props> = observer((props) => {
onChange={(e) => setQuery(e.target.value)}
placeholder="Search"
displayValue={(assigned: any) => assigned?.name}
+ onKeyDown={searchInputKeyDown}
/>
</div>
<div className="mt-2 max-h-48 space-y-1 overflow-y-scroll">
diff --git a/web/components/dropdowns/member/project-member.tsx b/web/components/dropdowns/member/project-member.tsx
index 0e24798491..db87025358 100644
--- a/web/components/dropdowns/member/project-member.tsx
+++ b/web/components/dropdowns/member/project-member.tsx
@@ -130,6 +130,13 @@ export const ProjectMemberDropdown: React.FC<Props> = observer((props) => {
toggleDropdown();
};
+ const searchInputKeyDown = (e: React.KeyboardEvent<HTMLInputElement>) => {
+ if (query !== "" && e.key === "Escape") {
+ e.stopPropagation();
+ setQuery("");
+ }
+ };
+
useOutsideClickDetector(dropdownRef, handleClose);
useEffect(() => {
@@ -215,6 +222,7 @@ export const ProjectMemberDropdown: React.FC<Props> = observer((props) => {
onChange={(e) => setQuery(e.target.value)}
placeholder="Search"
displayValue={(assigned: any) => assigned?.name}
+ onKeyDown={searchInputKeyDown}
/>
</div>
<div className="mt-2 max-h-48 space-y-1 overflow-y-scroll">
diff --git a/web/components/dropdowns/module.tsx b/web/components/dropdowns/module.tsx
index f41ece121e..cee0ed9f31 100644
--- a/web/components/dropdowns/module.tsx
+++ b/web/components/dropdowns/module.tsx
@@ -249,6 +249,13 @@ export const ModuleDropdown: React.FC<Props> = observer((props) => {
toggleDropdown();
};
+ const searchInputKeyDown = (e: React.KeyboardEvent<HTMLInputElement>) => {
+ if (query !== "" && e.key === "Escape") {
+ e.stopPropagation();
+ setQuery("");
+ }
+ };
+
useOutsideClickDetector(dropdownRef, handleClose);
const comboboxProps: any = {
@@ -349,6 +356,7 @@ export const ModuleDropdown: React.FC<Props> = observer((props) => {
onChange={(e) => setQuery(e.target.value)}
placeholder="Search"
displayValue={(assigned: any) => assigned?.name}
+ onKeyDown={searchInputKeyDown}
/>
</div>
<div className="mt-2 max-h-48 space-y-1 overflow-y-scroll">
diff --git a/web/components/dropdowns/priority.tsx b/web/components/dropdowns/priority.tsx
index d519ad9f18..3aef222335 100644
--- a/web/components/dropdowns/priority.tsx
+++ b/web/components/dropdowns/priority.tsx
@@ -329,6 +329,13 @@ export const PriorityDropdown: React.FC<Props> = (props) => {
toggleDropdown();
};
+ const searchInputKeyDown = (e: React.KeyboardEvent<HTMLInputElement>) => {
+ if (query !== "" && e.key === "Escape") {
+ e.stopPropagation();
+ setQuery("");
+ }
+ };
+
useOutsideClickDetector(dropdownRef, handleClose);
const ButtonToRender = BORDER_BUTTON_VARIANTS.includes(buttonVariant)
@@ -417,6 +424,7 @@ export const PriorityDropdown: React.FC<Props> = (props) => {
onChange={(e) => setQuery(e.target.value)}
placeholder="Search"
displayValue={(assigned: any) => assigned?.name}
+ onKeyDown={searchInputKeyDown}
/>
</div>
<div className="mt-2 max-h-48 space-y-1 overflow-y-scroll">
diff --git a/web/components/dropdowns/state.tsx b/web/components/dropdowns/state.tsx
index fa068fdd01..9591a7686c 100644
--- a/web/components/dropdowns/state.tsx
+++ b/web/components/dropdowns/state.tsx
@@ -119,6 +119,13 @@ export const StateDropdown: React.FC<Props> = observer((props) => {
toggleDropdown();
};
+ const searchInputKeyDown = (e: React.KeyboardEvent<HTMLInputElement>) => {
+ if (query !== "" && e.key === "Escape") {
+ e.stopPropagation();
+ setQuery("");
+ }
+ };
+
useOutsideClickDetector(dropdownRef, handleClose);
useEffect(() => {
@@ -205,6 +212,7 @@ export const StateDropdown: React.FC<Props> = observer((props) => {
onChange={(e) => setQuery(e.target.value)}
placeholder="Search"
displayValue={(assigned: any) => assigned?.name}
+ onKeyDown={searchInputKeyDown}
/>
</div>
<div className="mt-2 max-h-48 space-y-1 overflow-y-scroll">
diff --git a/web/components/issues/issue-detail/label/select/label-select.tsx b/web/components/issues/issue-detail/label/select/label-select.tsx
index 4cdbdcf59a..11ff77d37e 100644
--- a/web/components/issues/issue-detail/label/select/label-select.tsx
+++ b/web/components/issues/issue-detail/label/select/label-select.tsx
@@ -80,6 +80,13 @@ export const IssueLabelSelect: React.FC<IIssueLabelSelect> = observer((props) =>
</div>
);
+ const searchInputKeyDown = (e: React.KeyboardEvent<HTMLInputElement>) => {
+ if (query !== "" && e.key === "Escape") {
+ e.stopPropagation();
+ setQuery("");
+ }
+ };
+
if (!issue) return <></>;
return (
@@ -118,6 +125,7 @@ export const IssueLabelSelect: React.FC<IIssueLabelSelect> = observer((props) =>
onChange={(e) => setQuery(e.target.value)}
placeholder="Search"
displayValue={(assigned: any) => assigned?.name}
+ onKeyDown={searchInputKeyDown}
/>
</div>
</div>