Skip to content

armgit / plane

Public Imported from GitHub
0

πŸ”₯πŸ”₯πŸ”₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.

[WEB-4943]: add url has allowed host or scheme for validating valid redirections (#7809)

Nikhil6d3d9e6df7b0
diff --git a/apps/api/plane/authentication/views/space/email.py b/apps/api/plane/authentication/views/space/email.py
index d247f6e989..2fb1c2c5ea 100644
--- a/apps/api/plane/authentication/views/space/email.py
+++ b/apps/api/plane/authentication/views/space/email.py
@@ -3,6 +3,7 @@ from django.core.exceptions import ValidationError
from django.core.validators import validate_email
from django.http import HttpResponseRedirect
from django.views import View
+from django.utils.http import url_has_allowed_host_and_scheme
# Module imports
from plane.authentication.provider.credentials.email import EmailProvider
@@ -200,7 +201,10 @@ class SignUpAuthSpaceEndpoint(View):
# redirect to referer path
next_path = validate_next_path(next_path=next_path)
url = f"{base_host(request=request, is_space=True).rstrip("/")}{next_path}"
- return HttpResponseRedirect(url)
+ if url_has_allowed_host_and_scheme(url, allowed_hosts=get_allowed_hosts()):
+ return HttpResponseRedirect(url)
+ else:
+ return HttpResponseRedirect(base_host(request=request, is_space=True))
except AuthenticationException as e:
params = e.get_error_dict()
url = get_safe_redirect_url(
diff --git a/apps/api/plane/authentication/views/space/magic.py b/apps/api/plane/authentication/views/space/magic.py
index f50274a4a2..85e3a185cf 100644
--- a/apps/api/plane/authentication/views/space/magic.py
+++ b/apps/api/plane/authentication/views/space/magic.py
@@ -2,6 +2,7 @@
from django.core.validators import validate_email
from django.http import HttpResponseRedirect
from django.views import View
+from django.utils.http import url_has_allowed_host_and_scheme
# Third party imports
from rest_framework import status
@@ -20,7 +21,7 @@ from plane.authentication.adapter.error import (
AuthenticationException,
AUTHENTICATION_ERROR_CODES,
)
-from plane.utils.path_validator import get_safe_redirect_url, validate_next_path
+from plane.utils.path_validator import get_safe_redirect_url, validate_next_path, get_allowed_hosts
class MagicGenerateSpaceEndpoint(APIView):
@@ -96,7 +97,10 @@ class MagicSignInSpaceEndpoint(View):
# redirect to referer path
next_path = validate_next_path(next_path=next_path)
url = f"{base_host(request=request, is_space=True).rstrip("/")}{next_path}"
- return HttpResponseRedirect(url)
+ if url_has_allowed_host_and_scheme(url, allowed_hosts=get_allowed_hosts()):
+ return HttpResponseRedirect(url)
+ else:
+ return HttpResponseRedirect(base_host(request=request, is_space=True))
except AuthenticationException as e:
params = e.get_error_dict()
@@ -155,7 +159,10 @@ class MagicSignUpSpaceEndpoint(View):
# redirect to referer path
next_path = validate_next_path(next_path=next_path)
url = f"{base_host(request=request, is_space=True).rstrip("/")}{next_path}"
- return HttpResponseRedirect(url)
+ if url_has_allowed_host_and_scheme(url, allowed_hosts=get_allowed_hosts()):
+ return HttpResponseRedirect(url)
+ else:
+ return HttpResponseRedirect(base_host(request=request, is_space=True))
except AuthenticationException as e:
params = e.get_error_dict()
diff --git a/apps/api/plane/utils/path_validator.py b/apps/api/plane/utils/path_validator.py
index e5bf7aeb2a..a89c8b9698 100644
--- a/apps/api/plane/utils/path_validator.py
+++ b/apps/api/plane/utils/path_validator.py
@@ -1,6 +1,11 @@
+# Django imports
+from django.utils.http import url_has_allowed_host_and_scheme
+from django.conf import settings
+
# Python imports
from urllib.parse import urlparse
+
def _contains_suspicious_patterns(path: str) -> bool:
"""
Check for suspicious patterns that might indicate malicious intent.
@@ -38,6 +43,21 @@ def _contains_suspicious_patterns(path: str) -> bool:
return False
+def get_allowed_hosts() -> list[str]:
+ """Get the allowed hosts from the settings."""
+ base_origin = settings.WEB_URL or settings.APP_BASE_URL
+ allowed_hosts = [base_origin]
+ if settings.ADMIN_BASE_URL:
+ # Get only the host
+ host = urlparse(settings.ADMIN_BASE_URL).netloc
+ allowed_hosts.append(host)
+ if settings.SPACE_BASE_URL:
+ # Get only the host
+ host = urlparse(settings.SPACE_BASE_URL).netloc
+ allowed_hosts.append(host)
+ return allowed_hosts
+
+
def validate_next_path(next_path: str) -> str:
"""Validates that next_path is a safe relative path for redirection."""
# Browsers interpret backslashes as forward slashes. Remove all backslashes.
@@ -92,7 +112,14 @@ def get_safe_redirect_url(base_url: str, next_path: str = "", params: dict = {})
base_url = base_url.rstrip('/')
if params:
encoded_params = urlencode(params)
- return f"{base_url}/?next_path={validated_path}&{encoded_params}"
+ url = f"{base_url}/?next_path={validated_path}&{encoded_params}"
+ else:
+ url = f"{base_url}/?next_path={validated_path}"
- return f"{base_url}/?next_path={validated_path}"
+ # Check if the URL is allowed
+ if url_has_allowed_host_and_scheme(url, allowed_hosts=get_allowed_hosts()):
+ return url
+
+ # Return the base URL if the URL is not allowed
+ return base_url
\ No newline at end of file