π₯π₯π₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.
TypeScript boardsbug-trackerdjangodockerganttissue-trackerjirajira-alternativekanbanlinearpostgresqlproduct-managementproject-managementproject-planningpythonreactredistypesciptvitework-management
[WIKI-570] fix: image alignment for read only editor #7509
Aaryan Khandelwal6e1734c86e44
diff --git a/packages/editor/src/core/extensions/custom-image/components/block.tsx b/packages/editor/src/core/extensions/custom-image/components/block.tsxindex 45c66f428b..83a2a12269 100644--- a/packages/editor/src/core/extensions/custom-image/components/block.tsx+++ b/packages/editor/src/core/extensions/custom-image/components/block.tsx@@ -280,6 +280,7 @@ export const CustomImageBlock: React.FC<CustomImageBlockProps> = (props) => {{showImageToolbar && (<ImageToolbarRootalignment={nodeAlignment ?? "left"}+ editor={editor}width={size.width}height={size.height}aspectRatio={size.aspectRatio === null ? 1 : size.aspectRatio}diff --git a/packages/editor/src/core/extensions/custom-image/components/toolbar/root.tsx b/packages/editor/src/core/extensions/custom-image/components/toolbar/root.tsxindex 06277fa252..268da5f162 100644--- a/packages/editor/src/core/extensions/custom-image/components/toolbar/root.tsx+++ b/packages/editor/src/core/extensions/custom-image/components/toolbar/root.tsx@@ -1,3 +1,4 @@+import type { Editor } from "@tiptap/core";import { useState } from "react";// plane importsimport { cn } from "@plane/utils";@@ -9,6 +10,7 @@ import { ImageFullScreenActionRoot } from "./full-screen";type Props = {alignment: TCustomImageAlignment;+ editor: Editor;width: string;height: string;aspectRatio: number;@@ -18,9 +20,11 @@ type Props = {};export const ImageToolbarRoot: React.FC<Props> = (props) => {- const { alignment, downloadSrc, handleAlignmentChange } = props;+ const { alignment, editor, downloadSrc, handleAlignmentChange } = props;// statesconst [shouldShowToolbar, setShouldShowToolbar] = useState(false);+ // derived values+ const isEditable = editor.isEditable;return (<>@@ -33,11 +37,13 @@ export const ImageToolbarRoot: React.FC<Props> = (props) => {)}><ImageDownloadAction src={downloadSrc} />- <ImageAlignmentAction- activeAlignment={alignment}- handleChange={handleAlignmentChange}- toggleToolbarViewStatus={setShouldShowToolbar}- />+ {isEditable && (+ <ImageAlignmentAction+ activeAlignment={alignment}+ handleChange={handleAlignmentChange}+ toggleToolbarViewStatus={setShouldShowToolbar}+ />+ )}<ImageFullScreenActionRoot image={props} toggleToolbarViewStatus={setShouldShowToolbar} /></div></>