π₯π₯π₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.
TypeScript boardsbug-trackerdjangodockerganttissue-trackerjirajira-alternativekanbanlinearpostgresqlproduct-managementproject-managementproject-planningpythonreactredistypesciptvitework-management
[WIKI-543] fix: unable to delete last cell of a table (#7394)
Aaryan Khandelwal7136b3129bd2
diff --git a/packages/editor/src/core/components/menus/bubble-menu/root.tsx b/packages/editor/src/core/components/menus/bubble-menu/root.tsxindex 3a55792181..05e8911491 100644--- a/packages/editor/src/core/components/menus/bubble-menu/root.tsx+++ b/packages/editor/src/core/components/menus/bubble-menu/root.tsx@@ -24,7 +24,7 @@ import { CORE_EXTENSIONS } from "@/constants/extension";import { isCellSelection } from "@/extensions/table/table/utilities/helpers";// typesimport { TEditorCommands } from "@/types";-// local components+// local importsimport { TextAlignmentSelector } from "./alignment-selector";type EditorBubbleMenuProps = Omit<BubbleMenuProps, "children">;diff --git a/packages/editor/src/core/extensions/table/table-cell.ts b/packages/editor/src/core/extensions/table/table-cell.tsindex a9c98717be..42fd3c7df5 100644--- a/packages/editor/src/core/extensions/table/table-cell.ts+++ b/packages/editor/src/core/extensions/table/table-cell.ts@@ -1,9 +1,13 @@import { mergeAttributes, Node } from "@tiptap/core";+import { TableMap } from "@tiptap/pm/tables";// constantsimport { CORE_EXTENSIONS } from "@/constants/extension";+// helpers+import { findParentNodeOfType } from "@/helpers/common";// local importsimport { TableCellSelectionOutlinePlugin } from "./plugins/selection-outline/plugin";import { DEFAULT_COLUMN_WIDTH } from "./table";+import { isCellSelection } from "./table/utilities/helpers";export interface TableCellOptions {HTMLAttributes: Record<string, any>;@@ -54,6 +58,47 @@ export const TableCell = Node.create<TableCellOptions>({return [TableCellSelectionOutlinePlugin(this.editor)];},+ addKeyboardShortcuts() {+ return {+ Backspace: ({ editor }) => {+ const { state } = editor.view;+ const { selection } = state;++ if (isCellSelection(selection)) return false;++ // Check if we're at the start of the cell+ if (selection.from !== selection.to || selection.$head.parentOffset !== 0) return false;++ // Find table and current cell+ const tableNode = findParentNodeOfType(selection, [CORE_EXTENSIONS.TABLE])?.node;+ const currentCellInfo = findParentNodeOfType(selection, [+ CORE_EXTENSIONS.TABLE_CELL,+ CORE_EXTENSIONS.TABLE_HEADER,+ ]);+ const currentCellNode = currentCellInfo?.node;+ const cellPos = currentCellInfo?.pos;+ const cellDepth = currentCellInfo?.depth;++ if (!tableNode || !currentCellNode || cellPos === null || cellDepth === null) return false;++ // Check if this is the only cell in the TableMap (1 row, 1 column)+ const tableMap = TableMap.get(tableNode);+ const isOnlyCell = tableMap.width === 1 && tableMap.height === 1;+ if (!isOnlyCell) return false;++ // Cell has content, select the entire cell+ // Use the position that points to the cell node itself, not its content+ const cellNodePos = selection.$head.before(cellDepth);++ editor.commands.setCellSelection({+ anchorCell: cellNodePos,+ headCell: cellNodePos,+ });+ return true;+ },+ };+ },+parseHTML() {return [{ tag: "td" }];},diff --git a/packages/editor/src/core/extensions/table/table/utilities/insert-line-above-table-action.ts b/packages/editor/src/core/extensions/table/table/utilities/insert-line-above-table-action.tsindex 35c2ee3c71..9a50a839c4 100644--- a/packages/editor/src/core/extensions/table/table/utilities/insert-line-above-table-action.ts+++ b/packages/editor/src/core/extensions/table/table/utilities/insert-line-above-table-action.ts@@ -13,7 +13,7 @@ export const insertLineAboveTableAction: KeyboardShortcutCommand = ({ editor })const { selection } = editor.state;// Find the table node and its position- const tableNode = findParentNodeOfType(selection, CORE_EXTENSIONS.TABLE);+ const tableNode = findParentNodeOfType(selection, [CORE_EXTENSIONS.TABLE]);if (!tableNode) return false;const tablePos = tableNode.pos;diff --git a/packages/editor/src/core/extensions/table/table/utilities/insert-line-below-table-action.ts b/packages/editor/src/core/extensions/table/table/utilities/insert-line-below-table-action.tsindex 6c26e22a2f..b30b8ae4dd 100644--- a/packages/editor/src/core/extensions/table/table/utilities/insert-line-below-table-action.ts+++ b/packages/editor/src/core/extensions/table/table/utilities/insert-line-below-table-action.ts@@ -13,7 +13,7 @@ export const insertLineBelowTableAction: KeyboardShortcutCommand = ({ editor })const { selection } = editor.state;// Find the table node and its position- const tableNode = findParentNodeOfType(selection, CORE_EXTENSIONS.TABLE);+ const tableNode = findParentNodeOfType(selection, [CORE_EXTENSIONS.TABLE]);if (!tableNode) return false;const tablePos = tableNode.pos;diff --git a/packages/editor/src/core/helpers/common.ts b/packages/editor/src/core/helpers/common.tsindex e694e1e853..301d81917a 100644--- a/packages/editor/src/core/helpers/common.ts+++ b/packages/editor/src/core/helpers/common.ts@@ -1,3 +1,4 @@+import type { Node as ProseMirrorNode } from "@tiptap/pm/model";import { EditorState, Selection } from "@tiptap/pm/state";// plane importsimport { cn } from "@plane/utils";@@ -21,17 +22,28 @@ export const getEditorClassNames = ({ noBorder, borderOnFocus, containerClassNam);// Helper function to find the parent node of a specific type-export function findParentNodeOfType(selection: Selection, typeName: string) {+export const findParentNodeOfType = (+ selection: Selection,+ typeName: string[]+): {+ node: ProseMirrorNode;+ pos: number;+ depth: number;+} | null => {let depth = selection.$anchor.depth;while (depth > 0) {const node = selection.$anchor.node(depth);- if (node.type.name === typeName) {- return { node, pos: selection.$anchor.start(depth) - 1 };+ if (typeName.includes(node.type.name)) {+ return {+ node,+ pos: selection.$anchor.start(depth) - 1,+ depth,+ };}depth--;}return null;-}+};export const findTableAncestor = (node: Node | null): HTMLTableElement | null => {while (node !== null && node.nodeName !== "TABLE") {