π₯π₯π₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.
TypeScript boardsbug-trackerdjangodockerganttissue-trackerjirajira-alternativekanbanlinearpostgresqlproduct-managementproject-managementproject-planningpythonreactredistypesciptvitework-management
[WEB-1610] chore: re-implement reload confirmation hook. (#4880)
Prateek Shourya718453b3328b
diff --git a/packages/editor/core/src/ui/mentions/mention-node-view.tsx b/packages/editor/core/src/ui/mentions/mention-node-view.tsxindex 9395287852..2100bd24a4 100644--- a/packages/editor/core/src/ui/mentions/mention-node-view.tsx+++ b/packages/editor/core/src/ui/mentions/mention-node-view.tsx@@ -2,14 +2,12 @@// @ts-nocheckimport { NodeViewWrapper } from "@tiptap/react";import { cn } from "src/lib/utils";-import { useRouter } from "next/navigation";import { IMentionHighlight } from "src/types/mention-suggestion";import { useEffect, useState } from "react";// eslint-disable-next-line import/no-anonymous-default-exportexport const MentionNodeView = (props) => {// TODO: move it to web app- const router = useRouter();const [highlightsState, setHighlightsState] = useState<IMentionHighlight[]>();useEffect(() => {@@ -21,25 +19,20 @@ export const MentionNodeView = (props) => {hightlights();}, [props.extension.options]);- const handleClick = () => {- if (!props.extension.options.readonly) {- router.push(props.node.attrs.redirect_uri);- }- };-return (<NodeViewWrapper className="mention-component inline w-fit">- <span+ <a+ href={props.node.attrs.redirect_uri}+ target="_blank"className={cn("mention rounded bg-custom-primary-100/20 px-1 py-0.5 font-medium text-custom-primary-100", {"bg-yellow-500/20 text-yellow-500": highlightsState? highlightsState.includes(props.node.attrs.entity_identifier): false,"cursor-pointer": !props.extension.options.readonly,})}- onClick={handleClick}>@{props.node.attrs.label}- </span>+ </a></NodeViewWrapper>);};diff --git a/web/core/hooks/use-reload-confirmation.tsx b/web/core/hooks/use-reload-confirmation.tsxindex 1591574d06..998c5845d9 100644--- a/web/core/hooks/use-reload-confirmation.tsx+++ b/web/core/hooks/use-reload-confirmation.tsx@@ -1,41 +1,55 @@-/* eslint-disable @typescript-eslint/no-unused-vars */-import { useState } from "react";+import { useCallback, useEffect, useState } from "react";//TODO: remove temp flag isActive later and use showAlert as the source of truthconst useReloadConfirmations = (isActive = true) => {const [showAlert, setShowAlert] = useState(false);- // const router = useAppRouter();- // const handleBeforeUnload = useCallback(- // (event: BeforeUnloadEvent) => {- // if (!isActive || !showAlert) return;- // event.preventDefault();- // event.returnValue = "";- // },- // [isActive, showAlert]- // );+ const handleBeforeUnload = useCallback(+ (event: BeforeUnloadEvent) => {+ if (!isActive || !showAlert) return;+ event.preventDefault();+ event.returnValue = "";+ },+ [isActive, showAlert]+ );- // const handleRouteChangeStart = useCallback(- // (url: string, { shallow }: { shallow: boolean }) => {- // if (!isActive || !showAlert) return;- // const leave = confirm("Are you sure you want to leave? Changes you made may not be saved.");- // if (!leave) {- // router.events.emit("routeChangeError", new Error("Route change cancelled by user"), url, shallow);- // throw "routeChange aborted.";- // }- // },- // [isActive, router.events, showAlert]- // );+ const handleAnchorClick = useCallback(+ (event: MouseEvent) => {+ if (!isActive || !showAlert) return;+ // Skip if event target is not available or defaultPrevented+ if (!event.target || event.defaultPrevented) return;+ // Skip control/command/option/alt+click+ if (event.metaKey || event.ctrlKey || event.shiftKey || event.altKey) return;+ // check if the event target is an anchor or a child of an anchor tag+ const eventTarget = event.target as HTMLElement;+ if (!eventTarget.closest("a")) return; // This is intentionally not type safe+ // check if anchor target is _blank+ const anchorElement = eventTarget.closest("a") as HTMLAnchorElement;+ const isAnchorTargetBlank = anchorElement.getAttribute("target") === "_blank";+ if (isAnchorTargetBlank) return;+ // show confirm dialog+ const leave = confirm("Are you sure you want to leave? Changes you made may not be saved.");+ if (!leave) {+ event.preventDefault();+ event.stopPropagation();+ }+ },+ [isActive, showAlert]+ );- // useEffect(() => {- // window.addEventListener("beforeunload", handleBeforeUnload);- // router.events.on("routeChangeStart", handleRouteChangeStart);+ useEffect(() => {+ // handle browser refresh+ window.addEventListener("beforeunload", handleBeforeUnload, true);+ // handle anchor tag click+ window.addEventListener("click", handleAnchorClick, true);+ // TODO: handle back / forward button click- // return () => {- // window.removeEventListener("beforeunload", handleBeforeUnload);- // router.events.off("routeChangeStart", handleRouteChangeStart);- // };- // }, [handleBeforeUnload, handleRouteChangeStart, router.events]);+ return () => {+ // cleanup+ window.removeEventListener("beforeunload", handleBeforeUnload, true);+ window.removeEventListener("click", handleAnchorClick, true);+ };+ }, [handleAnchorClick, handleBeforeUnload]);return { setShowAlert };};