Skip to content

armgit / plane

Public Imported from GitHub
0

πŸ”₯πŸ”₯πŸ”₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.

[WEB-7727] fix(security): scope issue ID validation to workspace/project in bulk endpoints (#9269)

Manish Gupta81d9873d7f1c
diff --git a/apps/api/plane/api/views/cycle.py b/apps/api/plane/api/views/cycle.py
index 84c8abaac5..db58d9d355 100644
--- a/apps/api/plane/api/views/cycle.py
+++ b/apps/api/plane/api/views/cycle.py
@@ -945,6 +945,16 @@ class CycleIssueListCreateAPIEndpoint(BaseAPIView):
]
new_issues = list(set(issues) - set(existing_issues))
+ # Scope to workspace+project to prevent cross-tenant IDOR
+ new_issues = list(
+ str(i)
+ for i in Issue.issue_objects.filter(
+ workspace__slug=slug,
+ project_id=project_id,
+ pk__in=new_issues,
+ ).values_list("id", flat=True)
+ )
+
# New issues to create
created_records = CycleIssue.objects.bulk_create(
[
diff --git a/apps/api/plane/api/views/issue.py b/apps/api/plane/api/views/issue.py
index b48be56d41..ab439b3ab6 100644
--- a/apps/api/plane/api/views/issue.py
+++ b/apps/api/plane/api/views/issue.py
@@ -2482,6 +2482,15 @@ class IssueRelationListCreateAPIEndpoint(BaseAPIView):
actual_relation = get_actual_relation(relation_type)
is_reverse = relation_type in ["blocking", "start_after", "finish_after"]
+ # Scope to workspace to prevent cross-tenant IDOR
+ # Relations can cross projects so only workspace scope is enforced
+ issues = list(
+ Issue.issue_objects.filter(
+ workspace__slug=slug,
+ pk__in=issues,
+ ).values_list("id", flat=True)
+ )
+
IssueRelation.objects.bulk_create(
[
IssueRelation(
diff --git a/apps/api/plane/app/views/cycle/issue.py b/apps/api/plane/app/views/cycle/issue.py
index 6099678457..80b683a361 100644
--- a/apps/api/plane/app/views/cycle/issue.py
+++ b/apps/api/plane/app/views/cycle/issue.py
@@ -240,6 +240,16 @@ class CycleIssueViewSet(BaseViewSet):
existing_issues = [str(cycle_issue.issue_id) for cycle_issue in cycle_issues]
new_issues = list(set(issues) - set(existing_issues))
+ # Scope to workspace+project to prevent cross-tenant IDOR
+ new_issues = list(
+ str(i)
+ for i in Issue.issue_objects.filter(
+ workspace__slug=slug,
+ project_id=project_id,
+ pk__in=new_issues,
+ ).values_list("id", flat=True)
+ )
+
# New issues to create
created_records = CycleIssue.objects.bulk_create(
[
diff --git a/apps/api/plane/app/views/issue/relation.py b/apps/api/plane/app/views/issue/relation.py
index e91ddffec8..5fe44e55f2 100644
--- a/apps/api/plane/app/views/issue/relation.py
+++ b/apps/api/plane/app/views/issue/relation.py
@@ -217,6 +217,15 @@ class IssueRelationViewSet(BaseViewSet):
issues = request.data.get("issues", [])
project = Project.objects.get(pk=project_id)
+ # Scope to workspace to prevent cross-tenant IDOR
+ # Relations can cross projects so only workspace scope is enforced
+ issues = list(
+ Issue.issue_objects.filter(
+ workspace__slug=slug,
+ pk__in=issues,
+ ).values_list("id", flat=True)
+ )
+
issue_relation = IssueRelation.objects.bulk_create(
[
IssueRelation(
diff --git a/apps/api/plane/app/views/issue/sub_issue.py b/apps/api/plane/app/views/issue/sub_issue.py
index 5194148dd7..d1d7d8f115 100644
--- a/apps/api/plane/app/views/issue/sub_issue.py
+++ b/apps/api/plane/app/views/issue/sub_issue.py
@@ -211,7 +211,8 @@ class SubIssuesEndpoint(BaseAPIView):
status=status.HTTP_400_BAD_REQUEST,
)
- sub_issues = Issue.issue_objects.filter(id__in=sub_issue_ids)
+ # Scope to workspace to prevent cross-tenant IDOR
+ sub_issues = Issue.issue_objects.filter(id__in=sub_issue_ids, workspace__slug=slug)
for sub_issue in sub_issues:
sub_issue.parent = parent_issue
diff --git a/apps/api/plane/app/views/module/issue.py b/apps/api/plane/app/views/module/issue.py
index 4707d683a7..5a18db9a9e 100644
--- a/apps/api/plane/app/views/module/issue.py
+++ b/apps/api/plane/app/views/module/issue.py
@@ -213,6 +213,14 @@ class ModuleIssueViewSet(BaseViewSet):
if not issues:
return Response({"error": "Issues are required"}, status=status.HTTP_400_BAD_REQUEST)
project = Project.objects.get(pk=project_id)
+ # Scope to workspace+project to prevent cross-tenant IDOR
+ issues = list(
+ Issue.issue_objects.filter(
+ workspace__slug=slug,
+ project_id=project_id,
+ pk__in=issues,
+ ).values_list("id", flat=True)
+ )
_ = ModuleIssue.objects.bulk_create(
[
ModuleIssue(