π₯π₯π₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.
TypeScript boardsbug-trackerdjangodockerganttissue-trackerjirajira-alternativekanbanlinearpostgresqlproduct-managementproject-managementproject-planningpythonreactredistypesciptvitework-management
chore: issue link model field change (#3852)
Bavisetti Narayan87eadc3c5d4d
diff --git a/apiserver/plane/api/serializers/issue.py b/apiserver/plane/api/serializers/issue.pyindex 4c8d6e815b..b8f194b327 100644--- a/apiserver/plane/api/serializers/issue.py+++ b/apiserver/plane/api/serializers/issue.py@@ -1,8 +1,9 @@from lxml import html-# Django importsfrom django.utils import timezone+from django.core.validators import URLValidator+from django.core.exceptions import ValidationError# Third party importsfrom rest_framework import serializers@@ -284,6 +285,20 @@ class IssueLinkSerializer(BaseSerializer):"updated_at",]+ def validate_url(self, value):+ # Check URL format+ validate_url = URLValidator()+ try:+ validate_url(value)+ except ValidationError:+ raise serializers.ValidationError("Invalid URL format.")++ # Check URL scheme+ if not value.startswith(('http://', 'https://')):+ raise serializers.ValidationError("Invalid URL scheme.")++ return value+# Validation if url already existsdef create(self, validated_data):if IssueLink.objects.filter(@@ -295,6 +310,17 @@ class IssueLinkSerializer(BaseSerializer):)return IssueLink.objects.create(**validated_data)+ def update(self, instance, validated_data):+ if IssueLink.objects.filter(+ url=validated_data.get("url"),+ issue_id=instance.issue_id,+ ).exists():+ raise serializers.ValidationError(+ {"error": "URL already exists for this Issue"}+ )++ return super().update(instance, validated_data)+class IssueAttachmentSerializer(BaseSerializer):class Meta:diff --git a/apiserver/plane/app/serializers/issue.py b/apiserver/plane/app/serializers/issue.pyindex 411c5b73f8..1b884bedfb 100644--- a/apiserver/plane/app/serializers/issue.py+++ b/apiserver/plane/app/serializers/issue.py@@ -1,5 +1,7 @@# Django importsfrom django.utils import timezone+from django.core.validators import URLValidator+from django.core.exceptions import ValidationError# Third Party importsfrom rest_framework import serializers@@ -432,6 +434,20 @@ class IssueLinkSerializer(BaseSerializer):"issue",]+ def validate_url(self, value):+ # Check URL format+ validate_url = URLValidator()+ try:+ validate_url(value)+ except ValidationError:+ raise serializers.ValidationError("Invalid URL format.")++ # Check URL scheme+ if not value.startswith(('http://', 'https://')):+ raise serializers.ValidationError("Invalid URL scheme.")++ return value+# Validation if url already existsdef create(self, validated_data):if IssueLink.objects.filter(@@ -443,6 +459,17 @@ class IssueLinkSerializer(BaseSerializer):)return IssueLink.objects.create(**validated_data)+ def update(self, instance, validated_data):+ if IssueLink.objects.filter(+ url=validated_data.get("url"),+ issue_id=instance.issue_id,+ ).exists():+ raise serializers.ValidationError(+ {"error": "URL already exists for this Issue"}+ )++ return super().update(instance, validated_data)+class IssueLinkLiteSerializer(BaseSerializer):diff --git a/apiserver/plane/db/migrations/0061_alter_issuelink_url.py b/apiserver/plane/db/migrations/0061_alter_issuelink_url.pynew file mode 100644index 0000000000..1aca84a800--- /dev/null+++ b/apiserver/plane/db/migrations/0061_alter_issuelink_url.py@@ -0,0 +1,18 @@+# Generated by Django 4.2.7 on 2024-03-01 07:16++from django.db import migrations, models+++class Migration(migrations.Migration):++ dependencies = [+ ('db', '0060_cycle_progress_snapshot'),+ ]++ operations = [+ migrations.AlterField(+ model_name='issuelink',+ name='url',+ field=models.TextField(),+ ),+ ]diff --git a/apiserver/plane/db/models/issue.py b/apiserver/plane/db/models/issue.pyindex d5ed4247a7..5bd0b33974 100644--- a/apiserver/plane/db/models/issue.py+++ b/apiserver/plane/db/models/issue.py@@ -320,7 +320,7 @@ class IssueAssignee(ProjectBaseModel):class IssueLink(ProjectBaseModel):title = models.CharField(max_length=255, null=True, blank=True)- url = models.URLField()+ url = models.TextField()issue = models.ForeignKey("db.Issue", on_delete=models.CASCADE, related_name="issue_link")