π₯π₯π₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.
TypeScript boardsbug-trackerdjangodockerganttissue-trackerjirajira-alternativekanbanlinearpostgresqlproduct-managementproject-managementproject-planningpythonreactredistypesciptvitework-management
Make quick action dropdowns use capture phase of the event to trigger closure on outside click (#5414)
rahulramesha890379b64fa6
diff --git a/packages/ui/src/dropdowns/custom-menu.tsx b/packages/ui/src/dropdowns/custom-menu.tsxindex 00e8c3e2a6..0059e64983 100644--- a/packages/ui/src/dropdowns/custom-menu.tsx+++ b/packages/ui/src/dropdowns/custom-menu.tsx@@ -35,6 +35,7 @@ const CustomMenu = (props: ICustomMenuDropdownProps) => {tabIndex,closeOnSelect,openOnHover = false,+ useCaptureForOutsideClick = false,} = props;const [referenceElement, setReferenceElement] = React.useState<HTMLButtonElement | null>(null);@@ -88,7 +89,7 @@ const CustomMenu = (props: ICustomMenuDropdownProps) => {}};- useOutsideClickDetector(dropdownRef, closeDropdown);+ useOutsideClickDetector(dropdownRef, closeDropdown, useCaptureForOutsideClick);let menuItems = (<Menu.Items className={cn("fixed z-10", menuItemsClassName)} static>diff --git a/packages/ui/src/dropdowns/helper.tsx b/packages/ui/src/dropdowns/helper.tsxindex 8566f183b2..56963cbf4b 100644--- a/packages/ui/src/dropdowns/helper.tsx+++ b/packages/ui/src/dropdowns/helper.tsx@@ -17,6 +17,7 @@ export interface IDropdownProps {optionsClassName?: string;placement?: Placement;tabIndex?: number;+ useCaptureForOutsideClick?: boolean;}export interface ICustomMenuDropdownProps extends IDropdownProps {diff --git a/packages/ui/src/hooks/use-outside-click-detector.tsx b/packages/ui/src/hooks/use-outside-click-detector.tsxindex c1a4778037..608b88df0a 100644--- a/packages/ui/src/hooks/use-outside-click-detector.tsx+++ b/packages/ui/src/hooks/use-outside-click-detector.tsx@@ -1,7 +1,7 @@import React, { useEffect } from "react";// TODO: move it to helpers package-const useOutsideClickDetector = (ref: React.RefObject<HTMLElement>, callback: () => void) => {+const useOutsideClickDetector = (ref: React.RefObject<HTMLElement>, callback: () => void, useCapture = false) => {const handleClick = (event: MouseEvent) => {if (ref.current && !ref.current.contains(event.target as Node)) {// get all the element with attribute name data-prevent-outside-click@@ -31,10 +31,10 @@ const useOutsideClickDetector = (ref: React.RefObject<HTMLElement>, callback: ()};useEffect(() => {- document.addEventListener("mousedown", handleClick);+ document.addEventListener("mousedown", handleClick, useCapture);return () => {- document.removeEventListener("mousedown", handleClick);+ document.removeEventListener("mousedown", handleClick, useCapture);};});};diff --git a/web/core/components/issues/issue-layouts/quick-action-dropdowns/all-issue.tsx b/web/core/components/issues/issue-layouts/quick-action-dropdowns/all-issue.tsxindex 2c12ed18be..9ecbe44d0f 100644--- a/web/core/components/issues/issue-layouts/quick-action-dropdowns/all-issue.tsx+++ b/web/core/components/issues/issue-layouts/quick-action-dropdowns/all-issue.tsx@@ -163,6 +163,7 @@ export const AllIssueQuickActions: React.FC<IQuickActionProps> = observer((propsplacement={placements}menuItemsClassName="z-[14]"maxHeight="lg"+ useCaptureForOutsideClickcloseOnSelect>{MENU_ITEMS.map((item) => {diff --git a/web/core/components/issues/issue-layouts/quick-action-dropdowns/archived-issue.tsx b/web/core/components/issues/issue-layouts/quick-action-dropdowns/archived-issue.tsxindex 2134da80f2..ece43e585e 100644--- a/web/core/components/issues/issue-layouts/quick-action-dropdowns/archived-issue.tsx+++ b/web/core/components/issues/issue-layouts/quick-action-dropdowns/archived-issue.tsx@@ -125,6 +125,7 @@ export const ArchivedIssueQuickActions: React.FC<IQuickActionProps> = observer((placement={placements}menuItemsClassName="z-[14]"maxHeight="lg"+ useCaptureForOutsideClickcloseOnSelect>{MENU_ITEMS.map((item) => {diff --git a/web/core/components/issues/issue-layouts/quick-action-dropdowns/cycle-issue.tsx b/web/core/components/issues/issue-layouts/quick-action-dropdowns/cycle-issue.tsxindex 6e5187b64b..2a08bac9d1 100644--- a/web/core/components/issues/issue-layouts/quick-action-dropdowns/cycle-issue.tsx+++ b/web/core/components/issues/issue-layouts/quick-action-dropdowns/cycle-issue.tsx@@ -183,6 +183,7 @@ export const CycleIssueQuickActions: React.FC<IQuickActionProps> = observer((proportalElement={portalElement}menuItemsClassName="z-[14]"maxHeight="lg"+ useCaptureForOutsideClickcloseOnSelect>{MENU_ITEMS.map((item) => {diff --git a/web/core/components/issues/issue-layouts/quick-action-dropdowns/draft-issue.tsx b/web/core/components/issues/issue-layouts/quick-action-dropdowns/draft-issue.tsxindex cdf5c4bc6a..58807aee24 100644--- a/web/core/components/issues/issue-layouts/quick-action-dropdowns/draft-issue.tsx+++ b/web/core/components/issues/issue-layouts/quick-action-dropdowns/draft-issue.tsx@@ -115,6 +115,7 @@ export const DraftIssueQuickActions: React.FC<IQuickActionProps> = observer((proplacement={placements}menuItemsClassName="z-[14]"maxHeight="lg"+ useCaptureForOutsideClickcloseOnSelect>{MENU_ITEMS.map((item) => {diff --git a/web/core/components/issues/issue-layouts/quick-action-dropdowns/module-issue.tsx b/web/core/components/issues/issue-layouts/quick-action-dropdowns/module-issue.tsxindex 1bfa57d06a..8ec30042b7 100644--- a/web/core/components/issues/issue-layouts/quick-action-dropdowns/module-issue.tsx+++ b/web/core/components/issues/issue-layouts/quick-action-dropdowns/module-issue.tsx@@ -180,6 +180,7 @@ export const ModuleIssueQuickActions: React.FC<IQuickActionProps> = observer((prportalElement={portalElement}menuItemsClassName="z-[14]"maxHeight="lg"+ useCaptureForOutsideClickcloseOnSelect>{MENU_ITEMS.map((item) => {diff --git a/web/core/components/issues/issue-layouts/quick-action-dropdowns/project-issue.tsx b/web/core/components/issues/issue-layouts/quick-action-dropdowns/project-issue.tsxindex c47d76af77..40b53090be 100644--- a/web/core/components/issues/issue-layouts/quick-action-dropdowns/project-issue.tsx+++ b/web/core/components/issues/issue-layouts/quick-action-dropdowns/project-issue.tsx@@ -174,6 +174,7 @@ export const ProjectIssueQuickActions: React.FC<IQuickActionProps> = observer((pportalElement={portalElement}menuItemsClassName="z-[14]"maxHeight="lg"+ useCaptureForOutsideClickcloseOnSelect>{MENU_ITEMS.map((item) => {