π₯π₯π₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.
TypeScript boardsbug-trackerdjangodockerganttissue-trackerjirajira-alternativekanbanlinearpostgresqlproduct-managementproject-managementproject-planningpythonreactredistypesciptvitework-management
fix: dropdowns should close on tab key (#4351)
Aaryan Khandelwal8cf426021931
diff --git a/web/hooks/use-dropdown-key-down.tsx b/web/hooks/use-dropdown-key-down.tsxindex 174cfdd8ae..cc69906ce0 100644--- a/web/hooks/use-dropdown-key-down.tsx+++ b/web/hooks/use-dropdown-key-down.tsx@@ -9,23 +9,25 @@ type TUseDropdownKeyDown = {};export const useDropdownKeyDown: TUseDropdownKeyDown = (onEnterKeyDown, onEscKeyDown, stopPropagation = true) => {- const stopEventPropagation = (event: React.KeyboardEvent<HTMLElement>) => {- if (stopPropagation) {- event.stopPropagation();- event.preventDefault();- }- };+ const stopEventPropagation = useCallback(+ (event: React.KeyboardEvent<HTMLElement>) => {+ if (stopPropagation) {+ event.stopPropagation();+ event.preventDefault();+ }+ },+ [stopPropagation]+ );const handleKeyDown = useCallback((event: React.KeyboardEvent<HTMLElement>) => {if (event.key === "Enter") {stopEventPropagation(event);-onEnterKeyDown();} else if (event.key === "Escape") {stopEventPropagation(event);onEscKeyDown();- }+ } else if (event.key === "Tab") onEscKeyDown();},[onEnterKeyDown, onEscKeyDown, stopEventPropagation]);