Skip to content

armgit / plane

Public Imported from GitHub
0

πŸ”₯πŸ”₯πŸ”₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.

fix(api): scope cross-workspace resource lookups to prevent IDOR (#9008)

sriram veeraghanta9491bdbe46e2
diff --git a/apps/api/plane/app/views/estimate/base.py b/apps/api/plane/app/views/estimate/base.py
index 4bdc86633d..46d5f7a6b6 100644
--- a/apps/api/plane/app/views/estimate/base.py
+++ b/apps/api/plane/app/views/estimate/base.py
@@ -113,7 +113,7 @@ class BulkEstimatePointEndpoint(BaseViewSet):
status=status.HTTP_400_BAD_REQUEST,
)
- estimate = Estimate.objects.get(pk=estimate_id)
+ estimate = Estimate.objects.get(pk=estimate_id, workspace__slug=slug, project_id=project_id)
if request.data.get("estimate"):
estimate.name = request.data.get("estimate").get("name", estimate.name)
diff --git a/apps/api/plane/app/views/project/base.py b/apps/api/plane/app/views/project/base.py
index 0a7378c076..57489943fe 100644
--- a/apps/api/plane/app/views/project/base.py
+++ b/apps/api/plane/app/views/project/base.py
@@ -332,7 +332,7 @@ class ProjectViewSet(BaseViewSet):
workspace = Workspace.objects.get(slug=slug)
- project = Project.objects.get(pk=pk)
+ project = Project.objects.get(pk=pk, workspace__slug=slug)
intake_view = request.data.get("inbox_view", project.intake_view)
current_instance = json.dumps(ProjectSerializer(project).data, cls=DjangoJSONEncoder)
if project.archived_at:
diff --git a/apps/api/plane/app/views/workspace/user.py b/apps/api/plane/app/views/workspace/user.py
index b60ae5e15e..5b028a32ff 100644
--- a/apps/api/plane/app/views/workspace/user.py
+++ b/apps/api/plane/app/views/workspace/user.py
@@ -279,11 +279,16 @@ class WorkspaceUserPropertiesEndpoint(BaseAPIView):
class WorkspaceUserProfileEndpoint(BaseAPIView):
def get(self, request, slug, user_id):
- user_data = User.objects.get(pk=user_id)
-
requesting_workspace_member = WorkspaceMember.objects.get(
workspace__slug=slug, member=request.user, is_active=True
)
+
+ # Verify the target user is also an active member of this workspace
+ # before exposing their profile data.
+ target_workspace_member = WorkspaceMember.objects.select_related("member").get(
+ workspace__slug=slug, member_id=user_id, is_active=True
+ )
+ user_data = target_workspace_member.member
projects = []
if requesting_workspace_member.role >= 15:
projects = (