Skip to content

armgit / plane

Public Imported from GitHub
0

πŸ”₯πŸ”₯πŸ”₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.

[WIKI-391] chore: handle deactivated user display name in version history #7171

Aaryan Khandelwal950fcfdb4046
diff --git a/web/core/components/core/description-versions/dropdown-item.tsx b/web/core/components/core/description-versions/dropdown-item.tsx
index 11682c2064..6e5b3b491e 100644
--- a/web/core/components/core/description-versions/dropdown-item.tsx
+++ b/web/core/components/core/description-versions/dropdown-item.tsx
@@ -31,7 +31,7 @@ export const DescriptionVersionsDropdownItem: React.FC<Props> = observer((props)
/>
</span>
<p className="text-xs text-custom-text-200 flex items-center gap-1.5">
- <span className="font-medium">{versionCreator?.display_name}</span>
+ <span className="font-medium">{versionCreator?.display_name ?? t("common.deactivated_user")}</span>
<span>{calculateTimeAgo(version.last_saved_at)}</span>
</p>
</CustomMenu.MenuItem>
diff --git a/web/core/components/core/description-versions/dropdown.tsx b/web/core/components/core/description-versions/dropdown.tsx
index 098498500b..39e9f70338 100644
--- a/web/core/components/core/description-versions/dropdown.tsx
+++ b/web/core/components/core/description-versions/dropdown.tsx
@@ -40,7 +40,8 @@ export const DescriptionVersionsDropdown: React.FC<Props> = observer((props) =>
</span>
<p className="text-xs">
{t("description_versions.last_edited_by")}{" "}
- <span className="font-medium">{lastUpdatedByUserDisplayName}</span> {calculateTimeAgo(lastUpdatedAt)}
+ <span className="font-medium">{lastUpdatedByUserDisplayName ?? t("common.deactivated_user")}</span>{" "}
+ {calculateTimeAgo(lastUpdatedAt)}
</p>
</div>
}
diff --git a/web/core/components/pages/version/sidebar-list-item.tsx b/web/core/components/pages/version/sidebar-list-item.tsx
index be11f57250..5459bc1663 100644
--- a/web/core/components/pages/version/sidebar-list-item.tsx
+++ b/web/core/components/pages/version/sidebar-list-item.tsx
@@ -1,8 +1,8 @@
import { observer } from "mobx-react";
import Link from "next/link";
-// plane types
+// plane imports
+import { useTranslation } from "@plane/i18n";
import { TPageVersion } from "@plane/types";
-// plane ui
import { Avatar } from "@plane/ui";
// helpers
import { cn } from "@/helpers/common.helper";
@@ -23,6 +23,8 @@ export const PlaneVersionsSidebarListItem: React.FC<Props> = observer((props) =>
const { getUserDetails } = useMember();
// derived values
const ownerDetails = getUserDetails(version.owned_by);
+ // translation
+ const { t } = useTranslation();
return (
<Link
@@ -42,7 +44,7 @@ export const PlaneVersionsSidebarListItem: React.FC<Props> = observer((props) =>
size="sm"
className="flex-shrink-0"
/>
- <span className="text-custom-text-300">{ownerDetails?.display_name}</span>
+ <span className="text-custom-text-300">{ownerDetails?.display_name ?? t("common.deactivated_user")}</span>
</p>
</Link>
);