Skip to content

armgit / plane

Public Imported from GitHub
0

πŸ”₯πŸ”₯πŸ”₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.

[WEB-7887] fix(security): prevent stored XSS via SVG attachment served inline (GHSA-ch8j-vr4r-qf6h) (#9312)

Manish Gupta9dff20e04808
diff --git a/apps/api/plane/api/views/asset.py b/apps/api/plane/api/views/asset.py
index 7af1d13d24..abfa6bdc0d 100644
--- a/apps/api/plane/api/views/asset.py
+++ b/apps/api/plane/api/views/asset.py
@@ -444,10 +444,19 @@ class GenericAssetEndpoint(BaseAPIView):
status=status.HTTP_400_BAD_REQUEST,
)
- # Generate presigned URL for GET
+ # Generate presigned URL for GET.
+ # Force attachment disposition for script-capable MIME types (e.g. SVG)
+ # to prevent same-origin XSS when the asset URL shares the app's origin
+ # (default MinIO self-hosted setup).
storage = S3Storage(request=request, is_server=True)
+ asset_mime_type = (asset.attributes.get("type") or "").split(";")[0].strip().lower()
+ disposition = (
+ "attachment" if asset_mime_type in settings.SCRIPT_CAPABLE_MIME_TYPES else "inline"
+ )
presigned_url = storage.generate_presigned_url(
- object_name=asset.asset.name, filename=asset.attributes.get("name")
+ object_name=asset.asset.name,
+ filename=asset.attributes.get("name"),
+ disposition=disposition,
)
return Response(
diff --git a/apps/api/plane/app/views/asset/v2.py b/apps/api/plane/app/views/asset/v2.py
index 8441364f58..3664b4ec60 100644
--- a/apps/api/plane/app/views/asset/v2.py
+++ b/apps/api/plane/app/views/asset/v2.py
@@ -473,10 +473,19 @@ class StaticFileAssetEndpoint(BaseAPIView):
status=status.HTTP_400_BAD_REQUEST,
)
- # Get the presigned URL
+ # Get the presigned URL.
+ # Force attachment disposition for script-capable MIME types to prevent
+ # same-origin XSS when assets are served on the application's origin.
storage = S3Storage(request=request)
+ asset_mime_type = (asset.attributes.get("type") or "").split(";")[0].strip().lower()
+ disposition = (
+ "attachment" if asset_mime_type in settings.SCRIPT_CAPABLE_MIME_TYPES else "inline"
+ )
# Generate a presigned URL to share an S3 object
- signed_url = storage.generate_presigned_url(object_name=asset.asset.name)
+ signed_url = storage.generate_presigned_url(
+ object_name=asset.asset.name,
+ disposition=disposition,
+ )
# Redirect to the signed URL
return HttpResponseRedirect(signed_url)
diff --git a/apps/api/plane/settings/common.py b/apps/api/plane/settings/common.py
index be444794f2..25a212e763 100644
--- a/apps/api/plane/settings/common.py
+++ b/apps/api/plane/settings/common.py
@@ -544,6 +544,21 @@ ATTACHMENT_MIME_TYPES = [
"text/markdown",
]
+# MIME types that browsers can execute as scripts when served inline.
+# These must always be served with Content-Disposition: attachment, even if they
+# somehow end up stored (e.g. uploaded before this restriction was added).
+SCRIPT_CAPABLE_MIME_TYPES: frozenset[str] = frozenset(
+ [
+ "image/svg+xml", # SVG with onload / embedded <script> tags
+ "text/javascript",
+ "application/javascript",
+ "text/html",
+ "application/xhtml+xml",
+ "text/xml",
+ "application/xml",
+ ]
+)
+
# Seed directory path
SEED_DIR = os.path.join(BASE_DIR, "seeds")
diff --git a/apps/api/plane/space/views/asset.py b/apps/api/plane/space/views/asset.py
index 5220202fef..0b0b54ecc6 100644
--- a/apps/api/plane/space/views/asset.py
+++ b/apps/api/plane/space/views/asset.py
@@ -60,10 +60,19 @@ class EntityAssetEndpoint(BaseAPIView):
status=status.HTTP_404_NOT_FOUND,
)
- # Get the presigned URL
+ # Get the presigned URL.
+ # Force attachment disposition for script-capable MIME types to prevent
+ # same-origin XSS when Spaces assets are served on the application's origin.
storage = S3Storage(request=request)
+ asset_mime_type = (asset.attributes.get("type") or "").split(";")[0].strip().lower()
+ disposition = (
+ "attachment" if asset_mime_type in settings.SCRIPT_CAPABLE_MIME_TYPES else "inline"
+ )
# Generate a presigned URL to share an S3 object
- signed_url = storage.generate_presigned_url(object_name=asset.asset.name)
+ signed_url = storage.generate_presigned_url(
+ object_name=asset.asset.name,
+ disposition=disposition,
+ )
# Redirect to the signed URL
return HttpResponseRedirect(signed_url)