Skip to content

armgit / plane

Public Imported from GitHub
0

πŸ”₯πŸ”₯πŸ”₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.

[WEB-859] [WEB-1162] chore: issue detail improvement and assignees filter fix (#4342)

Anmol Singh Bhatiaa678844073b9
diff --git a/packages/types/src/inbox.d.ts b/packages/types/src/inbox.d.ts
index 01a1dfce3a..0f0b93e4fb 100644
--- a/packages/types/src/inbox.d.ts
+++ b/packages/types/src/inbox.d.ts
@@ -20,7 +20,7 @@ export type TInboxIssueCurrentTab = EInboxIssueCurrentTab;
export type TInboxIssueStatus = EInboxIssueStatus;
// filters
-export type TInboxIssueFilterMemberKeys = "assignee" | "created_by";
+export type TInboxIssueFilterMemberKeys = "assignees" | "created_by";
export type TInboxIssueFilterDateKeys = "created_at" | "updated_at";
diff --git a/web/components/inbox/content/issue-properties.tsx b/web/components/inbox/content/issue-properties.tsx
index 89ddbdef7a..4ec9bb14da 100644
--- a/web/components/inbox/content/issue-properties.tsx
+++ b/web/components/inbox/content/issue-properties.tsx
@@ -31,6 +31,7 @@ export const InboxIssueContentProperties: React.FC<Props> = observer((props) =>
const minDate = issue.start_date ? getDate(issue.start_date) : null;
minDate?.setDate(minDate.getDate());
if (!issue || !issue?.id) return <></>;
+
return (
<div className="flex h-min w-full flex-col divide-y-2 divide-custom-border-200 overflow-hidden">
<div className="h-min w-full overflow-y-auto px-3">
diff --git a/web/components/inbox/inbox-filter/applied-filters/member.tsx b/web/components/inbox/inbox-filter/applied-filters/member.tsx
index 5d488a23c4..b234d3c57d 100644
--- a/web/components/inbox/inbox-filter/applied-filters/member.tsx
+++ b/web/components/inbox/inbox-filter/applied-filters/member.tsx
@@ -34,8 +34,8 @@ export const InboxIssueAppliedFiltersMember: FC<InboxIssueAppliedFiltersMember>
if (!optionDetail) return <></>;
return (
<div key={value} className="relative flex items-center gap-1 rounded bg-custom-background-80 p-1 text-xs">
- <div className="w-3 h-3 flex-shrink-0 relative flex justify-center items-center overflow-hidden">
- <Avatar name={optionDetail.display_name} src={optionDetail.avatar} showTooltip={false} size="md" />
+ <div className="flex-shrink-0 relative flex justify-center items-center overflow-hidden">
+ <Avatar name={optionDetail.display_name} src={optionDetail.avatar} showTooltip={false} size="sm" />
</div>
<div className="text-xs truncate">{optionDetail?.display_name}</div>
<div
diff --git a/web/components/inbox/inbox-filter/applied-filters/root.tsx b/web/components/inbox/inbox-filter/applied-filters/root.tsx
index 77b29deca9..834d6a22c5 100644
--- a/web/components/inbox/inbox-filter/applied-filters/root.tsx
+++ b/web/components/inbox/inbox-filter/applied-filters/root.tsx
@@ -25,7 +25,7 @@ export const InboxIssueAppliedFilters: FC = observer(() => {
{/* priority */}
<InboxIssueAppliedFiltersPriority />
{/* assignees */}
- <InboxIssueAppliedFiltersMember filterKey="assignee" label="Assignee" />
+ <InboxIssueAppliedFiltersMember filterKey="assignees" label="Assignees" />
{/* created_by */}
<InboxIssueAppliedFiltersMember filterKey="created_by" label="Created By" />
{/* label */}
diff --git a/web/components/inbox/inbox-filter/filters/filter-selection.tsx b/web/components/inbox/inbox-filter/filters/filter-selection.tsx
index fd1dc951c8..1d7ddd0edf 100644
--- a/web/components/inbox/inbox-filter/filters/filter-selection.tsx
+++ b/web/components/inbox/inbox-filter/filters/filter-selection.tsx
@@ -60,8 +60,8 @@ export const InboxIssueFilterSelection: FC = observer(() => {
{/* assignees */}
<div className="py-2">
<FilterMember
- filterKey="assignee"
- label="Assignee"
+ filterKey="assignees"
+ label="Assignees"
searchQuery={filtersSearchQuery}
memberIds={projectMemberIds ?? []}
/>
diff --git a/web/components/issues/issue-detail/sidebar.tsx b/web/components/issues/issue-detail/sidebar.tsx
index 60221f4c26..74be38f02d 100644
--- a/web/components/issues/issue-detail/sidebar.tsx
+++ b/web/components/issues/issue-detail/sidebar.tsx
@@ -13,7 +13,6 @@ import {
CopyPlus,
CalendarClock,
CalendarCheck2,
- UserCircle2,
} from "lucide-react";
// hooks
// components
@@ -37,7 +36,6 @@ import {
} from "@/components/dropdowns";
// ui
// helpers
-import { ButtonAvatars } from "@/components/dropdowns/member/avatar";
import {
DeleteIssueModal,
IssueLinkRoot,
@@ -56,7 +54,7 @@ import { getDate, renderFormattedPayloadDate } from "@/helpers/date-time.helper"
import { shouldHighlightIssueDueDate } from "@/helpers/issue.helper";
import { copyTextToClipboard } from "@/helpers/string.helper";
// types
-import { useEstimate, useIssueDetail, useMember, useProject, useProjectState, useUser } from "@/hooks/store";
+import { useEstimate, useIssueDetail, useProject, useProjectState, useUser } from "@/hooks/store";
import { usePlatformOS } from "@/hooks/use-platform-os";
// components
import type { TIssueOperations } from "./root";
@@ -90,12 +88,9 @@ export const IssueDetailsSidebar: React.FC<Props> = observer((props) => {
} = useIssueDetail();
const { getStateById } = useProjectState();
const { isMobile } = usePlatformOS();
- const { getUserDetails } = useMember();
const issue = getIssueById(issueId);
if (!issue) return <></>;
- const createdByDetails = getUserDetails(issue.created_by);
-
const handleCopyText = () => {
const originURL = typeof window !== "undefined" && window.location.origin ? window.location.origin : "";
copyTextToClipboard(`${originURL}/${workspaceSlug}/projects/${projectId}/issues/${issue.id}`).then(() => {
@@ -262,21 +257,6 @@ export const IssueDetailsSidebar: React.FC<Props> = observer((props) => {
/>
</div>
- {createdByDetails && (
- <div className="flex h-8 items-center gap-2">
- <div className="flex w-2/5 flex-shrink-0 items-center gap-1 text-sm text-custom-text-300">
- <UserCircle2 className="h-4 w-4 flex-shrink-0" />
- <span>Created by</span>
- </div>
- <Tooltip tooltipContent={createdByDetails?.display_name} isMobile={isMobile}>
- <div className="h-full flex items-center gap-1.5 rounded px-2 py-0.5 text-sm justify-between cursor-default">
- <ButtonAvatars showTooltip={false} userIds={createdByDetails.id} />
- <span className="flex-grow truncate text-xs leading-5">{createdByDetails?.display_name}</span>
- </div>
- </Tooltip>
- </div>
- )}
-
<div className="flex h-8 items-center gap-2">
<div className="flex w-2/5 flex-shrink-0 items-center gap-1 text-sm text-custom-text-300">
<CalendarClock className="h-4 w-4 flex-shrink-0" />
diff --git a/web/components/issues/peek-overview/properties.tsx b/web/components/issues/peek-overview/properties.tsx
index 2564918b78..00ffa9100c 100644
--- a/web/components/issues/peek-overview/properties.tsx
+++ b/web/components/issues/peek-overview/properties.tsx
@@ -10,11 +10,10 @@ import {
XCircle,
CalendarClock,
CalendarCheck2,
- UserCircle2,
} from "lucide-react";
// hooks
// ui icons
-import { DiceIcon, DoubleCircleIcon, UserGroupIcon, ContrastIcon, RelatedIcon, Tooltip } from "@plane/ui";
+import { DiceIcon, DoubleCircleIcon, UserGroupIcon, ContrastIcon, RelatedIcon } from "@plane/ui";
// components
import {
DateDropdown,
@@ -23,7 +22,6 @@ import {
MemberDropdown,
StateDropdown,
} from "@/components/dropdowns";
-import { ButtonAvatars } from "@/components/dropdowns/member/avatar";
import {
IssueLinkRoot,
IssueCycleSelect,
@@ -37,8 +35,7 @@ import {
import { cn } from "@/helpers/common.helper";
import { getDate, renderFormattedPayloadDate } from "@/helpers/date-time.helper";
import { shouldHighlightIssueDueDate } from "@/helpers/issue.helper";
-import { useIssueDetail, useMember, useProject, useProjectState } from "@/hooks/store";
-import { usePlatformOS } from "@/hooks/use-platform-os";
+import { useIssueDetail, useProject, useProjectState } from "@/hooks/store";
interface IPeekOverviewProperties {
workspaceSlug: string;
@@ -56,12 +53,9 @@ export const PeekOverviewProperties: FC<IPeekOverviewProperties> = observer((pro
issue: { getIssueById },
} = useIssueDetail();
const { getStateById } = useProjectState();
- const { getUserDetails } = useMember();
- const { isMobile } = usePlatformOS();
// derived values
const issue = getIssueById(issueId);
if (!issue) return <></>;
- const createdByDetails = getUserDetails(issue?.created_by);
const projectDetails = getProjectById(issue.project_id);
const isEstimateEnabled = projectDetails?.estimate;
const stateDetails = getStateById(issue.state_id);
@@ -137,22 +131,6 @@ export const PeekOverviewProperties: FC<IPeekOverviewProperties> = observer((pro
/>
</div>
- {/* created by */}
- {createdByDetails && (
- <div className="flex w-full items-center gap-3 h-8">
- <div className="flex items-center gap-1 w-1/4 flex-shrink-0 text-sm text-custom-text-300">
- <UserCircle2 className="h-4 w-4 flex-shrink-0" />
- <span>Created by</span>
- </div>
- <Tooltip tooltipContent={createdByDetails?.display_name} isMobile={isMobile}>
- <div className="h-full flex items-center gap-1.5 rounded px-2 py-0.5 text-sm justify-between cursor-default">
- <ButtonAvatars showTooltip={false} userIds={createdByDetails?.id} />
- <span className="flex-grow truncate text-xs leading-5">{createdByDetails?.display_name}</span>
- </div>
- </Tooltip>
- </div>
- )}
-
{/* start date */}
<div className="flex w-full items-center gap-3 h-8">
<div className="flex items-center gap-1 w-1/4 flex-shrink-0 text-sm text-custom-text-300">