Skip to content

armgit / plane

Public Imported from GitHub
0

πŸ”₯πŸ”₯πŸ”₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.

[WIKI-713] fix: extra line created on enter key #7913

M. Palanikannana740a9f69dbd
diff --git a/packages/editor/src/core/extensions/mentions/mentions-list-dropdown.tsx b/packages/editor/src/core/extensions/mentions/mentions-list-dropdown.tsx
index 212d849f63..04257b15d5 100644
--- a/packages/editor/src/core/extensions/mentions/mentions-list-dropdown.tsx
+++ b/packages/editor/src/core/extensions/mentions/mentions-list-dropdown.tsx
@@ -48,12 +48,12 @@ export const MentionsListDropdown = forwardRef((props: MentionsListDropdownProps
useImperativeHandle(ref, () => ({
onKeyDown: ({ event }: { event: KeyboardEvent }) => {
- if (!DROPDOWN_NAVIGATION_KEYS.includes(event.key)) return;
+ if (!DROPDOWN_NAVIGATION_KEYS.includes(event.key)) return false;
event.preventDefault();
if (event.key === "Enter") {
selectItem(selectedIndex.section, selectedIndex.item);
- return;
+ return true;
}
const newIndex = getNextValidIndex({
@@ -64,6 +64,8 @@ export const MentionsListDropdown = forwardRef((props: MentionsListDropdownProps
if (newIndex) {
setSelectedIndex(newIndex);
}
+
+ return true;
},
}));
diff --git a/packages/editor/src/core/extensions/slash-commands/command-menu.tsx b/packages/editor/src/core/extensions/slash-commands/command-menu.tsx
index 56ad688bc1..640fb80781 100644
--- a/packages/editor/src/core/extensions/slash-commands/command-menu.tsx
+++ b/packages/editor/src/core/extensions/slash-commands/command-menu.tsx
@@ -90,12 +90,12 @@ export const SlashCommandsMenu = forwardRef((props: SlashCommandsMenuProps, ref)
useImperativeHandle(ref, () => ({
onKeyDown: ({ event }: { event: KeyboardEvent }) => {
- if (!DROPDOWN_NAVIGATION_KEYS.includes(event.key)) return;
+ if (!DROPDOWN_NAVIGATION_KEYS.includes(event.key)) return false;
event.preventDefault();
if (event.key === "Enter") {
selectItem(selectedIndex.section, selectedIndex.item);
- return;
+ return true;
}
const newIndex = getNextValidIndex({
@@ -103,9 +103,12 @@ export const SlashCommandsMenu = forwardRef((props: SlashCommandsMenuProps, ref)
sections,
selectedIndex,
});
+
if (newIndex) {
setSelectedIndex(newIndex);
}
+
+ return true;
},
}));