π₯π₯π₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.
TypeScript boardsbug-trackerdjangodockerganttissue-trackerjirajira-alternativekanbanlinearpostgresqlproduct-managementproject-managementproject-planningpythonreactredistypesciptvitework-management
[PE-232] chore: management of disabled extensions (#6317)
M. Palanikannana908bf9edddc
diff --git a/packages/editor/src/ce/extensions/document-extensions.tsx b/packages/editor/src/ce/extensions/document-extensions.tsxindex 35d7c0f3de..445f5e0f80 100644--- a/packages/editor/src/ce/extensions/document-extensions.tsx+++ b/packages/editor/src/ce/extensions/document-extensions.tsx@@ -1,5 +1,6 @@import { HocuspocusProvider } from "@hocuspocus/provider";import { Extensions } from "@tiptap/core";+import { AnyExtension } from "@tiptap/core";import { SlashCommands } from "@/extensions";// plane editor typesimport { TIssueEmbedConfig } from "@/plane-editor/types";@@ -13,15 +14,24 @@ type Props = {userDetails: TUserDetails;};+type ExtensionConfig = {+ isEnabled: (disabledExtensions: TExtensions[]) => boolean;+ getExtension: (props: Props) => AnyExtension;+};++const extensionRegistry: ExtensionConfig[] = [+ {+ isEnabled: (disabledExtensions) => !disabledExtensions.includes("slash-commands"),+ getExtension: () => SlashCommands({}),+ },+];+export const DocumentEditorAdditionalExtensions = (_props: Props) => {- const { disabledExtensions } = _props;- const extensions: Extensions = disabledExtensions?.includes("slash-commands")- ? []- : [- SlashCommands({- disabledExtensions,- }),- ];+ const { disabledExtensions = [] } = _props;++ const documentExtensions = extensionRegistry+ .filter((config) => config.isEnabled(disabledExtensions))+ .map((config) => config.getExtension(_props));- return extensions;+ return documentExtensions;};diff --git a/packages/editor/src/ce/extensions/slash-commands.tsx b/packages/editor/src/ce/extensions/slash-commands.tsxindex 6eabee0823..faefa74523 100644--- a/packages/editor/src/ce/extensions/slash-commands.tsx+++ b/packages/editor/src/ce/extensions/slash-commands.tsx@@ -4,7 +4,7 @@ import { TSlashCommandAdditionalOption } from "@/extensions";import { TExtensions } from "@/types";type Props = {- disabledExtensions: TExtensions[];+ disabledExtensions?: TExtensions[];};export const coreEditorAdditionalSlashCommandOptions = (props: Props): TSlashCommandAdditionalOption[] => {diff --git a/packages/editor/src/core/extensions/slash-commands/command-items-list.tsx b/packages/editor/src/core/extensions/slash-commands/command-items-list.tsxindex 1efb729019..034d3d8978 100644--- a/packages/editor/src/core/extensions/slash-commands/command-items-list.tsx+++ b/packages/editor/src/core/extensions/slash-commands/command-items-list.tsx@@ -39,11 +39,11 @@ import {setText,} from "@/helpers/editor-commands";// types-import { CommandProps, ISlashCommandItem, TExtensions, TSlashCommandSectionKeys } from "@/types";+import { CommandProps, ISlashCommandItem, TSlashCommandSectionKeys } from "@/types";// plane editor extensionsimport { coreEditorAdditionalSlashCommandOptions } from "@/plane-editor/extensions";// local types-import { TSlashCommandAdditionalOption } from "./root";+import { TExtensionProps } from "./root";export type TSlashCommandSection = {key: TSlashCommandSectionKeys;@@ -51,13 +51,8 @@ export type TSlashCommandSection = {items: ISlashCommandItem[];};-type TArgs = {- additionalOptions?: TSlashCommandAdditionalOption[];- disabledExtensions: TExtensions[];-};-export const getSlashCommandFilteredSections =- (args: TArgs) =>+ (args: TExtensionProps) =>({ query }: { query: string }): TSlashCommandSection[] => {const { additionalOptions, disabledExtensions } = args;const SLASH_COMMAND_SECTIONS: TSlashCommandSection[] = [diff --git a/packages/editor/src/core/extensions/slash-commands/root.tsx b/packages/editor/src/core/extensions/slash-commands/root.tsxindex 5e12c997f0..28aaebb852 100644--- a/packages/editor/src/core/extensions/slash-commands/root.tsx+++ b/packages/editor/src/core/extensions/slash-commands/root.tsx@@ -103,9 +103,9 @@ const renderItems = () => {};};-type TExtensionProps = {+export type TExtensionProps = {additionalOptions?: TSlashCommandAdditionalOption[];- disabledExtensions: TExtensions[];+ disabledExtensions?: TExtensions[];};export const SlashCommands = (props: TExtensionProps) =>