π₯π₯π₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.
TypeScript boardsbug-trackerdjangodockerganttissue-trackerjirajira-alternativekanbanlinearpostgresqlproduct-managementproject-managementproject-planningpythonreactredistypesciptvitework-management
fix: enforce workspace membership on V2 asset endpoints (#8885)
sriram veeraghantaac11c3ef7939
diff --git a/apps/api/plane/app/views/asset/v2.py b/apps/api/plane/app/views/asset/v2.pyindex 62c5f84a20..a83c5ec998 100644--- a/apps/api/plane/app/views/asset/v2.py+++ b/apps/api/plane/app/views/asset/v2.py@@ -18,7 +18,7 @@ from rest_framework.permissions import AllowAny# Module importsfrom ..base import BaseAPIView-from plane.db.models import FileAsset, Workspace, Project, User+from plane.db.models import FileAsset, Workspace, Project, User, WorkspaceMemberfrom plane.settings.storage import S3Storagefrom plane.app.permissions import allow_permission, ROLEfrom plane.utils.cache import invalidate_cache_directly@@ -311,6 +311,7 @@ class WorkspaceFileAssetEndpoint(BaseAPIView):else:return+ @allow_permission([ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST], level="WORKSPACE")def post(self, request, slug):name = request.data.get("name")type = request.data.get("type", "image/jpeg")@@ -376,6 +377,7 @@ class WorkspaceFileAssetEndpoint(BaseAPIView):status=status.HTTP_200_OK,)+ @allow_permission([ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST], level="WORKSPACE")def patch(self, request, slug, asset_id):# get the asset idasset = FileAsset.objects.get(id=asset_id, workspace__slug=slug)@@ -397,6 +399,7 @@ class WorkspaceFileAssetEndpoint(BaseAPIView):asset.save(update_fields=["is_uploaded", "attributes"])return Response(status=status.HTTP_204_NO_CONTENT)+ @allow_permission([ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST], level="WORKSPACE")def delete(self, request, slug, asset_id):asset = FileAsset.objects.get(id=asset_id, workspace__slug=slug)asset.is_deleted = True@@ -406,6 +409,7 @@ class WorkspaceFileAssetEndpoint(BaseAPIView):asset.save(update_fields=["is_deleted", "deleted_at"])return Response(status=status.HTTP_204_NO_CONTENT)+ @allow_permission([ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST], level="WORKSPACE")def get(self, request, slug, asset_id):# get the asset idasset = FileAsset.objects.get(id=asset_id, workspace__slug=slug)@@ -752,7 +756,16 @@ class DuplicateAssetEndpoint(BaseAPIView):return Response({"error": "Project not found"}, status=status.HTTP_404_NOT_FOUND)storage = S3Storage(request=request)- original_asset = FileAsset.objects.filter(id=asset_id, is_uploaded=True).first()+ # Scope the source asset lookup to workspaces the caller is a member of+ user_workspace_ids = WorkspaceMember.objects.filter(+ member=request.user,+ is_active=True,+ ).values_list("workspace_id", flat=True)+ original_asset = FileAsset.objects.filter(+ id=asset_id,+ is_uploaded=True,+ workspace_id__in=user_workspace_ids,+ ).first()if not original_asset:return Response({"error": "Asset not found"}, status=status.HTTP_404_NOT_FOUND)