π₯π₯π₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.
TypeScript boardsbug-trackerdjangodockerganttissue-trackerjirajira-alternativekanbanlinearpostgresqlproduct-managementproject-managementproject-planningpythonreactredistypesciptvitework-management
[RANTS-31] improvement: optimistic update for home widget reordering (#6817)
Prateek Shouryaaea5f39059f0
diff --git a/web/core/components/home/widgets/manage/widget-list.tsx b/web/core/components/home/widgets/manage/widget-list.tsxindex 85957d8cfa..ff7db11c2e 100644--- a/web/core/components/home/widgets/manage/widget-list.tsx+++ b/web/core/components/home/widgets/manage/widget-list.tsx@@ -29,20 +29,21 @@ export const WidgetList = observer(({ workspaceSlug }: { workspaceSlug: string }if (!sourceData.id) return;if (droppedId) {- try {- reorderWidget(workspaceSlug, sourceData.id, droppedId, instruction); /** sequence */- setToast({- type: TOAST_TYPE.SUCCESS,- title: t("toast.success"),- message: t("home.widget.reordered_successfully"),+ reorderWidget(workspaceSlug, sourceData.id, droppedId, instruction)+ .then(() => {+ setToast({+ type: TOAST_TYPE.SUCCESS,+ title: t("toast.success"),+ message: t("home.widget.reordered_successfully"),+ });+ })+ .catch(() => {+ setToast({+ type: TOAST_TYPE.ERROR,+ title: t("toast.error"),+ message: t("home.widget.reordering_failed"),+ });});- } catch {- setToast({- type: TOAST_TYPE.ERROR,- title: t("toast.error"),- message: t("home.widget.reordering_failed"),- });- }}};diff --git a/web/core/store/workspace/home.ts b/web/core/store/workspace/home.tsindex 023767ef3d..109132fb66 100644--- a/web/core/store/workspace/home.ts+++ b/web/core/store/workspace/home.ts@@ -1,3 +1,4 @@+import clone from "lodash/clone";import orderBy from "lodash/orderBy";import set from "lodash/set";import { action, computed, makeObservable, observable, runInAction } from "mobx";@@ -19,7 +20,7 @@ export interface IHomeStore {// actionstoggleWidgetSettings: (value?: boolean) => void;fetchWidgets: (workspaceSlug: string) => Promise<void>;- reorderWidget: (workspaceSlug: string, widgetKey: string, destinationId: string, edge: string | undefined) => void;+ reorderWidget: (workspaceSlug: string, widgetKey: string, destinationId: string, edge: string | undefined) => Promise<void>;toggleWidget: (workspaceSlug: string, widgetKey: string, is_enabled: boolean) => void;}@@ -102,6 +103,7 @@ export class HomeStore implements IHomeStore {};reorderWidget = async (workspaceSlug: string, widgetKey: string, destinationId: string, edge: string | undefined) => {+ const sortOrderBeforeUpdate = clone(this.widgetsMap[widgetKey]?.sort_order);try {let resultSequence = 10000;if (edge) {@@ -121,14 +123,17 @@ export class HomeStore implements IHomeStore {}}}- await this.workspaceService.updateWorkspaceWidget(workspaceSlug, widgetKey, {- sort_order: resultSequence,- });runInAction(() => {set(this.widgetsMap, [widgetKey, "sort_order"], resultSequence);});+ await this.workspaceService.updateWorkspaceWidget(workspaceSlug, widgetKey, {+ sort_order: resultSequence,+ });} catch (error) {console.error("Failed to move widget");+ runInAction(() => {+ set(this.widgetsMap, [widgetKey, "sort_order"], sortOrderBeforeUpdate);+ });throw error;}};