π₯π₯π₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.
TypeScript boardsbug-trackerdjangodockerganttissue-trackerjirajira-alternativekanbanlinearpostgresqlproduct-managementproject-managementproject-planningpythonreactredistypesciptvitework-management
fix: sanitize filenames in upload paths to prevent path traversal (#8879)
sriram veeraghantaaea66f53f402
diff --git a/apps/api/plane/api/views/asset.py b/apps/api/plane/api/views/asset.pyindex 88c34c37ca..72ce60e681 100644--- a/apps/api/plane/api/views/asset.py+++ b/apps/api/plane/api/views/asset.py@@ -17,6 +17,7 @@ from drf_spectacular.utils import OpenApiExample, OpenApiRequest# Module Importsfrom plane.bgtasks.storage_metadata_task import get_asset_object_metadatafrom plane.settings.storage import S3Storage+from plane.utils.path_validator import sanitize_filenamefrom plane.db.models import FileAsset, User, Workspacefrom plane.api.views.base import BaseAPIViewfrom plane.api.serializers import (@@ -114,7 +115,7 @@ class UserAssetEndpoint(BaseAPIView):This endpoint generates the necessary credentials for direct S3 upload."""# get the asset key- name = request.data.get("name")+ name = sanitize_filename(request.data.get("name")) or "unnamed"type = request.data.get("type", "image/jpeg")size = int(request.data.get("size", settings.FILE_SIZE_LIMIT))entity_type = request.data.get("entity_type", False)@@ -287,7 +288,7 @@ class UserServerAssetEndpoint(BaseAPIView):necessary credentials for direct S3 upload with server-side authentication."""# get the asset key- name = request.data.get("name")+ name = sanitize_filename(request.data.get("name")) or "unnamed"type = request.data.get("type", "image/jpeg")size = int(request.data.get("size", settings.FILE_SIZE_LIMIT))entity_type = request.data.get("entity_type", False)@@ -498,7 +499,7 @@ class GenericAssetEndpoint(BaseAPIView):Create a presigned URL for uploading generic assets that can be bound to entities like work items.Supports various file types and includes external source tracking for integrations."""- name = request.data.get("name")+ name = sanitize_filename(request.data.get("name"))type = request.data.get("type")size = int(request.data.get("size", settings.FILE_SIZE_LIMIT))project_id = request.data.get("project_id")diff --git a/apps/api/plane/api/views/issue.py b/apps/api/plane/api/views/issue.pyindex 180d684475..b48be56d41 100644--- a/apps/api/plane/api/views/issue.py+++ b/apps/api/plane/api/views/issue.py@@ -79,6 +79,7 @@ from plane.db.models import (Workspace,)from plane.settings.storage import S3Storage+from plane.utils.path_validator import sanitize_filenamefrom plane.bgtasks.storage_metadata_task import get_asset_object_metadatafrom .base import BaseAPIViewfrom plane.utils.host import base_host@@ -1858,7 +1859,7 @@ class IssueAttachmentListCreateAPIEndpoint(BaseAPIView):status=status.HTTP_403_FORBIDDEN,)- name = request.data.get("name")+ name = sanitize_filename(request.data.get("name"))type = request.data.get("type", False)size = request.data.get("size")external_id = request.data.get("external_id")diff --git a/apps/api/plane/app/views/asset/v2.py b/apps/api/plane/app/views/asset/v2.pyindex a83c5ec998..b21f70d61f 100644--- a/apps/api/plane/app/views/asset/v2.py+++ b/apps/api/plane/app/views/asset/v2.py@@ -22,6 +22,7 @@ from plane.db.models import FileAsset, Workspace, Project, User, WorkspaceMemberfrom plane.settings.storage import S3Storagefrom plane.app.permissions import allow_permission, ROLEfrom plane.utils.cache import invalidate_cache_directly+from plane.utils.path_validator import sanitize_filenamefrom plane.bgtasks.storage_metadata_task import get_asset_object_metadatafrom plane.throttles.asset import AssetRateThrottle@@ -108,7 +109,7 @@ class UserAssetsV2Endpoint(BaseAPIView):def post(self, request):# get the asset key- name = request.data.get("name")+ name = sanitize_filename(request.data.get("name")) or "unnamed"type = request.data.get("type", "image/jpeg")size = int(request.data.get("size", settings.FILE_SIZE_LIMIT))entity_type = request.data.get("entity_type", False)@@ -313,7 +314,7 @@ class WorkspaceFileAssetEndpoint(BaseAPIView):@allow_permission([ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST], level="WORKSPACE")def post(self, request, slug):- name = request.data.get("name")+ name = sanitize_filename(request.data.get("name")) or "unnamed"type = request.data.get("type", "image/jpeg")size = int(request.data.get("size", settings.FILE_SIZE_LIMIT))entity_type = request.data.get("entity_type")@@ -515,7 +516,7 @@ class ProjectAssetEndpoint(BaseAPIView):@allow_permission([ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST])def post(self, request, slug, project_id):- name = request.data.get("name")+ name = sanitize_filename(request.data.get("name")) or "unnamed"type = request.data.get("type", "image/jpeg")size = int(request.data.get("size", settings.FILE_SIZE_LIMIT))entity_type = request.data.get("entity_type", "")@@ -770,7 +771,8 @@ class DuplicateAssetEndpoint(BaseAPIView):if not original_asset:return Response({"error": "Asset not found"}, status=status.HTTP_404_NOT_FOUND)- destination_key = f"{workspace.id}/{uuid.uuid4().hex}-{original_asset.attributes.get('name')}"+ sanitized_name = sanitize_filename(original_asset.attributes.get("name")) or "unnamed"+ destination_key = f"{workspace.id}/{uuid.uuid4().hex}-{sanitized_name}"duplicated_asset = FileAsset.objects.create(attributes={"name": original_asset.attributes.get("name"),diff --git a/apps/api/plane/app/views/issue/attachment.py b/apps/api/plane/app/views/issue/attachment.pyindex df027c413b..51248b8a42 100644--- a/apps/api/plane/app/views/issue/attachment.py+++ b/apps/api/plane/app/views/issue/attachment.py@@ -24,6 +24,7 @@ from plane.db.models import FileAsset, Workspacefrom plane.bgtasks.issue_activities_task import issue_activityfrom plane.app.permissions import allow_permission, ROLEfrom plane.settings.storage import S3Storage+from plane.utils.path_validator import sanitize_filenamefrom plane.bgtasks.storage_metadata_task import get_asset_object_metadatafrom plane.utils.host import base_host@@ -97,7 +98,7 @@ class IssueAttachmentV2Endpoint(BaseAPIView):@allow_permission([ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST])def post(self, request, slug, project_id, issue_id):- name = request.data.get("name")+ name = sanitize_filename(request.data.get("name")) or "unnamed"type = request.data.get("type", False)size = int(request.data.get("size", settings.FILE_SIZE_LIMIT))diff --git a/apps/api/plane/db/models/asset.py b/apps/api/plane/db/models/asset.pyindex d309135bca..55efff7f41 100644--- a/apps/api/plane/db/models/asset.py+++ b/apps/api/plane/db/models/asset.py@@ -11,10 +11,13 @@ from django.core.exceptions import ValidationErrorfrom django.db import models# Module import+from plane.utils.path_validator import sanitize_filename+from .base import BaseModeldef get_upload_path(instance, filename):+ filename = sanitize_filename(filename) or uuid4().hexif instance.workspace_id is not None:return f"{instance.workspace.id}/{uuid4().hex}-{filename}"return f"user-{uuid4().hex}-{filename}"diff --git a/apps/api/plane/db/models/issue.py b/apps/api/plane/db/models/issue.pyindex d24efc8a23..f4175c4785 100644--- a/apps/api/plane/db/models/issue.py+++ b/apps/api/plane/db/models/issue.py@@ -17,6 +17,7 @@ from django import apps# Module importsfrom plane.utils.html_processor import strip_tags+from plane.utils.path_validator import sanitize_filenamefrom plane.db.mixins import SoftDeletionManagerfrom plane.utils.exception_logger import log_exceptionfrom .project import ProjectBaseModel@@ -376,6 +377,7 @@ class IssueLink(ProjectBaseModel):def get_upload_path(instance, filename):+ filename = sanitize_filename(filename) or uuid4().hexreturn f"{instance.workspace.id}/{uuid4().hex}-{filename}"diff --git a/apps/api/plane/space/views/asset.py b/apps/api/plane/space/views/asset.pyindex 1749a8fd46..bc20724ca8 100644--- a/apps/api/plane/space/views/asset.py+++ b/apps/api/plane/space/views/asset.py@@ -18,6 +18,7 @@ from rest_framework.response import Responsefrom plane.bgtasks.storage_metadata_task import get_asset_object_metadatafrom plane.db.models import DeployBoard, FileAssetfrom plane.settings.storage import S3Storage+from plane.utils.path_validator import sanitize_filename# Module importsfrom .base import BaseAPIView@@ -73,7 +74,7 @@ class EntityAssetEndpoint(BaseAPIView):return Response({"error": "Project is not published"}, status=status.HTTP_404_NOT_FOUND)# Get the asset- name = request.data.get("name")+ name = sanitize_filename(request.data.get("name")) or "unnamed"type = request.data.get("type", "image/jpeg")size = int(request.data.get("size", settings.FILE_SIZE_LIMIT))entity_type = request.data.get("entity_type", "")diff --git a/apps/api/plane/utils/path_validator.py b/apps/api/plane/utils/path_validator.pyindex f15fb4ca95..901464ee6a 100644--- a/apps/api/plane/utils/path_validator.py+++ b/apps/api/plane/utils/path_validator.py@@ -7,9 +7,50 @@ from django.utils.http import url_has_allowed_host_and_schemefrom django.conf import settings# Python imports+import osfrom urllib.parse import urlparse+def sanitize_filename(filename):+ """+ Sanitize a filename to prevent path traversal attacks.++ Strips directory components, path traversal sequences, and null bytes+ from user-supplied filenames used in upload paths and S3 object keys.++ Returns None for empty/missing input so callers can still validate+ that a filename was provided.+ """+ if not filename or not isinstance(filename, str):+ return None++ # Strip null bytes+ filename = filename.replace("\x00", "")++ # Normalize backslashes so os.path.basename handles Windows-style paths on POSIX+ filename = filename.replace("\\", "/")++ # Take only the basename to remove any directory components+ filename = os.path.basename(filename)++ # Remove any remaining path traversal sequences+ filename = filename.replace("..", "")++ # Strip whitespace before removing leading dots so " .env" is caught+ filename = filename.strip()++ # Remove leading dots (hidden files)+ filename = filename.lstrip(".")++ # Strip any remaining whitespace+ filename = filename.strip()++ if not filename:+ return None++ return filename++def _contains_suspicious_patterns(path: str) -> bool:"""Check for suspicious patterns that might indicate malicious intent.