Skip to content

armgit / plane

Public Imported from GitHub
0

πŸ”₯πŸ”₯πŸ”₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.

[WEB-1533] chore: fix alignment issues in List and Spreadsheet view (#4714)

rahulrameshab24e530816fe
diff --git a/web/components/issues/issue-layouts/list/block-root.tsx b/web/components/issues/issue-layouts/list/block-root.tsx
index 4be71acaf3..7825a5b183 100644
--- a/web/components/issues/issue-layouts/list/block-root.tsx
+++ b/web/components/issues/issue-layouts/list/block-root.tsx
@@ -154,7 +154,7 @@ export const IssueBlockRoot: FC<Props> = observer((props) => {
canEditProperties={canEditProperties}
displayProperties={displayProperties}
nestingLevel={nestingLevel + 1}
- spacingLeft={spacingLeft + (displayProperties?.key ? 12 : 0)}
+ spacingLeft={spacingLeft + 12}
containerRef={containerRef}
selectionHelpers={selectionHelpers}
groupId={groupId}
diff --git a/web/components/issues/issue-layouts/list/block.tsx b/web/components/issues/issue-layouts/list/block.tsx
index 358c721895..32b656745b 100644
--- a/web/components/issues/issue-layouts/list/block.tsx
+++ b/web/components/issues/issue-layouts/list/block.tsx
@@ -119,6 +119,9 @@ export const IssueBlock = observer((props: IssueBlockProps) => {
}
};
+ //TODO: add better logic. This is to have a min width for ID/Key based on the length of project identifier
+ const keyMinWidth = (projectIdentifier.length + 5) * 7;
+
return (
<div
ref={issueRef}
@@ -143,8 +146,8 @@ export const IssueBlock = observer((props: IssueBlockProps) => {
}}
>
<div className="flex w-full truncate">
- <div className="flex flex-grow items-center gap-1.5 truncate">
- <div className="flex items-center gap-2" style={isSubIssue ? { marginLeft } : {}}>
+ <div className="flex flex-grow items-center gap-0.5 truncate">
+ <div className="flex items-center gap-1" style={isSubIssue ? { marginLeft } : {}}>
{/* select checkbox */}
{projectId && canEditIssueProperties && (
<Tooltip
@@ -174,7 +177,10 @@ export const IssueBlock = observer((props: IssueBlockProps) => {
</Tooltip>
)}
{displayProperties && displayProperties?.key && (
- <div className="flex-shrink-0 text-xs font-medium text-custom-text-300">
+ <div
+ className="flex-shrink-0 text-xs font-medium text-custom-text-300 pl-2"
+ style={{ minWidth: `${keyMinWidth}px` }}
+ >
{projectIdentifier}-{issue.sequence_id}
</div>
)}
diff --git a/web/components/issues/issue-layouts/spreadsheet/issue-row.tsx b/web/components/issues/issue-layouts/spreadsheet/issue-row.tsx
index 771871bda5..1e5a2574ef 100644
--- a/web/components/issues/issue-layouts/spreadsheet/issue-row.tsx
+++ b/web/components/issues/issue-layouts/spreadsheet/issue-row.tsx
@@ -108,7 +108,7 @@ export const SpreadsheetIssueRow = observer((props: Props) => {
quickActions={quickActions}
canEditProperties={canEditProperties}
nestingLevel={nestingLevel + 1}
- spacingLeft={spacingLeft + (displayProperties.key ? 12 : 28)}
+ spacingLeft={spacingLeft + 12}
isEstimateEnabled={isEstimateEnabled}
updateIssue={updateIssue}
portalElement={portalElement}
@@ -187,7 +187,7 @@ const IssueRowDetails = observer((props: IssueRowDetailsProps) => {
const issueDetail = issue.getIssueById(issueId);
- const marginLeft = `${spacingLeft}px`;
+ const subIssueIndentation = `${spacingLeft}px`;
useOutsideClickDetector(menuActionRef, () => setIsMenuActive(false));
@@ -222,6 +222,9 @@ const IssueRowDetails = observer((props: IssueRowDetailsProps) => {
const subIssuesCount = issueDetail?.sub_issues_count ?? 0;
const isIssueSelected = selectionHelpers.getIsEntitySelected(issueDetail.id);
+ //TODO: add better logic. This is to have a min width for ID/Key based on the length of project identifier
+ const keyMinWidth = (getProjectIdentifierById(issueDetail.project_id)?.length + 5) * 7;
+
return (
<>
<td
@@ -245,7 +248,7 @@ const IssueRowDetails = observer((props: IssueRowDetailsProps) => {
)}
disabled={!!issueDetail?.tempId}
>
- <div className="flex items-center gap-1 min-w-min py-2.5 pl-2">
+ <div className="flex items-center gap-0.5 min-w-min py-2.5 pl-2">
{/* select checkbox */}
{projectId && !disableUserActions && (
<Tooltip
@@ -258,7 +261,7 @@ const IssueRowDetails = observer((props: IssueRowDetailsProps) => {
}
disabled={issueDetail.project_id === projectId}
>
- <div className="flex-shrink-0 grid place-items-center w-3.5">
+ <div className="flex-shrink-0 grid place-items-center w-3.5 mr-1">
<MultipleSelectEntityAction
className={cn(
"opacity-0 pointer-events-none group-hover/list-block:opacity-100 group-hover/list-block:pointer-events-auto transition-opacity",
@@ -274,8 +277,20 @@ const IssueRowDetails = observer((props: IssueRowDetailsProps) => {
</div>
</Tooltip>
)}
+
+ {/* sub issues indentation */}
+ <div style={nestingLevel !== 0 ? { width: subIssueIndentation } : {}} />
+
+ <WithDisplayPropertiesHOC displayProperties={displayProperties} displayPropertyKey="key">
+ <div className="relative flex cursor-pointer items-center text-center text-xs hover:text-custom-text-100">
+ <p className={`flex font-medium leading-7`} style={{ minWidth: `${keyMinWidth}px` }}>
+ {getProjectIdentifierById(issueDetail.project_id)}-{issueDetail.sequence_id}
+ </p>
+ </div>
+ </WithDisplayPropertiesHOC>
+
{/* sub-issues chevron */}
- <div className="grid place-items-center size-4" style={nestingLevel !== 0 ? { marginLeft } : {}}>
+ <div className="grid place-items-center size-4">
{subIssuesCount > 0 && (
<button
type="button"
@@ -291,22 +306,14 @@ const IssueRowDetails = observer((props: IssueRowDetailsProps) => {
</button>
)}
</div>
-
- <WithDisplayPropertiesHOC displayProperties={displayProperties} displayPropertyKey="key">
- <div className="relative flex cursor-pointer items-center text-center text-xs hover:text-custom-text-100">
- <p className={`flex items-center justify-center font-medium leading-7`}>
- {getProjectIdentifierById(issueDetail.project_id)}-{issueDetail.sequence_id}
- </p>
- </div>
- </WithDisplayPropertiesHOC>
</div>
- <div className="flex items-center gap-2 justify-between h-full w-full pr-4 truncate">
+ <div className="flex items-center gap-2 justify-between h-full w-full pr-4 pl-1 truncate">
<div className="w-full line-clamp-1 text-sm text-custom-text-100">
<div className="w-full overflow-hidden">
<Tooltip tooltipContent={issueDetail.name} isMobile={isMobile}>
<div
- className="h-full w-full cursor-pointer truncate px-4 text-left text-[0.825rem] text-custom-text-100 focus:outline-none"
+ className="h-full w-full cursor-pointer truncate pr-4 text-left text-[0.825rem] text-custom-text-100 focus:outline-none"
tabIndex={-1}
>
{issueDetail.name}
diff --git a/web/components/issues/issue-layouts/spreadsheet/spreadsheet-header.tsx b/web/components/issues/issue-layouts/spreadsheet/spreadsheet-header.tsx
index 9de9a68e7f..74f65db317 100644
--- a/web/components/issues/issue-layouts/spreadsheet/spreadsheet-header.tsx
+++ b/web/components/issues/issue-layouts/spreadsheet/spreadsheet-header.tsx
@@ -48,7 +48,7 @@ export const SpreadsheetHeader = observer((props: Props) => {
tabIndex={-1}
>
{canSelectIssues && (
- <div className="flex-shrink-0 flex items-center w-3.5">
+ <div className="flex-shrink-0 flex items-center w-3.5 mr-1">
<MultipleSelectGroupAction
className={cn(
"size-3.5 opacity-0 pointer-events-none group-hover/list-header:opacity-100 group-hover/list-header:pointer-events-auto !outline-none",
@@ -61,7 +61,6 @@ export const SpreadsheetHeader = observer((props: Props) => {
/>
</div>
)}
- <div className="size-4" />
<span className="flex h-full w-full flex-grow items-center py-2.5">Issues</span>
</th>