Skip to content

armgit / plane

Public Imported from GitHub
0

πŸ”₯πŸ”₯πŸ”₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.

[GIT-384] Fix voting on published work items with no votes (#10103)

Rahul Cheryalabc0b1bb66cd8
diff --git a/apps/space/store/issue-detail.store.ts b/apps/space/store/issue-detail.store.ts
index 6cbb6c867b..b410767aa4 100644
--- a/apps/space/store/issue-detail.store.ts
+++ b/apps/space/store/issue-detail.store.ts
@@ -402,7 +402,7 @@ export class IssueDetailStore implements IIssueDetailStore {
vote: data.vote,
};
- const filteredVotes = this.details[issueID].vote_items.filter(
+ const filteredVotes = (this.details[issueID].vote_items ?? []).filter(
(v) => v.actor_details?.id !== this.rootStore.user.data?.id
);
@@ -425,7 +425,7 @@ export class IssueDetailStore implements IIssueDetailStore {
};
removeIssueVote = async (anchor: string, issueID: string) => {
- const newVotes = this.details[issueID].vote_items.filter(
+ const newVotes = (this.details[issueID].vote_items ?? []).filter(
(v) => v.actor_details?.id !== this.rootStore.user.data?.id
);
diff --git a/apps/space/types/issue.d.ts b/apps/space/types/issue.d.ts
index 299aada242..1e3459f484 100644
--- a/apps/space/types/issue.d.ts
+++ b/apps/space/types/issue.d.ts
@@ -59,7 +59,7 @@ export interface IIssue extends Pick<
> {
comments: TIssuePublicComment[];
reaction_items: IIssueReaction[];
- vote_items: IVote[];
+ vote_items: IVote[] | null;
}
export type IPeekMode = "side" | "modal" | "full";
diff --git a/packages/types/src/issues/issue.ts b/packages/types/src/issues/issue.ts
index 8054b4c44c..7bac32481c 100644
--- a/packages/types/src/issues/issue.ts
+++ b/packages/types/src/issues/issue.ts
@@ -185,7 +185,7 @@ export interface IPublicIssue extends Pick<
> {
comments: TIssuePublicComment[];
reaction_items: IIssuePublicReaction[];
- vote_items: IPublicVote[];
+ vote_items: IPublicVote[] | null;
}
type TPublicIssueResponseResults =