π₯π₯π₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.
TypeScript boardsbug-trackerdjangodockerganttissue-trackerjirajira-alternativekanbanlinearpostgresqlproduct-managementproject-managementproject-planningpythonreactredistypesciptvitework-management
[WEB-2603] fix: remove validation of roles from the live server (#5761)
M. Palanikannanbe092ac99fa6
diff --git a/live/src/ce/lib/authentication.ts b/live/src/ce/lib/authentication.tsdeleted file mode 100644index 3d5a1ea48e..0000000000--- a/live/src/ce/lib/authentication.ts+++ /dev/null@@ -1,15 +0,0 @@-import { ConnectionConfiguration } from "@hocuspocus/server";-// types-import { TDocumentTypes } from "@/core/types/common.js";--type TArgs = {- connection: ConnectionConfiguration- cookie: string;- documentType: TDocumentTypes | undefined;- params: URLSearchParams;-}--export const authenticateUser = async (args: TArgs): Promise<void> => {- const { documentType } = args;- throw Error(`Authentication failed: Invalid document type ${documentType} provided.`);-}\ No newline at end of filediff --git a/live/src/core/hocuspocus-server.ts b/live/src/core/hocuspocus-server.tsindex fb30c8f828..0aa411b933 100644--- a/live/src/core/hocuspocus-server.ts+++ b/live/src/core/hocuspocus-server.ts@@ -12,15 +12,11 @@ export const getHocusPocusServer = async () => {name: serverName,onAuthenticate: async ({requestHeaders,- requestParameters,- connection,// user id used as token for authenticationtoken,}) => {// request headersconst cookie = requestHeaders.cookie?.toString();- // params- const params = requestParameters;if (!cookie) {throw Error("Credentials not provided");@@ -28,9 +24,7 @@ export const getHocusPocusServer = async () => {try {await handleAuthentication({- connection,cookie,- params,token,});} catch (error) {@@ -38,6 +32,6 @@ export const getHocusPocusServer = async () => {}},extensions,- debounce: 10000+ debounce: 10000,});};diff --git a/live/src/core/lib/authentication.ts b/live/src/core/lib/authentication.tsindex dbde17959a..ee01b02090 100644--- a/live/src/core/lib/authentication.ts+++ b/live/src/core/lib/authentication.ts@@ -1,28 +1,17 @@-import { ConnectionConfiguration } from "@hocuspocus/server";// servicesimport { UserService } from "@/core/services/user.service.js";-// types-import { TDocumentTypes } from "@/core/types/common.js";-// plane live lib-import { authenticateUser } from "@/plane-live/lib/authentication.js";// core helpersimport { manualLogger } from "@/core/helpers/logger.js";const userService = new UserService();type Props = {- connection: ConnectionConfiguration;cookie: string;- params: URLSearchParams;token: string;};export const handleAuthentication = async (props: Props) => {- const { connection, cookie, params, token } = props;- // params- const documentType = params.get("documentType")?.toString() as- | TDocumentTypes- | undefined;+ const { cookie, token } = props;// fetch current user infolet response;try {@@ -35,40 +24,6 @@ export const handleAuthentication = async (props: Props) => {throw Error("Authentication failed: Token doesn't match the current user.");}- if (documentType === "project_page") {- // params- const workspaceSlug = params.get("workspaceSlug")?.toString();- const projectId = params.get("projectId")?.toString();- if (!workspaceSlug || !projectId) {- throw Error(- "Authentication failed: Incomplete query params. Either workspaceSlug or projectId is missing."- );- }- // fetch current user's project membership info- try {- const projectMembershipInfo = await userService.getUserProjectMembership(- workspaceSlug,- projectId,- cookie- );- const projectRole = projectMembershipInfo.role;- // make the connection read only for roles lower than a member- if (projectRole < 15) {- connection.readOnly = true;- }- } catch (error) {- manualLogger.error("Failed to fetch project membership info:", error);- throw error;- }- } else {- await authenticateUser({- connection,- cookie,- documentType,- params,- });- }-return {user: {id: response.id,diff --git a/live/src/core/services/user.service.ts b/live/src/core/services/user.service.tsindex 09412aa532..39d200919a 100644--- a/live/src/core/services/user.service.ts+++ b/live/src/core/services/user.service.ts@@ -1,5 +1,5 @@// types-import type { IProjectMember, IUser } from "@plane/types";+import type { IUser } from "@plane/types";// servicesimport { API_BASE_URL, APIService } from "@/core/services/api.service.js";@@ -25,37 +25,4 @@ export class UserService extends APIService {throw error;});}-- async getUserWorkspaceMembership(- workspaceSlug: string,- cookie: string- ): Promise<IProjectMember> {- return this.get(`/api/workspaces/${workspaceSlug}/workspace-members/me/`,- {- headers: {- Cookie: cookie,- },- })- .then((response) => response?.data)- .catch((error) => {- throw error?.response;- });- }-- async getUserProjectMembership(- workspaceSlug: string,- projectId: string,- cookie: string- ): Promise<IProjectMember> {- return this.get(`/api/workspaces/${workspaceSlug}/projects/${projectId}/project-members/me/`,- {- headers: {- Cookie: cookie,- },- })- .then((response) => response?.data)- .catch((error) => {- throw error?.response;- });- }}