Skip to content

armgit / plane

Public Imported from GitHub
0

πŸ”₯πŸ”₯πŸ”₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.

[WEB-658] fix: multiple toast alerts on adding existing issues (#3889)

Aaryan Khandelwalc08d6987d09b
diff --git a/web/components/core/modals/existing-issues-list-modal.tsx b/web/components/core/modals/existing-issues-list-modal.tsx
index c064b02bec..3e3c2871c8 100644
--- a/web/components/core/modals/existing-issues-list-modal.tsx
+++ b/web/components/core/modals/existing-issues-list-modal.tsx
@@ -66,12 +66,6 @@ export const ExistingIssuesListModal: React.FC<Props> = (props) => {
await handleOnSubmit(selectedIssues).finally(() => setIsSubmitting(false));
handleClose();
-
- setToast({
- type: TOAST_TYPE.SUCCESS,
- title: "Success",
- message: `Issue${selectedIssues.length > 1 ? "s" : ""} added successfully`,
- });
};
useEffect(() => {
diff --git a/web/components/issues/issue-layouts/empty-states/cycle.tsx b/web/components/issues/issue-layouts/empty-states/cycle.tsx
index 7b86c16a5a..7f8c318c76 100644
--- a/web/components/issues/issue-layouts/empty-states/cycle.tsx
+++ b/web/components/issues/issue-layouts/empty-states/cycle.tsx
@@ -59,13 +59,22 @@ export const CycleEmptyState: React.FC<Props> = observer((props) => {
const issueIds = data.map((i) => i.id);
- await issues.addIssueToCycle(workspaceSlug.toString(), projectId, cycleId.toString(), issueIds).catch(() => {
- setToast({
- type: TOAST_TYPE.ERROR,
- title: "Error!",
- message: "Selected issues could not be added to the cycle. Please try again.",
- });
- });
+ await issues
+ .addIssueToCycle(workspaceSlug.toString(), projectId, cycleId.toString(), issueIds)
+ .then(() =>
+ setToast({
+ type: TOAST_TYPE.SUCCESS,
+ title: "Success!",
+ message: "Issues added to the cycle successfully.",
+ })
+ )
+ .catch(() =>
+ setToast({
+ type: TOAST_TYPE.ERROR,
+ title: "Error!",
+ message: "Selected issues could not be added to the cycle. Please try again.",
+ })
+ );
};
const emptyStateDetail = CYCLE_EMPTY_STATE_DETAILS["no-issues"];
diff --git a/web/components/issues/issue-layouts/empty-states/module.tsx b/web/components/issues/issue-layouts/empty-states/module.tsx
index c52d17af54..c170993356 100644
--- a/web/components/issues/issue-layouts/empty-states/module.tsx
+++ b/web/components/issues/issue-layouts/empty-states/module.tsx
@@ -59,6 +59,13 @@ export const ModuleEmptyState: React.FC<Props> = observer((props) => {
const issueIds = data.map((i) => i.id);
await issues
.addIssuesToModule(workspaceSlug.toString(), projectId?.toString(), moduleId.toString(), issueIds)
+ .then(() =>
+ setToast({
+ type: TOAST_TYPE.SUCCESS,
+ title: "Success!",
+ message: "Issues added to the module successfully.",
+ })
+ )
.catch(() =>
setToast({
type: TOAST_TYPE.ERROR,
diff --git a/web/components/issues/issue-layouts/kanban/headers/group-by-card.tsx b/web/components/issues/issue-layouts/kanban/headers/group-by-card.tsx
index 41dda4b213..b3cc24f289 100644
--- a/web/components/issues/issue-layouts/kanban/headers/group-by-card.tsx
+++ b/web/components/issues/issue-layouts/kanban/headers/group-by-card.tsx
@@ -65,7 +65,13 @@ export const HeaderGroupByCard: FC<IHeaderGroupByCard> = observer((props) => {
const issues = data.map((i) => i.id);
try {
- addIssuesToView && addIssuesToView(issues);
+ await addIssuesToView?.(issues);
+
+ setToast({
+ type: TOAST_TYPE.SUCCESS,
+ title: "Success!",
+ message: "Issues added to the cycle successfully.",
+ });
} catch (error) {
setToast({
type: TOAST_TYPE.ERROR,
diff --git a/web/components/issues/issue-layouts/list/headers/group-by-card.tsx b/web/components/issues/issue-layouts/list/headers/group-by-card.tsx
index 7edf89bf1a..acf26adb5f 100644
--- a/web/components/issues/issue-layouts/list/headers/group-by-card.tsx
+++ b/web/components/issues/issue-layouts/list/headers/group-by-card.tsx
@@ -47,7 +47,13 @@ export const HeaderGroupByCard = observer(
const issues = data.map((i) => i.id);
try {
- addIssuesToView && addIssuesToView(issues);
+ await addIssuesToView?.(issues);
+
+ setToast({
+ type: TOAST_TYPE.SUCCESS,
+ title: "Success!",
+ message: "Issues added to the cycle successfully.",
+ });
} catch (error) {
setToast({
type: TOAST_TYPE.ERROR,