Skip to content

armgit / plane

Public Imported from GitHub
0

πŸ”₯πŸ”₯πŸ”₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.

[WEB-1792] chore: updated UI notification tooltip on header and app sidebar (#5046)

guru_sainathd3ec1aa4229f
diff --git a/web/core/components/workspace-notifications/notification-app-sidebar-option.tsx b/web/core/components/workspace-notifications/notification-app-sidebar-option.tsx
index 9e418df2a1..0a7335df4f 100644
--- a/web/core/components/workspace-notifications/notification-app-sidebar-option.tsx
+++ b/web/core/components/workspace-notifications/notification-app-sidebar-option.tsx
@@ -29,7 +29,7 @@ export const NotificationAppSidebarOption: FC<TNotificationAppSidebarOption> = o
return <div className="absolute right-3.5 top-2 h-2 w-2 rounded-full bg-custom-primary-300" />;
return (
- <div className="text-[8px] ml-auto bg-custom-primary-100 text-white p-1 py-0.5 rounded-full">
+ <div className="ml-auto px-2.5 py-0.5 bg-custom-primary-100/20 text-custom-primary-100 text-xs font-semibold rounded-xl">
{getNumberCount(unreadNotificationsCount.total_unread_notifications_count)}
</div>
);
diff --git a/web/core/components/workspace-notifications/sidebar/header/root.tsx b/web/core/components/workspace-notifications/sidebar/header/root.tsx
index 98d5831d8e..05bb1e44c6 100644
--- a/web/core/components/workspace-notifications/sidebar/header/root.tsx
+++ b/web/core/components/workspace-notifications/sidebar/header/root.tsx
@@ -3,13 +3,15 @@
import { FC } from "react";
import { observer } from "mobx-react";
import { Bell } from "lucide-react";
-import { Breadcrumbs } from "@plane/ui";
+import { Breadcrumbs, Tooltip } from "@plane/ui";
// components
import { BreadcrumbLink } from "@/components/common";
import { SidebarHamburgerToggle } from "@/components/core";
import { NotificationSidebarHeaderOptions } from "@/components/workspace-notifications";
// helpers
import { getNumberCount } from "@/helpers/string.helper";
+// hooks
+import { usePlatformOS } from "@/hooks/use-platform-os";
type TNotificationSidebarHeader = {
workspaceSlug: string;
@@ -18,6 +20,8 @@ type TNotificationSidebarHeader = {
export const NotificationSidebarHeader: FC<TNotificationSidebarHeader> = observer((props) => {
const { workspaceSlug, notificationsCount } = props;
+ // hooks
+ const { isMobile } = usePlatformOS();
if (!workspaceSlug) return <></>;
return (
@@ -34,9 +38,15 @@ export const NotificationSidebarHeader: FC<TNotificationSidebarHeader> = observe
label={
<div className="flex items-center gap-2">
<div className="font-medium">Notifications</div>
- <div className="rounded-full text-xs px-1.5 py-0.5 bg-custom-primary-100 text-white">
- {getNumberCount(notificationsCount)}
- </div>
+ <Tooltip
+ isMobile={isMobile}
+ tooltipContent={`There are ${notificationsCount} ${notificationsCount > 1 ? "notifications" : "notification"} in this workspace`}
+ position="bottom"
+ >
+ <div className="px-2.5 py-0.5 bg-custom-primary-100/20 text-custom-primary-100 text-xs font-semibold rounded-xl">
+ {getNumberCount(notificationsCount)}
+ </div>
+ </Tooltip>
</div>
}
icon={<Bell className="h-4 w-4 text-custom-text-300" />}
diff --git a/web/core/store/issue/helpers/base-issues.store.ts b/web/core/store/issue/helpers/base-issues.store.ts
index 2c88834d3c..2f9601493a 100644
--- a/web/core/store/issue/helpers/base-issues.store.ts
+++ b/web/core/store/issue/helpers/base-issues.store.ts
@@ -1067,7 +1067,7 @@ export abstract class BaseIssuesStore implements IBaseIssuesStore {
currentModuleIds = uniq(concat([...currentModuleIds], moduleIds));
// For current Issue, update module Ids by calling current store's update Issue, without making an API call
- this.updateIssue(workspaceSlug, projectId, issueId, { module_ids: currentModuleIds }, false);
+ this.issueUpdate(workspaceSlug, projectId, issueId, { module_ids: currentModuleIds }, false);
});
if (moduleIds.includes(this.moduleId ?? "")) {