Skip to content

armgit / plane

Public Imported from GitHub
0

πŸ”₯πŸ”₯πŸ”₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.

[WEB-2606] fix: project members shouldn't be able to change others roles (#5802)

Ketan Sharmad7c564594867
diff --git a/web/core/components/project/settings/member-columns.tsx b/web/core/components/project/settings/member-columns.tsx
index 43f22c632a..ce24098d59 100644
--- a/web/core/components/project/settings/member-columns.tsx
+++ b/web/core/components/project/settings/member-columns.tsx
@@ -100,7 +100,7 @@ export const AccountTypeColumn: React.FC<AccountTypeProps> = observer((props) =>
} = useForm();
// store hooks
const {
- project: { updateMember },
+ project: { updateMember, getProjectMemberDetails },
workspace: { getWorkspaceMemberDetails },
} = useMember();
const { data: currentUser } = useUser();
@@ -111,7 +111,11 @@ export const AccountTypeColumn: React.FC<AccountTypeProps> = observer((props) =>
const isWorkspaceMember = [EUserPermissions.MEMBER].includes(
Number(getWorkspaceMemberDetails(rowData.member.id)?.role) ?? EUserPermissions.GUEST
);
- const isRoleNonEditable = isCurrentUser || (isProjectAdminOrGuest && !isWorkspaceMember);
+ const isCurrentUserProjectMember = currentUser
+ ? getProjectMemberDetails(currentUser.id)?.role === EUserPermissions.MEMBER
+ : false;
+ const isRoleNonEditable =
+ isCurrentUser || (isProjectAdminOrGuest && !isWorkspaceMember) || isCurrentUserProjectMember;
const checkCurrentOptionWorkspaceRole = (value: string) => {
const currentMemberWorkspaceRole = getWorkspaceMemberDetails(value)?.role as EUserPermissions | undefined;