Skip to content

armgit / plane

Public Imported from GitHub
0

πŸ”₯πŸ”₯πŸ”₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.

[WEB-1559] chore: add page prop to the quick actions dropdown (#4782)

Aaryan Khandelwald81a476e0ba3
diff --git a/web/core/components/pages/dropdowns/quick-actions.tsx b/web/core/components/pages/dropdowns/quick-actions.tsx
index 917b9f1330..a3a4dd848a 100644
--- a/web/core/components/pages/dropdowns/quick-actions.tsx
+++ b/web/core/components/pages/dropdowns/quick-actions.tsx
@@ -8,18 +8,17 @@ import { ArchiveIcon, ContextMenu, CustomMenu, TContextMenuItem, TOAST_TYPE, set
import { DeletePageModal } from "@/components/pages";
// helpers
import { copyUrlToClipboard } from "@/helpers/string.helper";
-// hooks
-import { usePage } from "@/hooks/store";
+// store
+import { IPageStore } from "@/store/pages/page.store";
type Props = {
- pageId: string;
+ page: IPageStore;
+ pageLink: string;
parentRef: React.RefObject<HTMLElement>;
- projectId: string;
- workspaceSlug: string;
};
export const PageQuickActions: React.FC<Props> = observer((props) => {
- const { pageId, parentRef, projectId, workspaceSlug } = props;
+ const { page, pageLink, parentRef } = props;
// states
const [deletePageModal, setDeletePageModal] = useState(false);
// store hooks
@@ -33,9 +32,8 @@ export const PageQuickActions: React.FC<Props> = observer((props) => {
canCurrentUserArchivePage,
canCurrentUserChangeAccess,
canCurrentUserDeletePage,
- } = usePage(pageId);
+ } = page;
- const pageLink = `${workspaceSlug}/projects/${projectId}/pages/${pageId}`;
const handleCopyText = () =>
copyUrlToClipboard(pageLink).then(() => {
setToast({
@@ -87,7 +85,7 @@ export const PageQuickActions: React.FC<Props> = observer((props) => {
return (
<>
- <DeletePageModal isOpen={deletePageModal} onClose={() => setDeletePageModal(false)} pageId={pageId} />
+ <DeletePageModal isOpen={deletePageModal} onClose={() => setDeletePageModal(false)} pageId={page.id ?? ""} />
<ContextMenu parentRef={parentRef} items={MENU_ITEMS} />
<CustomMenu placement="bottom-end" ellipsis closeOnSelect>
{MENU_ITEMS.map((item) => {
diff --git a/web/core/components/pages/list/block-item-action.tsx b/web/core/components/pages/list/block-item-action.tsx
index 8f7b434c1a..5d0b3771b0 100644
--- a/web/core/components/pages/list/block-item-action.tsx
+++ b/web/core/components/pages/list/block-item-action.tsx
@@ -24,8 +24,10 @@ export const BlockItemAction: FC<Props> = observer((props) => {
const { workspaceSlug, projectId, pageId, parentRef } = props;
// store hooks
- const { access, created_at, is_favorite, owned_by, addToFavorites, removeFromFavorites } = usePage(pageId);
+ const page = usePage(pageId);
const { getUserDetails } = useMember();
+ // derived values
+ const { access, created_at, is_favorite, owned_by, addToFavorites, removeFromFavorites } = page;
// derived values
const ownerDetails = owned_by ? getUserDetails(owned_by) : undefined;
@@ -83,7 +85,11 @@ export const BlockItemAction: FC<Props> = observer((props) => {
/>
{/* quick actions dropdown */}
- <PageQuickActions parentRef={parentRef} pageId={pageId} projectId={projectId} workspaceSlug={workspaceSlug} />
+ <PageQuickActions
+ parentRef={parentRef}
+ page={page}
+ pageLink={`${workspaceSlug}/projects/${projectId}/pages/${pageId}`}
+ />
</>
);
});