Skip to content

armgit / plane

Public Imported from GitHub
0

πŸ”₯πŸ”₯πŸ”₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.

chore: encode email before passing it as a query param (#4468)

Aaryan Khandelwale044a8c2aca1
diff --git a/packages/constants/src/auth.ts b/packages/constants/src/auth.ts
index 86e75f4ff7..c12b63d637 100644
--- a/packages/constants/src/auth.ts
+++ b/packages/constants/src/auth.ts
@@ -130,7 +130,7 @@ const errorCodeMessages: {
Your account is already registered. 
<Link
className="underline underline-offset-4 font-medium hover:font-bold transition-all"
- href={`/sign-in${email ? `?email=${email}` : ``}`}
+ href={`/sign-in${email ? `?email=${encodeURIComponent(email)}` : ``}`}
>
Sign In
</Link>
@@ -171,7 +171,7 @@ const errorCodeMessages: {
No account found.&nbsp;
<Link
className="underline underline-offset-4 font-medium hover:font-bold transition-all"
- href={`/${email ? `?email=${email}` : ``}`}
+ href={`/${email ? `?email=${encodeURIComponent(email)}` : ``}`}
>
Create one
</Link>
diff --git a/space/components/accounts/auth-forms/password.tsx b/space/components/accounts/auth-forms/password.tsx
index 8148ee4059..a4b22f0a04 100644
--- a/space/components/accounts/auth-forms/password.tsx
+++ b/space/components/accounts/auth-forms/password.tsx
@@ -69,7 +69,7 @@ export const PasswordForm: React.FC<Props> = (props) => {
<div className="mt-2 w-full pb-3">
{isSmtpConfigured ? (
<Link
- href={`/accounts/forgot-password?email=${email}`}
+ href={`/accounts/forgot-password?email=${encodeURIComponent(email)}`}
className="text-xs font-medium text-custom-primary-100"
>
Forgot your password?
diff --git a/space/helpers/authentication.helper.tsx b/space/helpers/authentication.helper.tsx
index 2626b35c23..60e103e6f2 100644
--- a/space/helpers/authentication.helper.tsx
+++ b/space/helpers/authentication.helper.tsx
@@ -116,7 +116,7 @@ const errorCodeMessages: {
Your account is already registered.&nbsp;
<Link
className="underline underline-offset-4 font-medium hover:font-bold transition-all"
- href={`/accounts/sign-in${email ? `?email=${email}` : ``}`}
+ href={`/accounts/sign-in${email ? `?email=${encodeURIComponent(email)}` : ``}`}
>
Sign In
</Link>
@@ -155,7 +155,7 @@ const errorCodeMessages: {
No account found.&nbsp;
<Link
className="underline underline-offset-4 font-medium hover:font-bold transition-all"
- href={`/${email ? `?email=${email}` : ``}`}
+ href={`/${email ? `?email=${encodeURIComponent(email)}` : ``}`}
>
Create one
</Link>
diff --git a/web/components/account/auth-forms/password.tsx b/web/components/account/auth-forms/password.tsx
index 3540372751..999a49ea21 100644
--- a/web/components/account/auth-forms/password.tsx
+++ b/web/components/account/auth-forms/password.tsx
@@ -76,7 +76,7 @@ export const AuthPasswordForm: React.FC<Props> = observer((props: Props) => {
{isSMTPConfigured ? (
<Link
onClick={() => captureEvent(FORGOT_PASSWORD)}
- href={`/accounts/forgot-password?email=${email}`}
+ href={`/accounts/forgot-password?email=${encodeURIComponent(email)}`}
className="text-xs font-medium text-custom-primary-100"
>
Forgot your password?
diff --git a/web/helpers/authentication.helper.tsx b/web/helpers/authentication.helper.tsx
index 0f331394bf..3de5132f76 100644
--- a/web/helpers/authentication.helper.tsx
+++ b/web/helpers/authentication.helper.tsx
@@ -127,7 +127,7 @@ const errorCodeMessages: {
Your account is already registered.&nbsp;
<Link
className="underline underline-offset-4 font-medium hover:font-bold transition-all"
- href={`/sign-in${email ? `?email=${email}` : ``}`}
+ href={`/sign-in${email ? `?email=${encodeURIComponent(email)}` : ``}`}
>
Sign In
</Link>
@@ -169,7 +169,7 @@ const errorCodeMessages: {
No account found.&nbsp;
<Link
className="underline underline-offset-4 font-medium hover:font-bold transition-all"
- href={`/${email ? `?email=${email}` : ``}`}
+ href={`/${email ? `?email=${encodeURIComponent(email)}` : ``}`}
>
Create one
</Link>