π₯π₯π₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.
TypeScript boardsbug-trackerdjangodockerganttissue-trackerjirajira-alternativekanbanlinearpostgresqlproduct-managementproject-managementproject-planningpythonreactredistypesciptvitework-management
[WEB-2615] fix: module date validation during chart distribution generation (#5791)
guru_sainathe9158f820f68
diff --git a/apiserver/plane/app/views/module/base.py b/apiserver/plane/app/views/module/base.pyindex d09848fd94..eafb63b0e4 100644--- a/apiserver/plane/app/views/module/base.py+++ b/apiserver/plane/app/views/module/base.py@@ -30,6 +30,7 @@ from rest_framework.response import Response# Module importsfrom plane.app.permissions import (ProjectEntityPermission,+ ProjectLitePermission,allow_permission,ROLE,)@@ -317,13 +318,12 @@ class ModuleViewSet(BaseViewSet):.order_by("-is_favorite", "-created_at"))- allow_permission(+ @allow_permission([ROLE.ADMIN,ROLE.MEMBER,])-def create(self, request, slug, project_id):project = Project.objects.get(workspace__slug=slug, pk=project_id)serializer = ModuleWriteSerializer(@@ -386,8 +386,7 @@ class ModuleViewSet(BaseViewSet):return Response(module, status=status.HTTP_201_CREATED)return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)- allow_permission([ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST])-+ @allow_permission([ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST])def list(self, request, slug, project_id):queryset = self.get_queryset().filter(archived_at__isnull=True)if self.fields:@@ -435,13 +434,7 @@ class ModuleViewSet(BaseViewSet):)return Response(modules, status=status.HTTP_200_OK)- allow_permission(- [- ROLE.ADMIN,- ROLE.MEMBER,- ]- )-+ @allow_permission([ROLE.ADMIN, ROLE.MEMBER])def retrieve(self, request, slug, project_id, pk):queryset = (self.get_queryset()@@ -672,7 +665,13 @@ class ModuleViewSet(BaseViewSet):"labels": label_distribution,"completion_chart": {},}- if modules and modules.start_date and modules.target_date:++ if (+ modules+ and modules.start_date+ and modules.target_date+ and modules.total_issues > 0+ ):data["distribution"]["completion_chart"] = burndown_plot(queryset=modules,slug=slug,@@ -838,6 +837,9 @@ class ModuleLinkViewSet(BaseViewSet):class ModuleFavoriteViewSet(BaseViewSet):model = UserFavorite+ permission_classes = [+ ProjectLitePermission,+ ]def get_queryset(self):return self.filter_queryset(diff --git a/apiserver/plane/app/views/view/base.py b/apiserver/plane/app/views/view/base.pyindex 861aa4292e..e48871e3b6 100644--- a/apiserver/plane/app/views/view/base.py+++ b/apiserver/plane/app/views/view/base.py@@ -431,8 +431,7 @@ class IssueViewViewSet(BaseViewSet):.distinct())- allow_permission(allowed_roles=[ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST])-+ @allow_permission(allowed_roles=[ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST])def list(self, request, slug, project_id):queryset = self.get_queryset()project = Project.objects.get(id=project_id)@@ -457,8 +456,7 @@ class IssueViewViewSet(BaseViewSet):).datareturn Response(views, status=status.HTTP_200_OK)- allow_permission(allowed_roles=[ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST])-+ @allow_permission(allowed_roles=[ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST])def retrieve(self, request, slug, project_id, pk):issue_view = (self.get_queryset().filter(pk=pk, project_id=project_id).first()@@ -498,8 +496,7 @@ class IssueViewViewSet(BaseViewSet):status=status.HTTP_200_OK,)- allow_permission(allowed_roles=[], creator=True, model=IssueView)-+ @allow_permission(allowed_roles=[], creator=True, model=IssueView)def partial_update(self, request, slug, project_id, pk):with transaction.atomic():issue_view = IssueView.objects.select_for_update().get(@@ -532,8 +529,7 @@ class IssueViewViewSet(BaseViewSet):serializer.errors, status=status.HTTP_400_BAD_REQUEST)- allow_permission(allowed_roles=[ROLE.ADMIN], creator=True, model=IssueView)-+ @allow_permission(allowed_roles=[ROLE.ADMIN], creator=True, model=IssueView)def destroy(self, request, slug, project_id, pk):project_view = IssueView.objects.get(pk=pk,@@ -578,8 +574,7 @@ class IssueViewFavoriteViewSet(BaseViewSet):.select_related("view"))- allow_permission([ROLE.ADMIN, ROLE.MEMBER])-+ @allow_permission([ROLE.ADMIN, ROLE.MEMBER])def create(self, request, slug, project_id):_ = UserFavorite.objects.create(user=request.user,@@ -589,8 +584,7 @@ class IssueViewFavoriteViewSet(BaseViewSet):)return Response(status=status.HTTP_204_NO_CONTENT)- allow_permission([ROLE.ADMIN, ROLE.MEMBER])-+ @allow_permission([ROLE.ADMIN, ROLE.MEMBER])def destroy(self, request, slug, project_id, view_id):view_favorite = UserFavorite.objects.get(project=project_id,diff --git a/apiserver/plane/utils/analytics_plot.py b/apiserver/plane/utils/analytics_plot.pyindex fd9f640585..1770e95ae9 100644--- a/apiserver/plane/utils/analytics_plot.py+++ b/apiserver/plane/utils/analytics_plot.py@@ -203,7 +203,7 @@ def burndown_plot(if module_id:# Get all dates between the two datesdate_range = [- (queryset.start_date + timedelta(days=x)).date()+ (queryset.start_date + timedelta(days=x))for x in range((queryset.target_date - queryset.start_date).days + 1)