π₯π₯π₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.
TypeScript boardsbug-trackerdjangodockerganttissue-trackerjirajira-alternativekanbanlinearpostgresqlproduct-managementproject-managementproject-planningpythonreactredistypesciptvitework-management
[WEB-5429] refactor: conditional hooks (#8114)
Aaryan Khandelwalf3031a44f77e
diff --git a/apps/web/core/components/issues/issue-layouts/calendar/base-calendar-root.tsx b/apps/web/core/components/issues/issue-layouts/calendar/base-calendar-root.tsxindex 575d012414..d9d31d31e0 100644--- a/apps/web/core/components/issues/issue-layouts/calendar/base-calendar-root.tsx+++ b/apps/web/core/components/issues/issue-layouts/calendar/base-calendar-root.tsx@@ -52,7 +52,8 @@ export const BaseCalendarRoot = observer((props: IBaseCalendarRoot) => {const { workspaceSlug } = useParams();// hooks- const storeType = isEpic ? EIssuesStoreType.EPIC : (useIssueStoreType() as CalendarStoreType);+ const fallbackStoreType = useIssueStoreType() as CalendarStoreType;+ const storeType = isEpic ? EIssuesStoreType.EPIC : fallbackStoreType;const { allowPermissions } = useUserPermissions();const { issues, issuesFilter, issueMap } = useIssues(storeType);const {diff --git a/apps/web/core/components/issues/issue-layouts/empty-states/archived-issues.tsx b/apps/web/core/components/issues/issue-layouts/empty-states/archived-issues.tsxindex 0e97f91063..e8889a4a03 100644--- a/apps/web/core/components/issues/issue-layouts/empty-states/archived-issues.tsx+++ b/apps/web/core/components/issues/issue-layouts/empty-states/archived-issues.tsx@@ -21,9 +21,7 @@ export const ProjectArchivedEmptyState: React.FC = observer(() => {// store hooksconst { allowPermissions } = useUserPermissions();// derived values- const archivedWorkItemFilter = projectId- ? useWorkItemFilterInstance(EIssuesStoreType.ARCHIVED, projectId)- : undefined;+ const archivedWorkItemFilter = useWorkItemFilterInstance(EIssuesStoreType.ARCHIVED, projectId);const canPerformEmptyStateActions = allowPermissions([EUserProjectRoles.ADMIN, EUserProjectRoles.MEMBER],EUserPermissionsLevel.PROJECTdiff --git a/apps/web/core/components/issues/issue-layouts/empty-states/cycle.tsx b/apps/web/core/components/issues/issue-layouts/empty-states/cycle.tsxindex 2ed456f504..4c322ca413 100644--- a/apps/web/core/components/issues/issue-layouts/empty-states/cycle.tsx+++ b/apps/web/core/components/issues/issue-layouts/empty-states/cycle.tsx@@ -36,7 +36,7 @@ export const CycleEmptyState: React.FC = observer(() => {const { toggleCreateIssueModal } = useCommandPalette();const { allowPermissions } = useUserPermissions();// derived values- const cycleWorkItemFilter = cycleId ? useWorkItemFilterInstance(EIssuesStoreType.CYCLE, cycleId) : undefined;+ const cycleWorkItemFilter = useWorkItemFilterInstance(EIssuesStoreType.CYCLE, cycleId);const cycleDetails = cycleId ? getCycleById(cycleId) : undefined;const isCompletedCycleSnapshotAvailable = !isEmpty(cycleDetails?.progress_snapshot ?? {});const isCompletedAndEmpty = isCompletedCycleSnapshotAvailable || cycleDetails?.status?.toLowerCase() === "completed";diff --git a/apps/web/core/components/issues/issue-layouts/empty-states/module.tsx b/apps/web/core/components/issues/issue-layouts/empty-states/module.tsxindex 6c30b79be9..2a9d872db4 100644--- a/apps/web/core/components/issues/issue-layouts/empty-states/module.tsx+++ b/apps/web/core/components/issues/issue-layouts/empty-states/module.tsx@@ -34,7 +34,7 @@ export const ModuleEmptyState: React.FC = observer(() => {const { toggleCreateIssueModal } = useCommandPalette();const { allowPermissions } = useUserPermissions();// derived values- const moduleWorkItemFilter = moduleId ? useWorkItemFilterInstance(EIssuesStoreType.MODULE, moduleId) : undefined;+ const moduleWorkItemFilter = useWorkItemFilterInstance(EIssuesStoreType.MODULE, moduleId);const canPerformEmptyStateActions = allowPermissions([EUserProjectRoles.ADMIN, EUserProjectRoles.MEMBER],EUserPermissionsLevel.PROJECTdiff --git a/apps/web/core/components/issues/issue-layouts/empty-states/project-issues.tsx b/apps/web/core/components/issues/issue-layouts/empty-states/project-issues.tsxindex a5a5e9ccbd..56602cd9cd 100644--- a/apps/web/core/components/issues/issue-layouts/empty-states/project-issues.tsx+++ b/apps/web/core/components/issues/issue-layouts/empty-states/project-issues.tsx@@ -22,7 +22,7 @@ export const ProjectEmptyState: React.FC = observer(() => {const { toggleCreateIssueModal } = useCommandPalette();const { allowPermissions } = useUserPermissions();// derived values- const projectWorkItemFilter = projectId ? useWorkItemFilterInstance(EIssuesStoreType.PROJECT, projectId) : undefined;+ const projectWorkItemFilter = useWorkItemFilterInstance(EIssuesStoreType.PROJECT, projectId);const canPerformEmptyStateActions = allowPermissions([EUserProjectRoles.ADMIN, EUserProjectRoles.MEMBER],diff --git a/apps/web/core/hooks/store/work-item-filters/use-work-item-filter-instance.ts b/apps/web/core/hooks/store/work-item-filters/use-work-item-filter-instance.tsindex 0cc356f860..686b5c6e83 100644--- a/apps/web/core/hooks/store/work-item-filters/use-work-item-filter-instance.ts+++ b/apps/web/core/hooks/store/work-item-filters/use-work-item-filter-instance.ts@@ -6,8 +6,8 @@ import { useWorkItemFilters } from "./use-work-item-filters";export const useWorkItemFilterInstance = (entityType: EIssuesStoreType,- entityId: string+ entityId: string | undefined): IWorkItemFilterInstance | undefined => {const { getFilter } = useWorkItemFilters();- return getFilter(entityType, entityId);+ return entityId ? getFilter(entityType, entityId) : undefined;};