Skip to content

armgit / plane

Public Imported from GitHub
0

πŸ”₯πŸ”₯πŸ”₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.

fix: eslint warnings and errors (#7479)

Aaryan Khandelwalf8353d3468ba
diff --git a/packages/editor/src/core/extensions/code/lowlight-plugin.ts b/packages/editor/src/core/extensions/code/lowlight-plugin.ts
index f5bbde612d..4d3973ef5c 100644
--- a/packages/editor/src/core/extensions/code/lowlight-plugin.ts
+++ b/packages/editor/src/core/extensions/code/lowlight-plugin.ts
@@ -1,3 +1,5 @@
+// TODO: check all the type errors and fix them
+
import { findChildren } from "@tiptap/core";
import { Node as ProsemirrorNode } from "@tiptap/pm/model";
import { Plugin, PluginKey } from "@tiptap/pm/state";
@@ -117,19 +119,15 @@ export function LowlightPlugin({
// Such transactions can happen during collab syncing via y-prosemirror, for example.
transaction.steps.some(
(step) =>
- // eslint-disable-next-line @typescript-eslint/ban-ts-comment
- // @ts-expect-error
+ // @ts-expect-error type error
step.from !== undefined &&
- // eslint-disable-next-line @typescript-eslint/ban-ts-comment
- // @ts-expect-error
+ // @ts-expect-error type error
step.to !== undefined &&
oldNodes.some(
(node) =>
- // eslint-disable-next-line @typescript-eslint/ban-ts-comment
- // @ts-expect-error
+ // @ts-expect-error type error
node.pos >= step.from &&
- // eslint-disable-next-line @typescript-eslint/ban-ts-comment
- // @ts-expect-error
+ // @ts-expect-error type error
node.pos + node.node.nodeSize <= step.to
)
))
diff --git a/packages/editor/src/core/helpers/scroll-to-node.ts b/packages/editor/src/core/helpers/scroll-to-node.ts
index d74e7532c5..7e5aa0979a 100644
--- a/packages/editor/src/core/helpers/scroll-to-node.ts
+++ b/packages/editor/src/core/helpers/scroll-to-node.ts
@@ -32,11 +32,8 @@ function scrollToNode(editor: Editor, pos: number): void {
}
}
-export function scrollToNodeViaDOMCoordinates(
- editor: Editor,
- pos: number,
- behavior?: "auto" | "smooth" | "instant"
-): void {
+// eslint-disable-next-line no-undef
+export function scrollToNodeViaDOMCoordinates(editor: Editor, pos: number, behavior?: ScrollBehavior): void {
const view = editor.view;
// Get the coordinates of the position
diff --git a/packages/editor/src/core/types/editor.ts b/packages/editor/src/core/types/editor.ts
index d409b88283..b91d5fdeee 100644
--- a/packages/editor/src/core/types/editor.ts
+++ b/packages/editor/src/core/types/editor.ts
@@ -111,7 +111,8 @@ export interface EditorRefApi extends EditorReadOnlyRefApi {
onDocumentInfoChange: (callback: (documentInfo: TDocumentInfo) => void) => () => void;
onHeadingChange: (callback: (headings: IMarking[]) => void) => () => void;
onStateChange: (callback: () => void) => () => void;
- scrollToNodeViaDOMCoordinates: (behavior?: "auto" | "smooth" | "instant", position?: number) => void;
+ // eslint-disable-next-line no-undef
+ scrollToNodeViaDOMCoordinates: (behavior?: ScrollBehavior, position?: number) => void;
setEditorValueAtCursorPosition: (content: string) => void;
setFocusAtPosition: (position: number) => void;
setProviderDocument: (value: Uint8Array) => void;
diff --git a/packages/editor/src/core/types/slash-commands-suggestion.ts b/packages/editor/src/core/types/slash-commands-suggestion.ts
index b5e8068849..5027c0309e 100644
--- a/packages/editor/src/core/types/slash-commands-suggestion.ts
+++ b/packages/editor/src/core/types/slash-commands-suggestion.ts
@@ -1,5 +1,5 @@
-import { Editor, Range } from "@tiptap/core";
-import { CSSProperties } from "react";
+import type { Editor, Range } from "@tiptap/core";
+import type { CSSProperties } from "react";
// types
import { TEditorCommands } from "@/types";